* [gentoo-dev] Allow fcaps.eclass to work with an empty FILECAPS array?
@ 2024-05-04 8:15 Hans de Graaff
0 siblings, 0 replies; only message in thread
From: Hans de Graaff @ 2024-05-04 8:15 UTC (permalink / raw)
To: gentoo-dev
[-- Attachment #1: Type: text/plain, Size: 735 bytes --]
Hi,
Last week I added some code to set filecaps in the apache2.eclass which
ended up breaking because in some cases because FILECAPS would be
empty. This happens because the fcaps eclass assumes that FILECAPS is
not empty and will call fcaps regardless.
This can obviously be fixed in the calling code, but I was wondering if
we should not fix this in fcaps.eclass by checking for an empty array.
I wanted to discuss this because I'm not sure what is considered to be
more important: allow for optional FILECAPS, or make it clear that
FILECAPS has not been set (by crashing).
I'd be happy to provide a patch if there is some consensus on this.
https://bugs.gentoo.org/930821 for reference.
Kind regards,
Hans
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-05-04 8:15 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-04 8:15 [gentoo-dev] Allow fcaps.eclass to work with an empty FILECAPS array? Hans de Graaff
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox