From: Hans de Graaff <graaff@gentoo.org>
To: gentoo-dev <gentoo-dev@lists.gentoo.org>
Subject: [gentoo-dev] Allow fcaps.eclass to work with an empty FILECAPS array?
Date: Sat, 04 May 2024 10:15:33 +0200 [thread overview]
Message-ID: <5f4ef49b2a28434eacad34553b0958f0d981858a.camel@gentoo.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 735 bytes --]
Hi,
Last week I added some code to set filecaps in the apache2.eclass which
ended up breaking because in some cases because FILECAPS would be
empty. This happens because the fcaps eclass assumes that FILECAPS is
not empty and will call fcaps regardless.
This can obviously be fixed in the calling code, but I was wondering if
we should not fix this in fcaps.eclass by checking for an empty array.
I wanted to discuss this because I'm not sure what is considered to be
more important: allow for optional FILECAPS, or make it clear that
FILECAPS has not been set (by crashing).
I'd be happy to provide a patch if there is some consensus on this.
https://bugs.gentoo.org/930821 for reference.
Kind regards,
Hans
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
reply other threads:[~2024-05-04 8:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f4ef49b2a28434eacad34553b0958f0d981858a.camel@gentoo.org \
--to=graaff@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox