Re: [gentoo-dev] [PATCH] toolchain.eclass: Fix strip exclusion for prefixed cross-compilers

[James Le Cuirot <chewi@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1281 bytes --]

On Mon, 2024-12-30 at 21:31 -0500, Ionen Wolkens wrote:
> On Mon, Dec 30, 2024 at 11:35:25PM +0000, James Le Cuirot wrote:
> > dostrip limitations mean that we cannot strip the CTARGET binaries in a
> > cross-compiler. There is already a `dostrip -x` call to exclude such
> > binaries from stripping, but it expects the argument to be unprefixed,
> > and the argument given was prefixed.
> > 
> > Signed-off-by: James Le Cuirot <chewi@gentoo.org>
> > ---
> >  eclass/toolchain.eclass | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/eclass/toolchain.eclass b/eclass/toolchain.eclass
> > index 602f994371452..486b5877be66d 100644
> > --- a/eclass/toolchain.eclass
> > +++ b/eclass/toolchain.eclass
> > @@ -2641,7 +2641,7 @@ toolchain_src_install() {
> >  	#  - "${D}${LIBPATH}"
> >  	# As dostrip does not specify host to override ${CHOST} tools just skip
> >  	# non-native binary stripping.
> > -	is_crosscompile && dostrip -x "${LIBPATH}"
> > +	is_crosscompile && dostrip -x "${LIBPATH#${EPREFIX}}"
> 
> Missing quotes in case of unlikely globs in EPREFIX
> 
> "${LIBPATH#"${EPREFIX}"}"

Ah yep, thanks. I always forget that weird rule.


> >  	cd "${S}" || die
> >  	if is_crosscompile; then
> > -- 
> > 2.47.1


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 858 bytes --]