Re: [gentoo-dev] [PATCH 0/8] virtualx.eclass: New API and EAPI=6 support

["Michał Górny" <mgorny@gentoo.org>]

Dnia 28 listopada 2015 14:24:13 CET, Justin Lecher <jlec@gentoo.org> napisał(a):
>The main new feature is the introduction of virtx(). This function
>executes
>the arguments inside a Xfvb context in contrast to the deprecated
>virtualmake which required to set VIRTUALX_COMMAND, which then gets
>executed.
>
>Xemake and Xeconf should be converted to "virtx emake" and "virtx
>econf",
>respectively.
>
>Justin Lecher (8):
>  virtualx.eclass: Use case/esac to handle supported EAPIs
>  virtualx.eclass: Only source eclas once
>  virtualx.eclass: Use eqawarn instead of ewarn "QA:..."
>  virtualx.eclass: Ban deprecated functionality in EAPI > 5
>  virtualx.eclass: Support EAPI=6
>  virtualx.eclass: Whitespace cleanup
>  virtualx.eclass: Add missing die
>  virtualx.eclass: Simplify API into single virtx()
>
>eclass/virtualx.eclass | 87
>+++++++++++++++++++++++++++++++++++++-------------
> 1 file changed, 65 insertions(+), 22 deletions(-)

Generally looks good, though i would reorder the patches so they make more sense alone. Like add new API first, then deprecate old, then ban it all, then enable 6.
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.