public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org,Tobias Klausmann <klausman@gentoo.org>
Subject: Re: [gentoo-dev] [RFC pre-GLEP] Gentoo Git Workflow
Date: Tue, 25 Jul 2017 13:49:04 +0200	[thread overview]
Message-ID: <598613A4-94CD-495F-86A1-4BE26FF2566B@gentoo.org> (raw)
In-Reply-To: <20170725105921.GA17195@skade.schwarzvogel.de>

Dnia 25 lipca 2017 12:59:21 CEST, Tobias Klausmann <klausman@gentoo.org> napisał(a):
>Hi! 
>
>On Tue, 25 Jul 2017, Michał Górny wrote:
>> The summary line is included in the short logs (<kbd>git log --
>> oneline</kbd>, gitweb, GitHub, mail subject) and therefore should
>> provide a short yet accurate description of the change. The summary
>line
>> starts with a logical unit name, followed by a colon, a space and a
>> short description of the most important changes. If a bug is
>associated
>> with a change, then it should be included in the summary line as
>> <kbd>#nnnnnn</kbd> or likewise. The summary line must not exceed 69
>> characters, and must not be wrapped.
>
>This limit can be a problem if there's a nontrivial change to the
>more than 80 packages in the tree that have more than forty characters
>in
>cat/pkg[0]. Is the only option there to do word-smithing or
>making the commit summary less usefu?
>
>Or do we have a "violate if necessary" agreement regarding that?

Yeah, i meant to apply the "must not" to wrapping but "should not" to length. Though I suggest you to ellipsize the package name, if it is unambiguous enough.

The problem is that if you exceed the length, the summary will be usually cut one way or another anyway.

>
>
>Regards,
>Tobias
>
>[0] 
>$ cd /usr/portage
>$ ls -d *-*/*|awk '{if (length>=40) {print length, $0}}'|sort -n


-- 
Best regards,
Michał Górny (by phone)


  reply	other threads:[~2017-07-25 11:49 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-25  8:05 [gentoo-dev] [RFC pre-GLEP] Gentoo Git Workflow Michał Górny
2017-07-25  8:23 ` Nicolas Bock
2017-07-25  8:49 ` Dirkjan Ochtman
2017-07-25 10:59 ` Tobias Klausmann
2017-07-25 11:49   ` Michał Górny [this message]
2017-07-25 11:25 ` Michael Orlitzky
2017-07-25 11:52   ` Michał Górny
2017-07-25 12:26     ` Michael Orlitzky
2017-07-25 13:23       ` Michał Górny
2017-07-25 16:12         ` Michael Orlitzky
2017-07-25 20:29           ` Mike Gilbert
2017-07-25 20:31             ` Michael Orlitzky
2017-07-25 20:55               ` Michał Górny
2017-07-25 22:26             ` Rich Freeman
2017-07-25 22:30               ` Michał Górny
2017-07-25 22:46                 ` Rich Freeman
2017-07-25 22:50                   ` Michał Górny
2017-07-25 13:26     ` Rich Freeman
2017-07-25 13:48       ` Michał Górny
2017-07-26  9:21         ` Ulrich Mueller
2017-07-26 17:04           ` Kristian Fiskerstrand
2017-07-26 17:20             ` Rich Freeman
2017-07-26 17:32               ` Kristian Fiskerstrand
2017-07-27  9:54               ` Kristian Fiskerstrand
2017-07-26 17:00   ` Kristian Fiskerstrand
2017-07-25 11:50 ` Jonas Stein
2017-07-25 12:28 ` [gentoo-dev] " Michael Palimaka
2017-07-25 13:36   ` Michał Górny
2017-07-26 17:05   ` Kristian Fiskerstrand
2017-07-26 22:20     ` Sam Jorna
2017-07-27  6:08     ` Daniel Campbell
2017-07-27 13:48     ` Michał Górny
2017-07-25 12:54 ` [gentoo-dev] " Joshua Kinard
2017-07-25 13:43   ` Michał Górny
2017-07-26 13:41 ` Brian Evans
2017-07-26 17:17 ` Kristian Fiskerstrand
2017-07-27 13:52   ` Michał Górny
2017-07-27 13:54     ` Kristian Fiskerstrand
2017-07-27 13:58       ` Michał Górny
2017-07-27 14:08         ` Kristian Fiskerstrand
2017-07-27 14:11           ` Michał Górny
2017-07-27 14:25             ` Kristian Fiskerstrand
2017-07-27 22:00 ` [gentoo-dev] " Duncan
2017-07-27 22:37 ` Duncan
2017-07-27 23:12 ` Duncan
2017-07-27 23:38 ` Duncan
2017-07-28  0:15 ` Duncan
2017-07-28 10:38 ` [gentoo-dev] " Andreas K. Huettel
2017-09-08 21:19 ` Rich Freeman
2017-09-09  0:00   ` Kristian Fiskerstrand
2017-09-09  7:47   ` Michał Górny
2017-09-09  9:29     ` Rich Freeman
2017-09-10  7:39     ` Daniel Campbell
2017-09-10  9:34       ` Michał Górny
2017-09-10 22:13         ` Daniel Campbell
2017-09-11  3:09           ` Dean Stephens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=598613A4-94CD-495F-86A1-4BE26FF2566B@gentoo.org \
    --to=mgorny@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    --cc=klausman@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox