public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-dev] Add GOBIN to ENV_UNSET in make.defaults
@ 2018-10-20 11:21 Pacho Ramos
  2018-10-21  1:59 ` Zac Medico
  0 siblings, 1 reply; 3+ messages in thread
From: Pacho Ramos @ 2018-10-20 11:21 UTC (permalink / raw
  To: gentoo-dev

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]

It seems that random values in GOBIN can affect the building of some packages:
https://bugs.gentoo.org/631776
https://bugs.gentoo.org/636506
https://bugs.gentoo.org/638572

I would then append it to ENV_UNSET in make.defaults to get that variable unset
without needing to do the same for every ebuild that could be affected by this

Any issues against this?

Thanks

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [gentoo-dev] Add GOBIN to ENV_UNSET in make.defaults
  2018-10-20 11:21 [gentoo-dev] Add GOBIN to ENV_UNSET in make.defaults Pacho Ramos
@ 2018-10-21  1:59 ` Zac Medico
  2018-11-04 13:55   ` Pacho Ramos
  0 siblings, 1 reply; 3+ messages in thread
From: Zac Medico @ 2018-10-21  1:59 UTC (permalink / raw
  To: gentoo-dev, Pacho Ramos


[-- Attachment #1.1: Type: text/plain, Size: 868 bytes --]

On 10/20/2018 04:21 AM, Pacho Ramos wrote:
> It seems that random values in GOBIN can affect the building of some packages:
> https://bugs.gentoo.org/631776
> https://bugs.gentoo.org/636506
> https://bugs.gentoo.org/638572
> 
> I would then append it to ENV_UNSET in make.defaults to get that variable unset
> without needing to do the same for every ebuild that could be affected by this
> 
> Any issues against this?

Seems reasonable, since the only purpose of GOBIN is to override the
directory where 'go install' will install a command. If we unset it
unconditionally, it means that the location will predictably default to
GOPATH/bin, which is exactly what we want.

We could handle it in the golang-build_src_install function, but that
wouldn't cover things that call 'go install' via a script or Makefile.

> Thanks
>
-- 
Thanks,
Zac


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 981 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [gentoo-dev] Add GOBIN to ENV_UNSET in make.defaults
  2018-10-21  1:59 ` Zac Medico
@ 2018-11-04 13:55   ` Pacho Ramos
  0 siblings, 0 replies; 3+ messages in thread
From: Pacho Ramos @ 2018-11-04 13:55 UTC (permalink / raw
  To: Zac Medico, gentoo-dev

[-- Attachment #1: Type: text/plain, Size: 1074 bytes --]

El sáb, 20-10-2018 a las 18:59 -0700, Zac Medico escribió:
> On 10/20/2018 04:21 AM, Pacho Ramos wrote:
> > It seems that random values in GOBIN can affect the building of some
> > packages:
> > https://bugs.gentoo.org/631776
> > https://bugs.gentoo.org/636506
> > https://bugs.gentoo.org/638572
> > 
> > I would then append it to ENV_UNSET in make.defaults to get that variable
> > unset
> > without needing to do the same for every ebuild that could be affected by
> > this
> > 
> > Any issues against this?
> 
> Seems reasonable, since the only purpose of GOBIN is to override the
> directory where 'go install' will install a command. If we unset it
> unconditionally, it means that the location will predictably default to
> GOPATH/bin, which is exactly what we want.
> 
> We could handle it in the golang-build_src_install function, but that
> wouldn't cover things that call 'go install' via a script or Makefile.
> 
> > Thanks
> > 

Done: 
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c06caedd7c6bb91be0b8e963eb2
cb98e74448f67

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-11-04 13:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-20 11:21 [gentoo-dev] Add GOBIN to ENV_UNSET in make.defaults Pacho Ramos
2018-10-21  1:59 ` Zac Medico
2018-11-04 13:55   ` Pacho Ramos

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox