From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id AFFB513829B for ; Sun, 29 May 2016 16:49:43 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 68FDB940CB; Sun, 29 May 2016 16:49:35 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 41C27143BF for ; Sun, 29 May 2016 16:49:34 +0000 (UTC) Received: from smtpd.astrali.lan (unknown [5.28.105.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: hd_brummy) by smtp.gentoo.org (Postfix) with ESMTPSA id 1C839340A9E for ; Sun, 29 May 2016 16:49:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by server.astrali.lan (Postfix) with ESMTP id 14BBF4474C for ; Sun, 29 May 2016 18:49:29 +0200 (CEST) X-Virus-Scanned: amavisd-new at astrali.lan Received: from smtpd.astrali.lan ([127.0.0.1]) by localhost (server.astrali.lan [127.0.0.1]) (amavisd-new, port 10024) with LMTP id dTSRm_Pu_GZW for ; Sun, 29 May 2016 18:49:23 +0200 (CEST) Received: from [192.168.3.9] (newmain.astrali.lan [192.168.3.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtpd.astrali.lan (Postfix) with ESMTPS id 4E559446C2 for ; Sun, 29 May 2016 18:49:23 +0200 (CEST) Subject: Re: [gentoo-dev] eclass/vdr-plugin-2.eclass EAPI=6 changes, plz review To: gentoo-dev@lists.gentoo.org References: <5739954B.4030102@astrali.lan> <10D376FC-417F-40A5-A151-0AC8296A7854@gentoo.org> <574222F7.7080206@astrali.lan> <20160526111647.29f280d5.mgorny@gentoo.org> From: Joerg Bornkessel X-Enigmail-Draft-Status: N1110 Message-ID: <574B1D92.7070303@astrali.lan> Date: Sun, 29 May 2016 18:49:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 In-Reply-To: <20160526111647.29f280d5.mgorny@gentoo.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Archives-Salt: b82b71b7-a395-4d1a-abb9-d4b9e9cad7f9 X-Archives-Hash: 4942f75d6864ed98cf98dc7c58b61e19 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Am 26.05.2016 um 11:16 schrieb Michał Górny: > Since you already committed it with all the todos inside, just the > important thing. > > On Sun, 22 May 2016 23:21:59 +0200 Joerg Bornkessel > wrote: > >> - - local docfile - - for docfile in README* HISTORY >> CHANGELOG; do - - [[ -f ${docfile} ]] && dodoc ${docfile} + >> local commondoc=( README* HISTORY CHANGELOG ) + for docfile in >> "${commondoc[@]}"; do + if [[ ${EAPI} == "6" ]]; then + >> local DOCS="${DOCS} ${docfile}" + [[ -f ${docfile} ]] >> && einstalldocs "${DOCS[@]}" + else + [[ -f >> ${docfile} ]] && dodoc ${docfile} + fi > > I have no clue what you're trying to achieve ... Oh please, forget this crap! After rereading einstalldocs, how it works and how is it to handle in .ebuild, here my simple rewrite to integrate it in EAPI=6 if [[ ${EAPI} != [45] ]]; then einstalldocs else local docfile for docfile in README* HISTORY CHANGELOG; do [[ -f ${docfile} ]] && dodoc ${docfile} done fi yepp, einstalldocs is supported in EAPI=5 from eutils.eclass too, but i will leave it untached as we use it in this way for EAPI=4,5 since long time. So we are save in the existing eapi=4,5 supported ebuilds in the tree. Thanks for your review and reply Cheers /dev/joerg - -- Joerg Bornkessel GnuPG Key: 0x93EB5F4DAA5832A1 Fingerprint: 0E0A A1EE 1DF4 41D7 A3F5 21C2 93EB 5F4D AA58 32A1 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.1 Comment: Signed-off-by: Jörg Bornkessel iQJ8BAEBCgBmBQJXSx2JXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQwRTBBQTFFRTFERjQ0MUQ3QTNGNTIxQzI5 M0VCNUY0REFBNTgzMkExAAoJEJPrX02qWDKhRsIP/3+PiGzWmlWfns0THCVjM2cb xstNG7P+qKSFyWD9tgmSeGLsp590wh8bDBh8LWGfEPayYgal5ps1FeEdSS+syND6 fBk8QcBBZlPUSupg4f0sNsOmOguvXDhYz8u9PX2yfbTWAiOSWQcjUyvzU2FascrZ bsCDhpEbDFbjS/vZJs52XCQhxU3WTFzchdn1+87JxDGslyMFe5+DojbDYeJLmkPK 9EeZ938PRAuaVNd28fE9A8YbueP59vvtL4oyTab/sWRv/FXsuFJbPlTd2+pOTYWJ EVRvQ9kUiHR+PX3T1m5m8KGa8ZEKR5O/2ibcwI8jlSpOM287/rypujjT+pycpz8A yQ+CF8L8g/SQZRyl3GAYrA/FhHRHXXskbBQOrELk+PywXS/7ccSIV+ySWdawf8UV gItXrWaFZDD6TjG08oXdp5IC1yMh2Vzna7GTPXUoYHJnDp4aZj6ZX0Z+zRRvSIGG MXRYsOMfpPWQOxpczD+oMuC973tv+Psr0c8gisKmK8ZEtdqVj2ZVtRRg/Jig7RhH qAmxMBVhxAYe8m/vSRfJC4zT2GmSZLbFAOKoy5r0Gc5t/PVvHDax2Ku46SpMuWSr gaWOcKTyZC+ynazduEIj4ZNKZhDEWnVx+OjcIVwPDV4cxRiHFVr2tuQK1Un8JXsu 8tuGDeoMd24HPEjuD5JA =oSFD -----END PGP SIGNATURE-----