Re: [gentoo-dev] eclass/vdr-plugin-2.eclass EAPI=6 changes, plz review

[Joerg Bornkessel <hd_brummy@gentoo.org>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Am 26.05.2016 um 11:16 schrieb Michał Górny:
> Since you already committed it with all the todos inside, just the
> important thing.
> 
> On Sun, 22 May 2016 23:21:59 +0200 Joerg Bornkessel
> <hd_brummy@gentoo.org> wrote:
> 
>> - -   local docfile - -   for docfile in README* HISTORY
>> CHANGELOG; do - -       [[ -f ${docfile} ]] && dodoc ${docfile} +
>> local commondoc=( README* HISTORY CHANGELOG ) +   for docfile in
>> "${commondoc[@]}"; do +       if [[ ${EAPI} == "6" ]]; then +
>> local DOCS="${DOCS} ${docfile}" +           [[ -f ${docfile} ]]
>> && einstalldocs "${DOCS[@]}" +       else +           [[ -f
>> ${docfile} ]] && dodoc ${docfile} +       fi
> 
> I have no clue what you're trying to achieve ...


Oh please, forget this crap!
After rereading einstalldocs, how it works and how is it to handle in
.ebuild, here my simple rewrite to integrate it in EAPI=6

<snipp>

    if [[ ${EAPI} != [45] ]]; then
        einstalldocs
    else
        local docfile
            for docfile in README* HISTORY CHANGELOG; do
                [[ -f ${docfile} ]] && dodoc ${docfile}
            done
    fi

</snapp>

yepp, einstalldocs is supported in EAPI=5 from eutils.eclass too,
but i will leave it untached as we use it in this way for EAPI=4,5
since long time.
So we are save in the existing eapi=4,5 supported ebuilds in the tree.

Thanks for your review and reply

Cheers

/dev/joerg

- -- 
Joerg Bornkessel <hd_brummy@gentoo.org>
GnuPG Key: 0x93EB5F4DAA5832A1
Fingerprint: 0E0A A1EE 1DF4 41D7 A3F5  21C2 93EB 5F4D AA58 32A1
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.1
Comment: Signed-off-by: Jörg Bornkessel <hd_brummy@gentoo.org>

iQJ8BAEBCgBmBQJXSx2JXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQwRTBBQTFFRTFERjQ0MUQ3QTNGNTIxQzI5
M0VCNUY0REFBNTgzMkExAAoJEJPrX02qWDKhRsIP/3+PiGzWmlWfns0THCVjM2cb
xstNG7P+qKSFyWD9tgmSeGLsp590wh8bDBh8LWGfEPayYgal5ps1FeEdSS+syND6
fBk8QcBBZlPUSupg4f0sNsOmOguvXDhYz8u9PX2yfbTWAiOSWQcjUyvzU2FascrZ
bsCDhpEbDFbjS/vZJs52XCQhxU3WTFzchdn1+87JxDGslyMFe5+DojbDYeJLmkPK
9EeZ938PRAuaVNd28fE9A8YbueP59vvtL4oyTab/sWRv/FXsuFJbPlTd2+pOTYWJ
EVRvQ9kUiHR+PX3T1m5m8KGa8ZEKR5O/2ibcwI8jlSpOM287/rypujjT+pycpz8A
yQ+CF8L8g/SQZRyl3GAYrA/FhHRHXXskbBQOrELk+PywXS/7ccSIV+ySWdawf8UV
gItXrWaFZDD6TjG08oXdp5IC1yMh2Vzna7GTPXUoYHJnDp4aZj6ZX0Z+zRRvSIGG
MXRYsOMfpPWQOxpczD+oMuC973tv+Psr0c8gisKmK8ZEtdqVj2ZVtRRg/Jig7RhH
qAmxMBVhxAYe8m/vSRfJC4zT2GmSZLbFAOKoy5r0Gc5t/PVvHDax2Ku46SpMuWSr
gaWOcKTyZC+ynazduEIj4ZNKZhDEWnVx+OjcIVwPDV4cxRiHFVr2tuQK1Un8JXsu
8tuGDeoMd24HPEjuD5JA
=oSFD
-----END PGP SIGNATURE-----