From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id ECA3A59CB2 for ; Sat, 16 Apr 2016 19:13:45 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B5FAF21C0DB; Sat, 16 Apr 2016 19:13:38 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id C214C21C0A5 for ; Sat, 16 Apr 2016 19:13:37 +0000 (UTC) Received: from greysprite.dite (cpe-74-77-145-97.buffalo.res.rr.com [74.77.145.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: blueness) by smtp.gentoo.org (Postfix) with ESMTPSA id 6D63F340AC7 for ; Sat, 16 Apr 2016 19:13:36 +0000 (UTC) Subject: Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/ To: gentoo-dev@lists.gentoo.org References: <1460833703.ad0c2ab2bdbd34f4550e49c56cfd5974d6a2c07a.blueness@gentoo> <20160416210556.08317672.mgorny@gentoo.org> From: "Anthony G. Basile" Message-ID: <57128EDB.1090009@gentoo.org> Date: Sat, 16 Apr 2016 15:13:31 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 In-Reply-To: <20160416210556.08317672.mgorny@gentoo.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Archives-Salt: 1690ddc6-1e65-474e-83d2-d236c0eaa9ed X-Archives-Hash: 88f5c16bc8be51c95b2ada7b3cffdfea On 4/16/16 3:05 PM, Michał Górny wrote: > On Sat, 16 Apr 2016 19:01:02 +0000 (UTC) > "Anthony G. Basile" wrote: > >> commit: ad0c2ab2bdbd34f4550e49c56cfd5974d6a2c07a >> Author: Anthony G. Basile gentoo org> >> AuthorDate: Sat Apr 16 19:08:23 2016 +0000 >> Commit: Anthony G. Basile gentoo org> >> CommitDate: Sat Apr 16 19:08:23 2016 +0000 >> URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ad0c2ab2 >> >> ssl-cert.eclass: add libressl support >> >> eclass/ssl-cert.eclass | 12 ++++++++---- >> 1 file changed, 8 insertions(+), 4 deletions(-) >> >> diff --git a/eclass/ssl-cert.eclass b/eclass/ssl-cert.eclass >> index 002de76..2538f4d 100644 >> --- a/eclass/ssl-cert.eclass >> +++ b/eclass/ssl-cert.eclass >> @@ -30,10 +30,10 @@ >> >> if [[ "${SSL_DEPS_SKIP}" == "0" ]]; then >> if [[ "${SSL_CERT_MANDATORY}" == "0" ]]; then >> - DEPEND="${SSL_CERT_USE}? ( dev-libs/openssl:0= )" >> + DEPEND="${SSL_CERT_USE}? ( || ( dev-libs/openssl:0= dev-libs/libressl:0= ) )" >> IUSE="${SSL_CERT_USE}" >> else >> - DEPEND="dev-libs/openssl:0=" >> + DEPEND="|| ( dev-libs/openssl:0= dev-libs/libressl:0= )" >> fi >> fi >> > > Congratulations! You've just committed an invalid dependency that is > going to cause true mayhem on every package using the eclass. > > But why would anyone send patches for review, or even start wondering > that we might be using USE=libressl all around for some reason... > It was discussed on the bug report and I asked robbat2. Revert then. -- Anthony G. Basile, Ph.D. Gentoo Linux Developer [Hardened] E-Mail : blueness@gentoo.org GnuPG FP : 1FED FAD9 D82C 52A5 3BAB DC79 9384 FA6E F52D 4BBA GnuPG ID : F52D4BBA