From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 2D6B858973 for ; Tue, 9 Feb 2016 06:38:12 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 7DCE321C171; Tue, 9 Feb 2016 06:38:00 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 7E3D521C16B for ; Tue, 9 Feb 2016 06:37:59 +0000 (UTC) Received: from [IPv6:2a02:8109:a640:180c:5ee0:c5ff:fe8e:77db] (unknown [IPv6:2a02:8109:a640:180c:5ee0:c5ff:fe8e:77db]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: patrick) by smtp.gentoo.org (Postfix) with ESMTPSA id 35E7A3409EC for ; Tue, 9 Feb 2016 06:37:58 +0000 (UTC) Subject: Re: [gentoo-dev] New USE_EXPAND NGINX_MODULES_STREAM To: gentoo-dev@lists.gentoo.org References: <56B27F5D.4040805@gentoo.org> <20160203234849.0d4ebc8f.mgorny@gentoo.org> <20160204102740.GA26130@meriadoc> <20160208224119.14a513e1.mgorny@gentoo.org> <20160208235919.5e1cb56f@gentp.lnet> From: Patrick Lauer Message-ID: <56B98916.809@gentoo.org> Date: Tue, 9 Feb 2016 07:37:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 In-Reply-To: <20160208235919.5e1cb56f@gentp.lnet> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Archives-Salt: a969783f-a154-46e0-9756-9eacf333c9ff X-Archives-Hash: 4ad650a82bcaa63e6b74bf248718dde1 On 02/08/2016 11:59 PM, Luis Ressel wrote: > On Tue, 9 Feb 2016 11:34:12 +1300 > Kent Fredric wrote: > >> nginx_modules_http_geoip? ( dev-libs/geoip ) >> nginx_modules_http_gunzip? ( sys-libs/zlib ) >> nginx_modules_http_gzip? ( sys-libs/zlib ) >> nginx_modules_http_gzip_static? ( sys-libs/zlib ) >> nginx_modules_http_image_filter? ( media-libs/gd[jpeg,png] ) >> nginx_modules_http_perl? ( >=dev-lang/perl-5.8 ) >> nginx_modules_http_rewrite? ( >=dev-libs/libpcre-4.2 ) >> nginx_modules_http_secure_link? ( >> userland_GNU? ( >> !libressl? ( dev-libs/openssl:0= ) >> libressl? ( dev-libs/libressl:= ) >> ) >> ) >> nginx_modules_http_xslt? ( dev-libs/libxml2 dev-libs/libxslt ) >> nginx_modules_http_lua? ( !luajit? ( dev-lang/lua:0= ) luajit? >> ( dev-lang/luajit:2= ) ) >> nginx_modules_http_auth_pam? ( virtual/pam ) >> nginx_modules_http_metrics? ( dev-libs/yajl ) >> nginx_modules_http_dav_ext? ( dev-libs/expat ) >> nginx_modules_http_security? ( >=dev-libs/libxml2-2.7.8 >> dev-libs/apr-util www-servers/apache ) >> nginx_modules_http_auth_ldap? ( net-nds/openldap[ssl?] ) >> > Thanks for citing this, I think it demonstrates mgorny's point rather > nicely; we have global USE flags for many of those modules: > > * nginx_modules_http_perl -> perl > * nginx_modules_http_auth_pam -> pam > * nginx_modules_http_auth_ldap -> ldap > * nginx_modules_http_geoip -> geoip > * nginx_modules_http_g(un)zip -> zlib > * nginx_modules_http_secure_link -> ssl > > The following two ones aren't quite as obvious, but could also be > changed: > * nginx_modules_http_rewrite -> pcre > * nginx_modules_http_image_filter -> gd > > Introduce new USE flags for the remaining few modules -- voilà, there > you go, no need for a new USE_EXPAND and the users will even get a > useful set of default modules enabled based on their global USE flags. > And now I can't figure out what I need to enable to have "rewrite" work. Good job! The names match the internal module names, which is what I care about. Figuring out if I need USE="zlib" or USE="compress" or even a combo is a lot more effort and frustrating than having to enable the useflag that has the name of the module. It might not be 'pure' or very aesthetical, but we try to get stuff done here.