From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id C615758973 for ; Wed, 3 Feb 2016 09:21:50 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B769421C026; Wed, 3 Feb 2016 09:21:43 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id AC07121C003 for ; Wed, 3 Feb 2016 09:21:42 +0000 (UTC) Received: from jmac.jlec.de (ip-88-153-156-92.hsi04.unitymediagroup.de [88.153.156.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: jlec) by smtp.gentoo.org (Postfix) with ESMTPSA id DCD71340C31; Wed, 3 Feb 2016 09:21:40 +0000 (UTC) Subject: Re: [gentoo-dev] Re: [PATCH 0/5] RFC: Patches for wxwidgets.eclass To: gentoo-dev@lists.gentoo.org References: <1454324913-27584-1-git-send-email-jlec@gentoo.org> <20160202163601.5586230a@tundra.gateway.pace.com> From: "Justin Lecher (jlec)" X-Enigmail-Draft-Status: N1110 Message-ID: <56B1C6A4.1070803@gentoo.org> Date: Wed, 3 Feb 2016 10:21:40 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 In-Reply-To: <20160202163601.5586230a@tundra.gateway.pace.com> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="T5gJUnlwNkefw9cwh2PTuVNAsKDQqfLbU" X-Archives-Salt: c34cdc45-9ad3-41c7-9b9a-bf6dced1df54 X-Archives-Hash: 09f231189026d36f034488ddbd96a61b This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --T5gJUnlwNkefw9cwh2PTuVNAsKDQqfLbU Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 02/02/16 23:36, Ryan Hill wrote: > On Mon, 1 Feb 2016 12:08:28 +0100 > Justin Lecher wrote: >=20 >> while tracking down the following error when running "egencache" >> >> GENTOO.GIT//eclass/wxwidgets.eclass: line 84: get_libdir: command not = found >> GENTOO.GIT//eclass/wxwidgets.eclass: line 84: get_libdir: command not = found >> GENTOO.GIT//eclass/wxwidgets.eclass: line 84: get_libdir: command not = found >> GENTOO.GIT//eclass/wxwidgets.eclass: line 84: get_libdir: command not = found >> GENTOO.GIT//eclass/wxwidgets.eclass: line 84: get_libdir: command not = found >> GENTOO.GIT//eclass/wxwidgets.eclass: line 84: get_libdir: command not = found >> GENTOO.GIT//eclass/wxwidgets.eclass: line 84: get_libdir: command not = found >> GENTOO.GIT//eclass/wxwidgets.eclass: line 84: get_libdir: command not = found >> GENTOO.GIT//eclass/wxwidgets.eclass: line 84: get_libdir: command not = found >> >> I found that the global scope get_libdir() usage of the wxwidgets.ecla= ss >> doens't work on EAPI=3D6. The following patches correct some minor thi= ngs >> and block EAPI=3D6 for now until the eclass is ready. >> >> Justin Lecher (5): >> wxwidgets.eclass: Update Copyright year >> wxwidgets.eclass: Fix whitespaces >> wxwidgets.eclass: unset unneeded variables in global scope after usa= ge >> wxwidgets.eclass: Only inherit eclass ones >> wxwidgets.eclass: Add EAPI support >> >> eclass/wxwidgets.eclass | 33 ++++++++++++++++++++++++--------- >> 1 file changed, 24 insertions(+), 9 deletions(-) >> >=20 > 1. I don't think most of this is necessary but go ahead I guess. Most of them are trivial, but excluding EAPI=3D6 from supported EAPIs is essential. The usage of get_libdir needs to be moved to a phase function. Which should perhaps be coupled with an env variable which is checked in the later function to ensure the phase function has been run. > 2. When did we start posting every @&#$! eclass change to g-dev? File = a bug > like a normal person. (There's already one open you could have used) I feel pretty "normal" when sending eclass changes to g-dev. Having code reviewed which influences a larger number of packages at once in the most public and open way is something we should strive for, isn't it? --T5gJUnlwNkefw9cwh2PTuVNAsKDQqfLbU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWscalXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ0QUU0N0I4NzFERUI0MTJFN0EyODE0NUFF OTQwMkE3OUIwMzUyOUEyAAoJEOlAKnmwNSmi9awP/28HitY9CO8UbsCkEJrfJtDq kqSHUZTFARK1qFjWXaBepwBU+KLOI4+uL4bGXhQj4hVuVVI+c7zYwQtGrS2r9tfF hwQovYjJuzgqCsf0ggqZ+gU2ebT3bwpnrHiD7ZY31+1JKGnNwetA4Zl0yQMCXPny pJ0UNGsYkaA1n3f4dZi97sNapH3S7Iw1NhasL080sPXrdqUp49b1bwK/RcVO0Yx2 GLIVk5MDFV3a8f+SMzRNXd53TuJMOR3FO3bns2anOaJq5/4E1+F1D+Wc0vQOJ8ag w4B+lprV1bL5MtRJBr6CHfqtcziPiBHvvNENbMX6oImD9xywZLlcYdSPTHqyfBTI DGsmlb7o5cVvwikx9wNoOhOW7VCpWZ/e6M3xaHOuDvdOhs+eG22MI/xHmv62SToL uTfIYKAU2yzO2qphAsqwYnFosM/y0hEBmDf74tdsiuJG2KpJ4m8tNNg1tbbyxaN/ vpxicmaTw8T2wb+ccBL4MCY6/sxKGdYEWYh6hwJ08Gs9Tiu2wWcV1zazBtZ3ZnTg ZXDMBiBVNWAFw5FUBPoNjdxE9j7np6CgasDDloqVuXBcX80edNtzCT15+lu0c4qf Fl3WgAnIiM3+ewGgFxZyU3W7sKnyUn7G/Zxxnh0NxBhir3pvH8A7tPbe6kjPramP 0l4LsFQzwIYzlDqjs1Lu =+w+0 -----END PGP SIGNATURE----- --T5gJUnlwNkefw9cwh2PTuVNAsKDQqfLbU--