From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id AFEDC58973 for ; Tue, 26 Jan 2016 03:34:15 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 2A36A21C01A; Tue, 26 Jan 2016 03:34:08 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 2F8C9E086B for ; Tue, 26 Jan 2016 03:34:07 +0000 (UTC) Received: from [192.168.1.41] (pool-173-72-254-242.clppva.fios.verizon.net [173.72.254.242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: jcallen) by smtp.gentoo.org (Postfix) with ESMTPSA id 4F95C340A13 for ; Tue, 26 Jan 2016 03:34:06 +0000 (UTC) Subject: [gentoo-dev] Re: New Eclasses: postgres and postgres-multi To: gentoo-dev@lists.gentoo.org References: <20160112192204.GB2008@gengoff.gsmr1.local> <20160124232940.GF32165@martineau.grandmasfridge.local> <56A561D7.8030708@gentoo.org> <20160125122920.GG32165@martineau.grandmasfridge.local> From: Jonathan Callen Message-ID: <56A6E92B.6080207@gentoo.org> Date: Mon, 25 Jan 2016 22:34:03 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 In-Reply-To: <20160125122920.GG32165@martineau.grandmasfridge.local> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Archives-Salt: a2a1f1eb-e77f-434a-acde-674c60eca99f X-Archives-Hash: b4e528866b7cb252cddd443861d1cb16 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 01/25/2016 07:29 AM, Aaron W. Swenson wrote: > On 2016-01-24 18:44, Michael Orlitzky wrote: >> On 01/24/2016 06:29 PM, Aaron W. Swenson wrote: >>> Okay, provided that the new USE_EXPAND is okay for >>> POSTGRES_TARGETS, attached are the eclasses that I'll commit to >>> the tree. >>> >> >>> case ${EAPI:-0} in 0|1|2|3|4) die "postgres-multi.eclass >>> requires EAPI 5 or higher" ;; *) ;; esac >> >> Does this really work with EAPI=6? I didn't try, but it looks >> like it would need an eapply_user somewhere in src_prepare. And, >> pedantry warning, there's no such thing as "EAPI 5 or higher." >> The lawyers will tell you to do something like this instead >> (stolen from git-r3): >> >> case "${EAPI:-0}" in 5|6) ;; *) die "Unsupported EAPI=${EAPI} >> (unknown) for ${ECLASS}" ;; esac >> >> That will require an edit for every new EAPI, but prevents weird >> crashes from things like a missing eapply_user. >> >> > > Thank you. > > I've added the eapply_user to postgres-multi and modified the case > condition to match the hot goods you're selling on the sly. > You missed the fix for EAPI in postgres-multi.eclass (it looks okay in the other eclass, though). - -- Jonathan Callen -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJWpukoAAoJEEIQbvYRB3mgD/8P/iCbnkSZGcwnbQ7EsV55apJ+ +AqzVJVbgvNkrK23JysYfDcT9Qthld5W1CX66YBg38PBJbDHrQPZQiAYypybVxo8 Liv8P2O4smBdYhIdFfcMw6ARyOpfRec1kiYiZr0YI/sM1pQF/UV2RuG+zJJILMwJ f3gNoRN0u58hMX5F1LZn0vRcrp9FqovNy1MMQ83u1qZp6SwK81IZFmHXoyyEWmaO zh1plMRfs9iD7DK6CzHBvRyIyShzJGcNLOkNM7qKU5GhAXi7bWuwx5ZZpD1peWLI Rn9xXfffyA62eU7EGvUQG/PuAU1PErT9+nFhH6qqSBnOpcR3kFO8a5zgfLHogzJT cDQf4XU9MxDCjvSF2c/2tnt1tXqBO7CTjvsaIgaok8vzLsmh6wwJCiqGb80gRWX7 4HIAKqH1QbBLfPkb54NQp8ixw1b+LmtcbgJQrpXpxJTrUqtnJKDaaXKblFO8eOW2 LeLYYxdzEz3rh6RiqT7NZ3iKKP6cFy7S4qlfe4qsXD7mns1eIqcx9Hdt8LuwDMnC zGLb7TBThrhBTt1gRdsXNDZUhkO5YohNqIgeUO1+bEnWS2UGZNf4Mv69HZTgipLO vZ2vPFevEW5zAqj8kXgZQjuyrq59TlCY9l2q/etf4oxk6e2Sge1TZ8dcfLA9kJ/E SIdeJ4XRl36+p1ANzG6c =F4Y9 -----END PGP SIGNATURE-----