From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 8B89058973 for ; Sun, 24 Jan 2016 23:44:23 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id AED2221C027; Sun, 24 Jan 2016 23:44:14 +0000 (UTC) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 7E57B21C005 for ; Sun, 24 Jan 2016 23:44:13 +0000 (UTC) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E28632015D for ; Sun, 24 Jan 2016 18:44:12 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Sun, 24 Jan 2016 18:44:12 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=GIKQ8pwu9QoSkIK FTLJIttrdneU=; b=YWc2lBxWgdSDlhA02JxtRwKKS20gRdMF6YR9pdb/s9NzXzx mAn0zkz7xWQ9DZSwZy2r6s4MDu+ZWpnHl42zEfrNeQepi5vgJPIydramqT+FfUBd gL5QrFZ7cYF+6MbAeJpWbjq/WWvKc1glCi6inwQs4ZdA0OGfZKZt8Wiv0exY= X-Sasl-enc: VEIj5ZbHz1j/89WEMXg0Q1N5w7tXZZCoHnw+DDj7/zU/ 1453679052 Received: from 127.0.0.1 (unknown [176.61.147.146]) by mail.messagingengine.com (Postfix) with ESMTPA id ED09B680147 for ; Sun, 24 Jan 2016 18:44:11 -0500 (EST) Subject: Re: [gentoo-dev] [PATCH v2 08/19] ebuild-maintenance: rewrite the text on adding binary files to the tree #558642 To: gentoo-dev@lists.gentoo.org References: <1453625173-9505-1-git-send-email-gokturk@binghamton.edu> <1453625173-9505-9-git-send-email-gokturk@binghamton.edu> <20160124150031.GH6302@ultrachro.me> <20160124184403.b5799ee40dc51d3006577e67@gentoo.org> From: =?UTF-8?B?R8O2a3TDvHJrIFnDvGtzZWs=?= Message-ID: <56A561C8.1090308@binghamton.edu> Date: Sun, 24 Jan 2016 18:44:08 -0500 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 In-Reply-To: <20160124184403.b5799ee40dc51d3006577e67@gentoo.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Archives-Salt: 192cbfd1-9f52-4678-b320-c8d1556c6b8d X-Archives-Hash: 7f6613e078bd6ce1e0deb6c2d4c4fe93 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Andrew Savchenko: > On Sun, 24 Jan 2016 16:00:31 +0100 Patrice Clement wrote: >> Sunday 24 Jan 2016 03:46:02, Gokturk Yuksek wrote : >>> Remove the paragraph about adding binary files to CVS. Replace >>> the instances of CVS with git. >>> >>> X-Gentoo-Bug-URL: >>> https://bugs.gentoo.org/show_bug.cgi?id=558642 Signed-off-by: >>> Gokturk Yuksek --- >>> ebuild-maintenance/text.xml | 19 +++---------------- 1 file >>> changed, 3 insertions(+), 16 deletions(-) >>> >>> diff --git a/ebuild-maintenance/text.xml >>> b/ebuild-maintenance/text.xml index ac68dcd..10709ea 100644 >>> --- a/ebuild-maintenance/text.xml +++ >>> b/ebuild-maintenance/text.xml @@ -42,22 +42,9 @@ above 20KB) >>> which should be distributed as tarballs via the >> link="::general-concepts/mirrors/#suitable-download-hosts">Gentoo >>> >>> mirror system so that people do not waste excessive >>> amounts of bandwidth and hard drive space. Also, you should >>> not add binary (non-ASCII) files to the -Portage CVS tree. If >>> you need to do this in another CVS tree, for -example, if you >>> need to add a small PNG graphic for whatever reason, -be sure >>> to add it to CVS by using the -kb option, like so: -

>>> - -
 -# cvs add
>>> -kb myphoto.png -
- -

-The -kb option tells >>> CVS that myphoto.png is a binary -file and should >>> be treated specially. For example, merging the -differences >>> between two different versions of this file should not be >>> -allowed to happen, for obvious reasons. Also, speaking of >>> merging +git tree. Also, speaking of merging changes, any >>> patches you add to Portage should generally not be >>> -compressed. This will allow CVS to merge changes and >>> correctly inform +compressed. This will allow git to merge >>> changes and correctly inform developers of conflicts.

>>> >>> @@ -149,7 +136,7 @@ simply, 1.0-gentoo.diff. >>> Also note that the gentoo extension informs people >>> that this patch was created by us, the Gentoo Linux >>> developers, rather than having been grabbed from a mailing list >>> or somewhere else. Again, you should not compress these >>> -patches because CVS does not play well with binary files. >>> +patches because git does not play well with binary files. >>>

>>> >>>

-- 2.4.10 >>> >>> >> >> "Again you should not compress these patches because git does >> not play well binary files". >> >> I'm not sure this statement still holds true with git. Does it? > > What about repoman checks? Will it still yell at >20 kB patches? > Yessir: https://gitweb.gentoo.org/proj/portage.git/tree/pym/repoman/checks/ebuilds/fetches.py?h=v2.2.27#n104 Even though it's not an issue with the git tree, rsync users will still suffer for >20kB patches. > Best regards, Andrew Savchenko > - -- gokturk -----BEGIN PGP SIGNATURE----- iQEcBAEBCgAGBQJWpWG/AAoJEIT4AuXAiM4zL4kIAJOQXCo2veG56lBhFjbYcusi KZwJUbSpzLW6liZYlVYE6lYLsi7m/AW0jNhTWHt4P6vqsyhSzvS+GzchZbPzmzel j9dSurvwVEtrAucLbinQ95Ym8biRVREw6ieC3D+cMZbsd9+yvLdA9vWvIDneOA09 BsTmibtNHXg3xusDhuAK3hl8lxZhu5dK0n733Mm/S3gnDJ952dGyQjIMxZhxdwSd QOK2VTRfUJx0hAoNUPNqd0flOCBfijdOR7qFDZuVNsyqZwTW7Du+k8uz8uRV+hKp 4dktGALgDh4tTd6O8kCrQBTBQ2IVC03Fvs3xvAYFV84WNug3tEYRB2mDUpGBzck= =bpVR -----END PGP SIGNATURE-----