From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id D2C951384B4 for ; Mon, 28 Dec 2015 14:16:32 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 6371021C011; Mon, 28 Dec 2015 14:16:25 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 591BDE07D2 for ; Mon, 28 Dec 2015 14:16:24 +0000 (UTC) Received: from jmac.jlec.de (static-2-1005.not-your-server.de [IPv6:2a01:4f8:191:22ca::2:1005]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: jlec) by smtp.gentoo.org (Postfix) with ESMTPSA id D1340340554; Mon, 28 Dec 2015 14:16:22 +0000 (UTC) Subject: Re: [gentoo-dev] [PATCH 5/9] check-reqs.eclass: Replace obsolete df option -m with -B ### To: gentoo-dev@lists.gentoo.org References: <1451292235-25265-1-git-send-email-jlec@gentoo.org> <1451292235-25265-6-git-send-email-jlec@gentoo.org> <20151228165826.3117022fcf5ed9f66d2089f6@gentoo.org> From: "Justin Lecher (jlec)" Message-ID: <56814433.4030206@gentoo.org> Date: Mon, 28 Dec 2015 15:16:19 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 In-Reply-To: <20151228165826.3117022fcf5ed9f66d2089f6@gentoo.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Archives-Salt: a39542e6-d91a-40b0-9e9f-b2e41f51c33e X-Archives-Hash: bfba91755c15989a686f4f2fb93df207 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 28/12/15 14:58, Andrew Savchenko wrote: > Hi, > > On Mon, 28 Dec 2015 09:43:51 +0100 Justin Lecher wrote: >> Signed-off-by: Justin Lecher --- >> eclass/check-reqs.eclass | 2 +- 1 file changed, 1 insertion(+), 1 >> deletion(-) >> >> diff --git a/eclass/check-reqs.eclass b/eclass/check-reqs.eclass >> index 138bfec..a32f8f8 100644 --- a/eclass/check-reqs.eclass +++ >> b/eclass/check-reqs.eclass @@ -306,7 +306,7 @@ check-reqs_disk() >> { ${size} \ "disk space at \"${path}\"" >> >> - space_megs=$(df -Pm "${1}" 2>/dev/null | awk 'FNR == 2 {print >> $4}') + space_megs=$(df -P -B 1048576 "${1}" 2>/dev/null | awk >> 'FNR == 2 {print $4}') > > Why not "-BM"? IMHO, this will be more readable, though, of > course, both arguments are semantically correct. > Because the output is different to the original version. $ (0) df -Pm / Filesystem 1048576-blocks Used Available Capacity Mounted on /dev/root 47244 25665 19157 58% / $ (0) df -P -B 1048576 / Filesystem 1048576-blocks Used Available Capacity Mounted on /dev/root 47244 25665 19157 58% / $ (0) df -P -BM / Filesystem 1048576-blocks Used Available Capacity Mounted on /dev/root 47244M 25665M 19157M 58% / -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWgUQzXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ0QUU0N0I4NzFERUI0MTJFN0EyODE0NUFF OTQwMkE3OUIwMzUyOUEyAAoJEOlAKnmwNSmiAEUP/RQJRmOaXjUD5orDBpXj/nvj CszwErjdwR43HwEsWeNVGMX1dXd0l1KM5p8tK5d4cn2u920VG8U8ef+SsfJhmfbn tnlM7hOhLmWZOqp57YpLeOvEpz0gqfjgKw3b/5Ywg4ISacufgAwNxbsSBnEmqQYv wETPveQAVETa0SoKD3Ki9PLRVVMN1t+/azMc9hn7+Tm2dth0QoF2sQ3Tm5VbQG/H BfQ4IWAUgpSrU991uliOt7kVTXTEShScSVPVACNoU63qtbNrYU92XGlDCAzPBsjp E8l7jdrlHXlgqu8zh+wvrJ/1qw3t3eqnB96pGe8HAfhdeJ6cVd3mNZITMNmmRl/G IaIdQ1dZlQLmP1ywK3bxS0ehi4XCmaQJKxP0vNAcnrlY41ea8qHp6UhrHT69c+Nr WKCKmanfaadsoLQkHgFiy4kGuXna20XyBdyr1zP9y6L8aSz8Cq6WbESkFu3aNgFT FTNOW4Z6fFwEc/Le3Kaowk8arv9E7yryjkqWzl4EO2nwUReg/4UmfkqgBCSOFh0z JUd1Xvoaeo6hiSEw/VmL+D/HCzlm7Z+SRtNKDR3d8gsyCY0lVMBZscBYdSpAKbn2 5RkkynZdR52Y+1cr8Rt9G7Uz+AaX82L19+WgYd9y5dcUynNJgDU5+SRFT1/hZfSR eO0pNmZ9ywefEvYh/2Mc =4hR/ -----END PGP SIGNATURE-----