public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Doug Goldstein <cardoe@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: python@gentoo.org, "Michał Górny" <mgorny@gentoo.org>
Subject: Re: [gentoo-dev] [PATCH 3/5] app-emulation/xen-tools: Make use of new python_gen_impl_dep function
Date: Thu, 24 Dec 2015 10:21:56 -0600	[thread overview]
Message-ID: <567C1BA4.4040801@gentoo.org> (raw)
In-Reply-To: <1450889080-1920-4-git-send-email-mgorny@gentoo.org>

[-- Attachment #1: Type: text/plain, Size: 4439 bytes --]

On 12/23/15 10:44 AM, Michał Górny wrote:
> ---
>  app-emulation/xen-tools/xen-tools-4.2.5-r10.ebuild | 2 +-
>  app-emulation/xen-tools/xen-tools-4.2.5-r11.ebuild | 2 +-
>  app-emulation/xen-tools/xen-tools-4.5.2-r2.ebuild  | 4 ++--
>  app-emulation/xen-tools/xen-tools-4.5.2-r3.ebuild  | 4 ++--
>  app-emulation/xen-tools/xen-tools-4.6.0-r4.ebuild  | 2 +-
>  app-emulation/xen-tools/xen-tools-4.6.0-r5.ebuild  | 2 +-
>  6 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/app-emulation/xen-tools/xen-tools-4.2.5-r10.ebuild b/app-emulation/xen-tools/xen-tools-4.2.5-r10.ebuild
> index 67e3d1c..d29aab3 100644
> --- a/app-emulation/xen-tools/xen-tools-4.2.5-r10.ebuild
> +++ b/app-emulation/xen-tools/xen-tools-4.2.5-r10.ebuild
> @@ -68,7 +68,7 @@ DEPEND="dev-libs/lzo:2
>  	api? ( dev-libs/libxml2
>  		net-misc/curl )
>  	${PYTHON_DEPS}
> -	pygrub? ( ${PYTHON_DEPS//${PYTHON_REQ_USE}/ncurses} )
> +	pygrub? ( $(python_gen_impl_dep ncurses) )
>  	sys-devel/bin86
>  	sys-devel/dev86
>  	dev-lang/perl
> diff --git a/app-emulation/xen-tools/xen-tools-4.2.5-r11.ebuild b/app-emulation/xen-tools/xen-tools-4.2.5-r11.ebuild
> index ae93f4d..392be10 100644
> --- a/app-emulation/xen-tools/xen-tools-4.2.5-r11.ebuild
> +++ b/app-emulation/xen-tools/xen-tools-4.2.5-r11.ebuild
> @@ -68,7 +68,7 @@ DEPEND="dev-libs/lzo:2
>  	api? ( dev-libs/libxml2
>  		net-misc/curl )
>  	${PYTHON_DEPS}
> -	pygrub? ( ${PYTHON_DEPS//${PYTHON_REQ_USE}/ncurses} )
> +	pygrub? ( $(python_gen_impl_dep ncurses) )
>  	sys-devel/bin86
>  	sys-devel/dev86
>  	dev-lang/perl
> diff --git a/app-emulation/xen-tools/xen-tools-4.5.2-r2.ebuild b/app-emulation/xen-tools/xen-tools-4.5.2-r2.ebuild
> index 8af652c..ba2f756 100644
> --- a/app-emulation/xen-tools/xen-tools-4.5.2-r2.ebuild
> +++ b/app-emulation/xen-tools/xen-tools-4.5.2-r2.ebuild
> @@ -87,8 +87,8 @@ DEPEND="${COMMON_DEPEND}
>  	${PYTHON_DEPS}
>  	api? ( dev-libs/libxml2
>  		net-misc/curl )
> -	pygrub? ( ${PYTHON_DEPS//${PYTHON_REQ_USE}/ncurses} )
> -	ovmf? ( ${PYTHON_DEPS//${PYTHON_REQ_USE}/sqlite} )
> +	pygrub? ( $(python_gen_impl_dep ncurses) )
> +	ovmf? ( $(python_gen_impl_dep sqlite) )
>  	!amd64? ( >=sys-apps/dtc-1.4.0 )
>  	amd64? ( sys-devel/bin86
>  		system-seabios? ( sys-firmware/seabios )
> diff --git a/app-emulation/xen-tools/xen-tools-4.5.2-r3.ebuild b/app-emulation/xen-tools/xen-tools-4.5.2-r3.ebuild
> index 59e9056..a147169 100644
> --- a/app-emulation/xen-tools/xen-tools-4.5.2-r3.ebuild
> +++ b/app-emulation/xen-tools/xen-tools-4.5.2-r3.ebuild
> @@ -90,8 +90,8 @@ DEPEND="${COMMON_DEPEND}
>  	${PYTHON_DEPS}
>  	api? ( dev-libs/libxml2
>  		net-misc/curl )
> -	pygrub? ( ${PYTHON_DEPS//${PYTHON_REQ_USE}/ncurses} )
> -	ovmf? ( ${PYTHON_DEPS//${PYTHON_REQ_USE}/sqlite} )
> +	pygrub? ( $(python_gen_impl_dep ncurses) )
> +	ovmf? ( $(python_gen_impl_dep sqlite) )
>  	!amd64? ( >=sys-apps/dtc-1.4.0 )
>  	amd64? ( sys-devel/bin86
>  		system-seabios? ( sys-firmware/seabios )
> diff --git a/app-emulation/xen-tools/xen-tools-4.6.0-r4.ebuild b/app-emulation/xen-tools/xen-tools-4.6.0-r4.ebuild
> index 57d618e..e9f84c0 100644
> --- a/app-emulation/xen-tools/xen-tools-4.6.0-r4.ebuild
> +++ b/app-emulation/xen-tools/xen-tools-4.6.0-r4.ebuild
> @@ -87,7 +87,7 @@ DEPEND="${COMMON_DEPEND}
>  	${PYTHON_DEPS}
>  	api? ( dev-libs/libxml2
>  		net-misc/curl )
> -	ovmf? ( ${PYTHON_DEPS//${PYTHON_REQ_USE}/sqlite} )
> +	ovmf? ( $(python_gen_impl_dep sqlite) )
>  	!amd64? ( >=sys-apps/dtc-1.4.0 )
>  	amd64? ( sys-devel/bin86
>  		system-seabios? ( sys-firmware/seabios )
> diff --git a/app-emulation/xen-tools/xen-tools-4.6.0-r5.ebuild b/app-emulation/xen-tools/xen-tools-4.6.0-r5.ebuild
> index 104fac9..ceb1402 100644
> --- a/app-emulation/xen-tools/xen-tools-4.6.0-r5.ebuild
> +++ b/app-emulation/xen-tools/xen-tools-4.6.0-r5.ebuild
> @@ -90,7 +90,7 @@ DEPEND="${COMMON_DEPEND}
>  	${PYTHON_DEPS}
>  	api? ( dev-libs/libxml2
>  		net-misc/curl )
> -	ovmf? ( ${PYTHON_DEPS//${PYTHON_REQ_USE}/sqlite} )
> +	ovmf? ( $(python_gen_impl_dep sqlite) )
>  	!amd64? ( >=sys-apps/dtc-1.4.0 )
>  	amd64? ( sys-devel/bin86
>  		system-seabios? ( sys-firmware/seabios )
> 

Acked-by: Doug Goldstein <cardoe@cardoe.com>

I actually made ncurses always required in recent versions to try and
avoid this hack. I'm glad there's a nicer way to officially do this.

-- 
Doug Goldstein


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 959 bytes --]

  reply	other threads:[~2015-12-24 16:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-23 16:44 [gentoo-dev] [PATCH 0/5] python-r1 suite: python_gen_impl_dep() function Michał Górny
2015-12-23 16:44 ` [gentoo-dev] [PATCH 1/5] python-r1.eclass: Introduce python_gen_impl_dep Michał Górny
2015-12-23 16:44 ` [gentoo-dev] [PATCH 2/5] python-single-r1.eclass: Add python_gen_impl_dep, alike in python-r1 Michał Górny
2015-12-23 16:44 ` [gentoo-dev] [PATCH 3/5] app-emulation/xen-tools: Make use of new python_gen_impl_dep function Michał Górny
2015-12-24 16:21   ` Doug Goldstein [this message]
2015-12-23 16:44 ` [gentoo-dev] [PATCH 4/5] dev-python/django: Make use of the " Michał Górny
2015-12-23 16:44 ` [gentoo-dev] [PATCH 5/5] sys-apps/portage: " Michał Górny
2015-12-24 15:30 ` [gentoo-dev] [PATCH 0/5] python-r1 suite: python_gen_impl_dep() function Peter Stuge
2015-12-29 17:40   ` Michał Górny
2015-12-31 14:52 ` Michał Górny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=567C1BA4.4040801@gentoo.org \
    --to=cardoe@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    --cc=mgorny@gentoo.org \
    --cc=python@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox