[gentoo-dev] [PATCH] python-utils-r1.eclass: python_export_utf8_locale(), ensure sane locale

[gentoo-dev] [PATCH] python-utils-r1.eclass: python_export_utf8_locale(), ensure sane locale

[Michał Górny]

Ensure that the locale selected by python_export_utf8_locale() conforms
to POSIX-ish case conversions. Otherwise, we may accidentally force
a locale that will break random ebuilds and programs.
---
 eclass/python-utils-r1.eclass | 24 ++++++++++++++++++++++--
 1 file changed, 22 insertions(+), 2 deletions(-)

diff --git a/eclass/python-utils-r1.eclass b/eclass/python-utils-r1.eclass
index 6ff1dd1..5e3338f 100644
--- a/eclass/python-utils-r1.eclass
+++ b/eclass/python-utils-r1.eclass
@@ -1141,6 +1141,24 @@ python_fix_shebang() {
 	done
 }
 
+# @FUNCTION: _python_check_locale_sanity
+# @USAGE: <locale>
+# @RETURN: 0 if sane, 1 otherwise
+# @DESCRIPTION:
+# Check whether the specified locale sanely maps between lowercase
+# and uppercase ASCII characters.
+_python_check_locale_sanity() {
+	local -x LC_CTYPE=${1}
+	local IFS=
+
+	local lc=( {a..z} )
+	local uc=( {A..Z} )
+	local input=${lc[*]}${uc[*]}
+
+	local output=$(tr '[:lower:][:upper:]' '[:upper:][:lower:]' <<<"${input}")
+	[[ ${output} == "${uc[*]}${lc[*]}" ]]
+}
+
 # @FUNCTION: python_export_utf8_locale
 # @RETURN: 0 on success, 1 on failure.
 # @DESCRIPTION:
@@ -1165,8 +1183,10 @@ python_export_utf8_locale() {
 
 		for lang in ${locales}; do
 			if [[ $(LC_CTYPE=${lang} locale charmap 2>/dev/null) == UTF-8 ]]; then
-				export LC_CTYPE=${lang}
-				return 0
+				if _python_check_locale_sanity "${lang}"; then
+					export LC_CTYPE=${lang}
+					return 0
+				fi
 			fi  
 		done
 
-- 
2.6.3

Re: [gentoo-dev] [PATCH] python-utils-r1.eclass: python_export_utf8_locale(), ensure sane locale

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 491 bytes --]

On Sun, 15 Nov 2015 10:21:51 +0100
Michał Górny <mgorny@gentoo.org> wrote:

> Ensure that the locale selected by python_export_utf8_locale() conforms
> to POSIX-ish case conversions. Otherwise, we may accidentally force
> a locale that will break random ebuilds and programs.
> ---
>  eclass/python-utils-r1.eclass | 24 ++++++++++++++++++++++--
>  1 file changed, 22 insertions(+), 2 deletions(-)

Merged.

-- 
Best regards,
Michał Górny
<http://dev.gentoo.org/~mgorny/>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 949 bytes --]

Re: [gentoo-dev] [PATCH] python-utils-r1.eclass: python_export_utf8_locale(), ensure sane locale

[Tyler Pohl]

[-- Attachment #1: Type: text/plain, Size: 732 bytes --]

Please reomove tylerapohl@gmail.com from the mailing list.  Or please let
me know how to get this done.

On Sat, Nov 28, 2015 at 11:10 AM, Michał Górny <mgorny@gentoo.org> wrote:

> On Sun, 15 Nov 2015 10:21:51 +0100
> Michał Górny <mgorny@gentoo.org> wrote:
>
> > Ensure that the locale selected by python_export_utf8_locale() conforms
> > to POSIX-ish case conversions. Otherwise, we may accidentally force
> > a locale that will break random ebuilds and programs.
> > ---
> >  eclass/python-utils-r1.eclass | 24 ++++++++++++++++++++++--
> >  1 file changed, 22 insertions(+), 2 deletions(-)
>
> Merged.
>
> --
> Best regards,
> Michał Górny
> <http://dev.gentoo.org/~mgorny/>
>



-- 
Tyler Pohl

[-- Attachment #2: Type: text/html, Size: 1388 bytes --]

Re: [gentoo-dev] [PATCH] python-utils-r1.eclass: python_export_utf8_locale(), ensure sane locale

[Michael Orlitzky]

On 12/17/2015 08:23 PM, Tyler Pohl wrote:
> Please reomove tylerapohl@gmail.com <mailto:tylerapohl@gmail.com> from
> the mailing list.  Or please let me know how to get this done.
> 

You are doing too much work, Michał.

To unsubscribe, send a message to the address contained in the
List-Unsubscribe header of this (and ever other) list message:

  List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>

See also,

  https://www.gentoo.org/get-involved/mailing-lists/instructions.html