public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Doug Goldstein <cardoe@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCHES] multilib-build & multilib-minimal EAPI 6 patchset
Date: Thu, 10 Dec 2015 23:57:19 -0600	[thread overview]
Message-ID: <566A65BF.5080307@gentoo.org> (raw)
In-Reply-To: <1449428274-20439-1-git-send-email-mgorny@gentoo.org>

[-- Attachment #1: Type: text/plain, Size: 600 bytes --]

On 12/6/15 12:57 PM, Michał Górny wrote:
> Hi, everyone.
> 
> Here's a patchset for review. Changes:
> 
> 1. eclass-generated variables are read-only,
> 2. missing error checks (||die) added,
> 3. 'unset -f' used to wipe local and temporary functions from the env,
> 4. deprecated function QA warnings turned into bans for EAPI 6,
> 5. eutils inherit fixes/updates.
> 
> Please review. I've tested it on a set of randomly selected packages.
> 
> 

Its worth noting that you should probably be utilizing --cover-letter to
git format-patch to generate this.

-- 
Doug Goldstein


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 959 bytes --]

      parent reply	other threads:[~2015-12-11  5:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-06 18:57 [gentoo-dev] [PATCHES] multilib-build & multilib-minimal EAPI 6 patchset Michał Górny
2015-12-06 18:57 ` [gentoo-dev] [PATCH 1/9] multilib-build.eclass: Mark eclass-generated variables read-only Michał Górny
2015-12-06 18:57 ` [gentoo-dev] [PATCH 2/9] multilib-build.eclass: Add missing error checks Michał Górny
2015-12-06 20:23   ` James Le Cuirot
2015-12-06 20:28     ` James Le Cuirot
2015-12-06 18:57 ` [gentoo-dev] [PATCH 3/9] multilib-build.eclass: Unset local functions after use Michał Górny
2015-12-06 18:57 ` [gentoo-dev] [PATCH 4/9] multilib-build.eclass: Unset global-setting function " Michał Górny
2015-12-06 18:57 ` [gentoo-dev] [PATCH 5/9] multilib-build.eclass: Ban deprecated functions in EAPI 6 Michał Górny
2015-12-06 18:57 ` [gentoo-dev] [PATCH 6/9] multilib-build.eclass: Add missing eutils inherit for eqawarn Michał Górny
2015-12-06 18:57 ` [gentoo-dev] [PATCH 7/9] multilib-build.eclass: Enable EAPI 6 Michał Górny
2015-12-06 21:32   ` Ulrich Mueller
2015-12-06 21:43     ` James Le Cuirot
2015-12-06 21:48       ` Ulrich Mueller
2015-12-06 18:57 ` [gentoo-dev] [PATCH 8/9] multilib-minimal.eclass: Remove eutils in EAPI 6 (einstalldocs built-in) Michał Górny
2015-12-06 18:57 ` [gentoo-dev] [PATCH 9/9] multilib-minimal.eclass: Enable EAPI 6 Michał Górny
2015-12-09 20:45 ` [gentoo-dev] [PATCHES] multilib-build & multilib-minimal EAPI 6 patchset Michał Górny
2015-12-11  5:57 ` Doug Goldstein [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=566A65BF.5080307@gentoo.org \
    --to=cardoe@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox