public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Michael Orlitzky <mjo@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: app-emulation/runc/
Date: Mon, 7 Dec 2015 13:49:43 -0500	[thread overview]
Message-ID: <5665D4C7.6000904@gentoo.org> (raw)
In-Reply-To: <CAEdQ38F_Ld6zMNpAnG9Xxs6oPUTDT9kyspO7-4X8UCLJOfe00g@mail.gmail.com>

On 12/07/2015 01:26 PM, Matt Turner wrote:
>>
>> I fixed it now.
> 
> This is happening with some frequency. Could we install a server-side
> git hook that prevents pushes if an ebuild is added without a Manifest
> change? It wouldn't have to verify anything more than that to catch
> nearly all of these problems.
> 

The last time this happened I had the same idea and sat down to write
one. The pre-push hook would do something like,

  * Get a list of cat/pkg affected by the push

  * Compare that list to profiles/categories to see which ones are
    packages (and should thus have manifests)

  * Verify the integrity of the files in each affected package by using
    something like `repoman manifest-check`

I gave up when I realized that this final step requires network access.
The missing manifest updates are for the distfiles, not the ebuilds. But
you could probably still fake it. For example, if any ebuild files are
added/removed, you expect Manifest to change.



  reply	other threads:[~2015-12-07 18:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1449465322.37c1ec7ef31a51206421f03a2df489ec7d7ca244.cardoe@gentoo>
2015-12-07 18:19 ` [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: app-emulation/runc/ Robin H. Johnson
2015-12-07 18:26   ` Matt Turner
2015-12-07 18:49     ` Michael Orlitzky [this message]
2015-12-07 18:58     ` Mike Gilbert
2015-12-07 19:20       ` Matt Turner
2015-12-07 19:36         ` [gentoo-dev] git update hook: detecting missing Manifest DIST entries Robin H. Johnson
2015-12-08  0:47           ` Peter Stuge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5665D4C7.6000904@gentoo.org \
    --to=mjo@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox