From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 84D991384B4 for ; Sun, 29 Nov 2015 12:02:51 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 39AE221C089; Sun, 29 Nov 2015 12:02:38 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 3534F21C020 for ; Sun, 29 Nov 2015 12:02:37 +0000 (UTC) Received: from jmac.jlec.de (static-2-1005.not-your-server.de [IPv6:2a01:4f8:191:22ca::2:1005]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: jlec) by smtp.gentoo.org (Postfix) with ESMTPSA id A11DA33F9D2; Sun, 29 Nov 2015 12:02:35 +0000 (UTC) Subject: Re: [gentoo-dev] [PATCH 4/8] virtualx.eclass: Ban deprecated functionality in EAPI > 5 To: gentoo-dev@lists.gentoo.org References: <5E6CCF53-839B-4BBD-B9BB-BFF4D70612A0@gentoo.org> <1448727664-25886-1-git-send-email-jlec@gentoo.org> <1448727664-25886-4-git-send-email-jlec@gentoo.org> <20151129105734.20600ae1.mgorny@gentoo.org> From: "Justin Lecher (jlec)" Message-ID: <565AE956.5060602@gentoo.org> Date: Sun, 29 Nov 2015 13:02:30 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 In-Reply-To: <20151129105734.20600ae1.mgorny@gentoo.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Archives-Salt: 94d8fc50-160d-4395-8008-9fff127049be X-Archives-Hash: 50928b8a3cdbccd808f05c40fb0b479e -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 29/11/15 10:57, Michał Górny wrote: > On Sat, 28 Nov 2015 17:21:00 +0100 Justin Lecher > wrote: > >> Signed-off-by: Justin Lecher --- >> eclass/virtualx.eclass | 5 +++++ 1 file changed, 5 insertions(+) >> >> diff --git a/eclass/virtualx.eclass b/eclass/virtualx.eclass >> index 230897b..a5e5457 100644 --- a/eclass/virtualx.eclass +++ >> b/eclass/virtualx.eclass @@ -59,6 +59,8 @@ case >> ${VIRTUALX_REQUIRED} in RDEPEND="" ;; optional|tests) + [[ >> ${EAPI} == [2345] ]] \ + || die 'Values "optional" and "tests" >> are unsupported for VIRTUALX_REQUIRED' > > You don't mention EAPI here, which can get confusing. Valid point. > >> # deprecated section YAY. eqawarn "VIRTUALX_REQUIRED=optional and >> VIRTUALX_REQUIRED=tests are deprecated." eqawarn "You can drop >> the variable definition completely from ebuild," @@ -177,6 +179,9 >> @@ virtualmake() { Xmake() { debug-print-function ${FUNCNAME} >> "$@" >> >> + [[ ${EAPI} == [2345] ]] \ + || die "${FUNCNAME} is removed in >> EAPI > 5; use Xemake -j1 instead" + eqawarn "you should not >> execute make directly" eqawarn "rather execute Xemake -j1 if you >> have issues with parallel make" VIRTUALX_COMMAND="emake -j1" >> virtualmake "$@" > > Still, if you introduced virtx earlier, you wouldn't have to > change this die message later on ;-). > Principally you are right, but resorting the patches generates lots of merge conflicts. But let me practice my git skills -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWWulWXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ0QUU0N0I4NzFERUI0MTJFN0EyODE0NUFF OTQwMkE3OUIwMzUyOUEyAAoJEOlAKnmwNSmiDUwP/09Q4xMEfaPeAlBIrv120PDc uqkJeBGHuKDtR6gmgydg+5bVdj6UwElZUsOaNMuBMkCAcrnHfP2WQ/lJafooK4K+ baiVqyFXTKemR8ob2hNLLD5lrvWijvjzc9TAutpfVvJm/NnGNRF2BpmnNKMtVWBO 0RP1pl+Wfjbzzb52KT96GUeeJqunY0EReuoZ2U9pG1HAnVbOGNacxkeSeJA+pfQ4 FQPqhnDAOQMS0p/uXro8h8TeDRIF2wwcRvmCOePKjRF/Ut6sw1/Pogj6iuTxTyaz m16ebTJmJ1GKc5mk6Fy4yDp6OR8tdgVwYsq+tjq9fMARqDOA/eJRS0I6/uIgaj0h 0dHzBYXxtTBixseVvPXAHY80RWSf5nseTceYVPSuHp+PRAhkrVneWsWfnBelqyzS Xj+jAPxDRU4gPat3SFt1fRER6A9Ij5VzRTHEEca/kjFvzwxmRs+MxDd7AN8IJK/v IhfDCgWf6kth0iCKHUkPZgd/ZOoHOUW4rMsGylObWQpCKz9Uzlo/T44Mj5Lr38nK Ydr1AND394O+74EOSGl2IcQiEFUQcrRIkUyOHIqBex/GAaL1wbyfcQ2u7mtNmddm Jc5jIM/FzmcDAnZgkxii69fjGb46HsPBUtriAmPydh7mN/ahHy0sPbQqxT3ANYxU QTYUPft2ma0fmb9TJjO4 =ZaQj -----END PGP SIGNATURE-----