From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id A72BE1384B4 for ; Sat, 28 Nov 2015 15:59:37 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id F248921C0D4; Sat, 28 Nov 2015 15:59:33 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id E62FA21C0C6 for ; Sat, 28 Nov 2015 15:59:32 +0000 (UTC) Received: from jmac.jlec.de (ip-88-153-156-92.hsi04.unitymediagroup.de [88.153.156.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: jlec) by smtp.gentoo.org (Postfix) with ESMTPSA id 085FF340686; Sat, 28 Nov 2015 15:59:28 +0000 (UTC) Subject: Re: [gentoo-dev] [PATCH 4/8] virtualx.eclass: Ban deprecated functionality in EAPI > 5 To: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= , gentoo-dev@lists.gentoo.org References: <1448717061-11581-1-git-send-email-jlec@gentoo.org> <1448717061-11581-5-git-send-email-jlec@gentoo.org> <2647371C-3C43-4282-850C-EEAA27A61FCD@gentoo.org> <5659B574.1030202@gentoo.org> <63B23F81-6193-48AB-949A-E8B9C8DF42F8@gentoo.org> From: "Justin Lecher (jlec)" Message-ID: <5659CF5D.6080602@gentoo.org> Date: Sat, 28 Nov 2015 16:59:25 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 In-Reply-To: <63B23F81-6193-48AB-949A-E8B9C8DF42F8@gentoo.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Archives-Salt: ec06b1ca-71b6-40d2-abe1-00cf7ff1478b X-Archives-Hash: d4fcb15ddf723250f322a59e158e9cd9 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 28/11/15 16:57, Michał Górny wrote: > > > Dnia 28 listopada 2015 15:08:52 CET, "Justin Lecher (jlec)" > napisał(a): On 28/11/15 15:03, Michał Górny > wrote: >>>> >>>> >>>> Dnia 28 listopada 2015 14:24:17 CET, Justin Lecher >>>> napisał(a): >>>>> Signed-off-by: Justin Lecher --- >>>>> eclass/virtualx.eclass | 4 ++++ 1 file changed, 4 >>>>> insertions(+) >>>>> >>>>> diff --git a/eclass/virtualx.eclass >>>>> b/eclass/virtualx.eclass index a7f17ec..615ff0e 100644 --- >>>>> a/eclass/virtualx.eclass +++ b/eclass/virtualx.eclass @@ >>>>> -59,6 +59,7 @@ case ${VIRTUALX_REQUIRED} in RDEPEND="" ;; >>>>> optional|tests) + [[ ${EAPI} == [2345] ]] || die 'Values >>>>> "optional" and "tests" are unsupported for >>>>> VIRTUALX_REQUIRED' >>>> >>>> You can now make eutils conditional to EAPI. > > So your idea is only import eutils for EAPIs where I will need > eqawarn >>> from an eclass? As we have no ETA for that to change, I don't >>> see a > good reason to fix that inherit right now. > >> No, only import it for EAPIs in which you actually use it. EAPI 6 >> will die instead, unless you missed some more qa warnings. Good catch. Thanks -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWWc9dXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ0QUU0N0I4NzFERUI0MTJFN0EyODE0NUFF OTQwMkE3OUIwMzUyOUEyAAoJEOlAKnmwNSmi2k4P/ip/shOkEwCXPZlPFeY4qiP1 F8fsBAri7M3xlki9DjAp+LoVFVAxVTvoYn8HFWp84gCOjTHSoLbiVpRiX+jKdbUl dcoSrbGtaaKNT038kLrsRsZQTEzARJR3pw2MZdBb4my38c71Vei8uWwZv1CXM1Pi uch5bGjzAbDHHbBa07vkgxNpm03D1fe9d2K8kdxbsFXfTRs25fODP+6R7fzifarc zCYH2Ritif7FXwLwEc1nwveEVt3TnQyxEdPcN5yHYFpQ6GVRQsfJJDk/QauHh9x+ kUnmLwhrzc8AhLltboo1lZgXH7/8W1OaXbHPYtAuk3zEETuKBBzNFp8nlDvFLtfp 1h9sH9VZCddYy2ckA2BCIRosXyAznzgGS1ub0BQsHyjH+ji++pn4ju4LoJLT7i0v fE07E59ipgA0yq0DbPLp5n/6yhnADj0/C9GaT9FVN+YJYceMejyU3v+Ofn7KRD7n 3p8fU4EUFfU0XqufhwTdKuXpcwg2VJm1eSt5DLs4JpA2yNlpgyZev3n+mo1jFrIM RMK9xlcWbsz4oiRUS+uFCVJ4pK6Xa8lqk3BhvbPTCh1tapWivQ00O9iNyj8Wfoeo jV4KQi8ai+1juT+vYvDU3yr831uux4I70D+qfMci+/pQnzHl8AIRicSygUTCD9sl S1MUVE31Ydqg70FjlDAB =NqmF -----END PGP SIGNATURE-----