From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 4C50F1384B4 for ; Sat, 28 Nov 2015 15:51:15 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id D55A821C0BD; Sat, 28 Nov 2015 15:51:06 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id CE6EFE08EA for ; Sat, 28 Nov 2015 15:51:05 +0000 (UTC) Received: from jmac.jlec.de (ip-88-153-156-92.hsi04.unitymediagroup.de [88.153.156.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: jlec) by smtp.gentoo.org (Postfix) with ESMTPSA id F287433BF0B; Sat, 28 Nov 2015 15:51:03 +0000 (UTC) Subject: Re: [gentoo-dev] [PATCH 8/8] virtualx.eclass: Simplify API into single virtx() To: gentoo-dev@lists.gentoo.org References: <1448717061-11581-1-git-send-email-jlec@gentoo.org> <1448717061-11581-9-git-send-email-jlec@gentoo.org> From: "Justin Lecher (jlec)" Message-ID: <5659CD63.2080000@gentoo.org> Date: Sat, 28 Nov 2015 16:50:59 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Archives-Salt: b805fd6a-29d7-4819-ab12-aea46af56e51 X-Archives-Hash: 70c52bc7334988632734b9a78b939fea -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 28/11/15 16:28, Davide Pesavento wrote: >> else - nonfatal ${VIRTUALX_COMMAND} "$@" + >> nonfatal "$@" > > Please take the opportunity to clean this up, possibly only in > EAPI=6 if you don't want to risk breaking existing ebuilds. See bug > 517976 for details. > >> retval=$? The return value is recorded and gets evaluated correctly. src_test() { virtx false } results in * Scanning for an open DISPLAY to start Xvfb ... debug: virtx: XDISPLAY=1 debug: virtx: /usr/bin/Xvfb :1 -screen 0 1280x1024x24 * Starting Xvfb on $DISPLAY=1 ... debug: virtx: emake "false" * ERROR: app-misc/dummy-1::dummy failed (test phase): * virtx: the emake failed. * * Call stack: * ebuild.sh, line 133: Called src_test * environment, line 2072: Called virtx 'false' * environment, line 2700: Called die * The specific snippet of code: * [[ ${retval} -ne 0 ]] && die "${FUNCNAME}: the ${VIRTUALX_COMMAND} failed."; * Am I missing something? -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWWc1jXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ0QUU0N0I4NzFERUI0MTJFN0EyODE0NUFF OTQwMkE3OUIwMzUyOUEyAAoJEOlAKnmwNSmiWGcQAK6VSEgzlaUaJ+AEC/I+M+Rz uHOmaEE005MsTpUf8GoRY35fnMNkICES9QLZjaSjliBJ6H/WdGDGcqm7rg5yx0j5 v12vv3LMrFX2D/+2SkTurMlGj0gOz+F27ted/p9tmJJLf0KcbusPiJvmjybNjNH+ 5ksLdZEdnAj1p9qmXfoJ8IlKHO82GUn2cNS9O0XFW9WhSzmOaE+WOp2hQtX0HzUE Y6vcVjl5ZD+RDvc2+7oFptOQxGyEZdP43JikAEsfISHnjA4AtYHMLjIHvItaVdoD 8qbG5WAwp0fg1BwqNM6G9neAbknKeGIBLXNBx1QxVj3toz3j3QR88RB1nyovGNp2 7LZjEWYW9/jLpXVTLTg+vwsM6IgvehFdErlXEcWR/q/Gk5Q7C86o3oN4RPaQ93HV ElxL24u/j1CW1mFzXTgKbM4rxlD8G/aROxiKAh5+66ywSrW1SRhpHSYJxriioco3 iwUyZmBtfCB40+DAHl3cX+yxQ/pKMiR7oN67fsx3F8LEalorcONq5w2e1d0bVbgs EqdlUqxZKyI6fUK67+rI6Nd2ZBduUpm9mTvJHovPMQ3gK2hyRiE6FkhLf53aMR4S 9cmq1Bmqqw3KGTlIu45gKP6NxUr/+n1dg2LYpZF72eKKhPkNOO68YogKS073VEWc DJGgOFCpJQIV+BLid0VF =Nh/f -----END PGP SIGNATURE-----