From: "Justin Lecher (jlec)" <jlec@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH 8/8] virtualx.eclass: Simplify API into single virtx()
Date: Sat, 28 Nov 2015 16:50:59 +0100 [thread overview]
Message-ID: <5659CD63.2080000@gentoo.org> (raw)
In-Reply-To: <CADfzvvaP3tQTV7i+hJKSeG_30wcr2khgJWVNXmpxRJr1F-6MSQ@mail.gmail.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
On 28/11/15 16:28, Davide Pesavento wrote:
>> else - nonfatal ${VIRTUALX_COMMAND} "$@" +
>> nonfatal "$@"
>
> Please take the opportunity to clean this up, possibly only in
> EAPI=6 if you don't want to risk breaking existing ebuilds. See bug
> 517976 for details.
>
>> retval=$?
The return value is recorded and gets evaluated correctly.
src_test() {
virtx false
}
results in
* Scanning for an open DISPLAY to start Xvfb ...
debug: virtx: XDISPLAY=1
debug: virtx: /usr/bin/Xvfb :1 -screen 0 1280x1024x24
* Starting Xvfb on $DISPLAY=1 ...
debug: virtx: emake "false"
* ERROR: app-misc/dummy-1::dummy failed (test phase):
* virtx: the emake failed.
*
* Call stack:
* ebuild.sh, line 133: Called src_test
* environment, line 2072: Called virtx 'false'
* environment, line 2700: Called die
* The specific snippet of code:
* [[ ${retval} -ne 0 ]] && die "${FUNCNAME}: the
${VIRTUALX_COMMAND} failed.";
*
Am I missing something?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0
iQJ8BAEBCgBmBQJWWc1jXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ0QUU0N0I4NzFERUI0MTJFN0EyODE0NUFF
OTQwMkE3OUIwMzUyOUEyAAoJEOlAKnmwNSmiWGcQAK6VSEgzlaUaJ+AEC/I+M+Rz
uHOmaEE005MsTpUf8GoRY35fnMNkICES9QLZjaSjliBJ6H/WdGDGcqm7rg5yx0j5
v12vv3LMrFX2D/+2SkTurMlGj0gOz+F27ted/p9tmJJLf0KcbusPiJvmjybNjNH+
5ksLdZEdnAj1p9qmXfoJ8IlKHO82GUn2cNS9O0XFW9WhSzmOaE+WOp2hQtX0HzUE
Y6vcVjl5ZD+RDvc2+7oFptOQxGyEZdP43JikAEsfISHnjA4AtYHMLjIHvItaVdoD
8qbG5WAwp0fg1BwqNM6G9neAbknKeGIBLXNBx1QxVj3toz3j3QR88RB1nyovGNp2
7LZjEWYW9/jLpXVTLTg+vwsM6IgvehFdErlXEcWR/q/Gk5Q7C86o3oN4RPaQ93HV
ElxL24u/j1CW1mFzXTgKbM4rxlD8G/aROxiKAh5+66ywSrW1SRhpHSYJxriioco3
iwUyZmBtfCB40+DAHl3cX+yxQ/pKMiR7oN67fsx3F8LEalorcONq5w2e1d0bVbgs
EqdlUqxZKyI6fUK67+rI6Nd2ZBduUpm9mTvJHovPMQ3gK2hyRiE6FkhLf53aMR4S
9cmq1Bmqqw3KGTlIu45gKP6NxUr/+n1dg2LYpZF72eKKhPkNOO68YogKS073VEWc
DJGgOFCpJQIV+BLid0VF
=Nh/f
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2015-11-28 15:51 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-28 13:24 [gentoo-dev] [PATCH 0/8] virtualx.eclass: New API and EAPI=6 support Justin Lecher
2015-11-28 13:24 ` [gentoo-dev] [PATCH 1/8] virtualx.eclass: Use case/esac to handle supported EAPIs Justin Lecher
2015-11-28 14:46 ` Davide Pesavento
2015-11-28 13:24 ` [gentoo-dev] [PATCH 2/8] virtualx.eclass: Only source eclass once Justin Lecher
2015-11-28 13:24 ` [gentoo-dev] [PATCH 3/8] virtualx.eclass: Use eqawarn instead of ewarn "QA:..." Justin Lecher
2015-11-28 13:24 ` [gentoo-dev] [PATCH 4/8] virtualx.eclass: Ban deprecated functionality in EAPI > 5 Justin Lecher
2015-11-28 14:03 ` Michał Górny
2015-11-28 14:08 ` Justin Lecher (jlec)
2015-11-28 15:57 ` Michał Górny
2015-11-28 15:59 ` Justin Lecher (jlec)
2015-11-28 13:24 ` [gentoo-dev] [PATCH 5/8] virtualx.eclass: Support EAPI=6 Justin Lecher
2015-11-28 13:24 ` [gentoo-dev] [PATCH 6/8] virtualx.eclass: Whitespace cleanup Justin Lecher
2015-11-28 13:24 ` [gentoo-dev] [PATCH 7/8] virtualx.eclass: Add missing die Justin Lecher
2015-11-28 13:24 ` [gentoo-dev] [PATCH 8/8] virtualx.eclass: Simplify API into single virtx() Justin Lecher
2015-11-28 15:28 ` Davide Pesavento
2015-11-28 15:50 ` Justin Lecher (jlec) [this message]
2015-11-30 17:40 ` Davide Pesavento
2015-12-01 7:25 ` Justin Lecher (jlec)
2015-11-28 14:02 ` [gentoo-dev] [PATCH 0/8] virtualx.eclass: New API and EAPI=6 support Michał Górny
2015-11-28 16:20 ` [gentoo-dev] [PATCH 1/8] virtualx.eclass: Use case/esac to handle supported EAPIs Justin Lecher
2015-11-28 16:20 ` [gentoo-dev] [PATCH 2/8] virtualx.eclass: Only source eclass once Justin Lecher
2015-11-28 16:20 ` [gentoo-dev] [PATCH 3/8] virtualx.eclass: Use eqawarn instead of ewarn "QA:..." Justin Lecher
2015-11-28 16:21 ` [gentoo-dev] [PATCH 4/8] virtualx.eclass: Ban deprecated functionality in EAPI > 5 Justin Lecher
2015-11-29 9:57 ` Michał Górny
2015-11-29 12:02 ` Justin Lecher (jlec)
2015-11-29 12:24 ` [gentoo-dev] [PATCH 0/8] virtualx.eclass updates version 3 Justin Lecher
2015-11-29 12:24 ` [gentoo-dev] [PATCH 1/8] virtualx.eclass: Use case/esac to handle supported EAPIs Justin Lecher
2015-11-29 12:24 ` [gentoo-dev] [PATCH 2/8] virtualx.eclass: Only source eclass once Justin Lecher
2015-11-29 12:24 ` [gentoo-dev] [PATCH 3/8] virtualx.eclass: Use eqawarn instead of ewarn "QA:..." Justin Lecher
2015-11-29 12:24 ` [gentoo-dev] [PATCH 4/8] virtualx.eclass: Whitespace cleanup Justin Lecher
2015-11-29 12:24 ` [gentoo-dev] [PATCH 5/8] virtualx.eclass: Add missing die Justin Lecher
2015-11-29 12:24 ` [gentoo-dev] [PATCH 6/8] virtualx.eclass: Simplify API into single virtx() Justin Lecher
2015-11-29 12:24 ` [gentoo-dev] [PATCH 7/8] virtualx.eclass: Ban deprecated functionality in EAPI > 5 Justin Lecher
2015-11-29 13:21 ` Michał Górny
2015-11-29 12:24 ` [gentoo-dev] [PATCH 8/8] virtualx.eclass: Support EAPI=6 Justin Lecher
2015-11-28 16:21 ` [gentoo-dev] [PATCH 5/8] virtualx.eclass: Whitespace cleanup Justin Lecher
2015-11-28 16:21 ` [gentoo-dev] [PATCH 6/8] virtualx.eclass: Add missing die Justin Lecher
2015-11-28 16:21 ` [gentoo-dev] [PATCH 7/8] virtualx.eclass: Simplify API into single virtx() Justin Lecher
2015-11-28 16:21 ` [gentoo-dev] [PATCH 8/8] virtualx.eclass: Support EAPI=6 Justin Lecher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5659CD63.2080000@gentoo.org \
--to=jlec@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox