From: "Justin Lecher (jlec)" <jlec@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: "Michał Górny" <mgorny@gentoo.org>
Subject: Re: [gentoo-dev] [PATCH 10/29] python-utils-r1.eclass: Make heredocs consistent
Date: Mon, 23 Nov 2015 11:55:09 +0100 [thread overview]
Message-ID: <5652F08D.70607@gentoo.org> (raw)
In-Reply-To: <1448221870-17269-11-git-send-email-mgorny@gentoo.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
On 22/11/15 20:50, Micha? Górny wrote:
> --- eclass/python-utils-r1.eclass | 10 +++++----- 1 file changed, 5
> insertions(+), 5 deletions(-)
>
> diff --git a/eclass/python-utils-r1.eclass
> b/eclass/python-utils-r1.eclass index 7617c3f..6fb1ec5 100644 ---
> a/eclass/python-utils-r1.eclass +++
> b/eclass/python-utils-r1.eclass @@ -933,11 +933,11 @@
> python_wrapper_setup() {
>
> local x for x in "${nonsupp[@]}"; do - cat >"${workdir}"/bin/${x}
> <<__EOF__ || die -#!/bin/sh -echo "${x} is not supported by
> ${EPYTHON}" >&2 -exit 127 -__EOF__ + cat >"${workdir}"/bin/${x}
> <<-_EOF_ || die + #!/bin/sh + echo "${x} is not supported by
> ${EPYTHON}" >&2 + exit 127 +_EOF_
Why not indenting this line?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0
iQJ8BAEBCgBmBQJWUvCNXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ0QUU0N0I4NzFERUI0MTJFN0EyODE0NUFF
OTQwMkE3OUIwMzUyOUEyAAoJEOlAKnmwNSmiqWwQAJaI+wQ35CBxT7ZSxLMBtA3x
TtafJinkacJBbSzxgXHnQ/RprAoRO6Utg2ijJh3rYxu8LCD6Al/iF23MtcdzhBWe
oU6KXVzCQI5A+47EFDGifD+GHWkIDwcCepKF+4xKpUGSeN4sxLrENAXt4YysjFPo
QN29+zx4IAsCj/EZmi5ViVCZGA2UdedCkbwbhXUJ5hYXNAS1XPQjFvVCKWp57Ayt
Njj4sVgOJB7kWcZYV6URzv1TFPENSbEI3/H3RpVJAQCnzQLDux0Evy5dNlBG73RU
OnX2mXdZYWibIYgLR6zCtZpiOKcmiIOBlx/PZSgT0ylrHsgzPt7+WY3AEZxtcr+X
9Hii2Qb4WfOXAaVIDSIwUgg44AVSKY5yz+IRmQ6Q7L7u4qmQUMs6JEIb4LJ2oCRH
wbmA/D3exiVEGTzeKI3DQnupkpCeEdtY70R38DmI7Jv6vyLI8mvxw/muTaDh2wF7
7PB3S1HPYsfoje+7GO9g4Bq0xVwssn4XqIvRzwO82nbGHCLA8kPT4q0sevl5iUQY
c+g8X4n34re/wj/uH0j1skkx49VNrZvd0HZ7JzT4XcGK6s673SK8pcJLlYzjInpF
IO4PqBZkRkYPPhyfj8YjbtluquPtQExVBAAQOWF/LlZ9AzHhxkgoxv4lwxFK56/l
NPR5/VPzuJOHWB5pcG2C
=XqEp
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2015-11-23 10:55 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-22 19:50 [gentoo-dev] [PATCHES] Clean-up & EAPI 6 support for python-r1 suite Michał Górny
2015-11-22 19:50 ` [gentoo-dev] [PATCH 01/29] python-utils-r1.eclass: Add missing ||die for external getters Michał Górny
2015-11-22 19:50 ` [gentoo-dev] [PATCH 02/29] python-utils-r1.eclass: Add missing ||die on 'cat' file writes Michał Górny
2015-11-22 19:50 ` [gentoo-dev] [PATCH 03/29] python-utils-r1.eclass: Add missing ||die on file read Michał Górny
2015-11-25 16:16 ` Michał Górny
2015-11-26 22:26 ` Michał Górny
2015-11-22 19:50 ` [gentoo-dev] [PATCH 04/29] python-utils-r1.eclass: Remove py2.6 note from python_optimize Michał Górny
2015-11-22 19:50 ` [gentoo-dev] [PATCH 05/29] python-utils-r1.eclass: Replace local INSDESTTREE with subshells Michał Górny
2015-11-22 19:50 ` [gentoo-dev] [PATCH 06/29] python-utils-r1.eclass: Ban installation helpers in EAPIs < 5 Michał Górny
2015-11-22 19:50 ` [gentoo-dev] [PATCH 07/29] python-utils-r1.eclass: Make python_fix_shebang QAwarns fatal in EAPI 6 Michał Górny
2015-11-22 19:50 ` [gentoo-dev] [PATCH 08/29] python-utils-r1.eclass: Remove unneeded multilib inherit " Michał Górny
2015-11-22 19:50 ` [gentoo-dev] [PATCH 09/29] python-utils-r1.eclass: Support nonfatal in python_do* and python_new* Michał Górny
2015-11-22 19:50 ` [gentoo-dev] [PATCH 10/29] python-utils-r1.eclass: Make heredocs consistent Michał Górny
2015-11-23 10:55 ` Justin Lecher (jlec) [this message]
2015-11-25 12:00 ` [gentoo-dev] [PATCH] " Michał Górny
2015-11-22 19:50 ` [gentoo-dev] [PATCH 11/29] python-utils-r1.eclass: Move ||die out of command substitution subshells Michał Górny
2015-11-22 22:33 ` Davide Pesavento
2015-11-22 23:23 ` Michał Górny
2015-11-22 19:50 ` [gentoo-dev] [PATCH 12/29] python-utils-r1.eclass: Enable EAPI 6 Michał Górny
2015-11-22 19:50 ` [gentoo-dev] [PATCH 13/29] python-any-r1.eclass: Enable EAPI=6, no changes needed Michał Górny
2015-11-22 19:50 ` [gentoo-dev] [PATCH 14/29] python-single-r1.eclass: " Michał Górny
2015-11-22 19:50 ` [gentoo-dev] [PATCH 15/29] multibuild.eclass: Ban multibuild_parallel_foreach_variant in EAPI 6 Michał Górny
2015-11-22 19:50 ` [gentoo-dev] [PATCH 16/29] multibuild.eclass: Enable " Michał Górny
2015-11-22 19:50 ` [gentoo-dev] [PATCH 17/29] python-r1.eclass: Ban python_parallel_foreach_impl in " Michał Górny
2015-11-22 19:50 ` [gentoo-dev] [PATCH 18/29] python-r1.eclass: Ban python_export_best " Michał Górny
2015-11-22 19:51 ` [gentoo-dev] [PATCH 19/29] python-r1.eclass: Fix missing explicit eutils inherit for EAPI < 6 Michał Górny
2015-11-22 19:51 ` [gentoo-dev] [PATCH 20/29] python-r1.eclass: Enable EAPI 6 Michał Górny
2015-11-22 19:51 ` [gentoo-dev] [PATCH 21/29] distutils-r1.eclass: esetup.py, respect nonfatal in " Michał Górny
2015-11-22 19:51 ` [gentoo-dev] [PATCH 22/29] distutils-r1.eclass: Use default_src_prepare to apply patches " Michał Górny
2015-11-22 19:51 ` [gentoo-dev] [PATCH 23/29] distutils-r1.eclass: Ban no-op default phase implementations " Michał Górny
2015-11-22 19:51 ` [gentoo-dev] [PATCH 24/29] distutils-r1.eclass: Make pypy/share QA error fatal " Michał Górny
2015-11-22 19:51 ` [gentoo-dev] [PATCH 25/29] distutils-r1.eclass: Ban EXAMPLES " Michał Górny
2015-11-22 21:14 ` Markus Meier
2015-11-25 12:01 ` [gentoo-dev] [PATCH] " Michał Górny
2015-11-22 19:51 ` [gentoo-dev] [PATCH 26/29] distutils-r1.eclass: Ban DISTUTILS_NO_PARALLEL_BUILD " Michał Górny
2015-11-22 19:51 ` [gentoo-dev] [PATCH 27/29] distutils-r1.eclass: Make default _all impl call warning fatal " Michał Górny
2015-11-22 19:51 ` [gentoo-dev] [PATCH 28/29] distutils-r1.eclass: Remove unnecessary eutils inherit " Michał Górny
2015-11-22 19:51 ` [gentoo-dev] [PATCH 29/29] distutils-r1.eclass: Enable " Michał Górny
2015-11-26 22:30 ` [gentoo-dev] [PATCH 1/2] python-utils-r1.eclass: python_fix_shebang, skip empty files Michał Górny
2015-11-26 22:30 ` [gentoo-dev] [PATCH 2/2] python-utils-r1.eclass: python_fix_shebang, accept symlink as parameter Michał Górny
2015-11-27 5:35 ` [gentoo-dev] [PATCH 1/2] python-utils-r1.eclass: python_fix_shebang, skip empty files Michał Górny
2015-11-27 13:15 ` Michał Górny
2015-11-28 19:10 ` [gentoo-dev] [PATCHES] Clean-up & EAPI 6 support for python-r1 suite Michał Górny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5652F08D.70607@gentoo.org \
--to=jlec@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=mgorny@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox