From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id B5C2F13888F for ; Fri, 9 Oct 2015 15:32:43 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 03E4521C00D; Fri, 9 Oct 2015 15:32:31 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 21AD7E06CC for ; Fri, 9 Oct 2015 15:32:30 +0000 (UTC) Received: from [192.168.0.12] (aftr-37-201-213-217.unity-media.net [37.201.213.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: hasufell) by smtp.gentoo.org (Postfix) with ESMTPSA id 976CD34074F; Fri, 9 Oct 2015 15:32:26 +0000 (UTC) Subject: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/ To: gentoo-dev@lists.gentoo.org, Alexis Ballier References: <1444389412.5220bb29741e1685b42a6312c0b7bf2821672040.aballier@gentoo> From: hasufell Message-ID: <5617DE06.5050200@gentoo.org> Date: Fri, 9 Oct 2015 17:32:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 In-Reply-To: <1444389412.5220bb29741e1685b42a6312c0b7bf2821672040.aballier@gentoo> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Archives-Salt: e50ac68b-931f-401e-9300-eb17d9a281b1 X-Archives-Hash: 632a74b18249b8f0ec082c7c1f94f692 On 10/09/2015 01:17 PM, Alexis Ballier wrote: > commit: 5220bb29741e1685b42a6312c0b7bf2821672040 > Author: Alexis Ballier gentoo org> > AuthorDate: Fri Oct 9 11:16:38 2015 +0000 > Commit: Alexis Ballier gentoo org> > CommitDate: Fri Oct 9 11:16:52 2015 +0000 > URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5220bb29 > > eclass: ros-catkin.eclass: Use cmake-utils_src_make instead of plain emake for src_test so that it works with ninja too. > Please try to use short summary lines and put more detailed description into the commit message after a newline, also see https://wiki.gentoo.org/wiki/Gentoo_git_workflow#Example The prefix is also a bit uncommon, see https://wiki.gentoo.org/wiki/Gentoo_git_workflow#Commit_message_format Ofc, I will expect people to jump in and say "the council hasn't decided on that yet", but well... it mostly works fine and is not really controversial.