[gentoo-dev] [PATCH dtd] herds: Remove no-longer usable <maintainingproject/> element

[gentoo-dev] [PATCH dtd] herds: Remove no-longer usable <maintainingproject/> element

[Michał Górny]

<maintainingproject/> was used to 'copy' herd member lists from project
pages. However, it was never properly supported by tools and it is no
longer usable since project pages were moved to the Wiki.
---
 herds.dtd | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/herds.dtd b/herds.dtd
index 74ea3b5..37ce92a 100644
--- a/herds.dtd
+++ b/herds.dtd
@@ -1,14 +1,10 @@
 <!ELEMENT herds ( (herd)* )>
   <!-- One tag for each herd -->
-  <!ELEMENT herd (name, email? , description?, (maintainersof|maintainingproject|maintainer*))>
+  <!ELEMENT herd (name, email? , description?, (maintainersof|maintainer*))>
 
   <!-- One tag for each maintainer of a herd, multiple allowed-->
   <!ELEMENT maintainer ( email, (role| name)* )>
 
-  <!-- Projects that whose members all maintain the herd, the format is the
-       url of the project page starting from the web root-->
-  <!ELEMENT maintainingproject (#PCDATA)>
-
   <!-- Get the maintainers of another herd and make them maintainers of this
        one-->
   <!ELEMENT maintainersof EMPTY>
-- 
2.5.2

Re: [gentoo-dev] [PATCH dtd] herds: Remove no-longer usable <maintainingproject/> element

[Ulrich Mueller]

[-- Attachment #1: Type: text/plain, Size: 563 bytes --]

>>>>> On Thu, 17 Sep 2015, Michał Górny wrote:

> <maintainingproject/> was used to 'copy' herd member lists from project
> pages. However, it was never properly supported by tools and it is no
> longer usable since project pages were moved to the Wiki.

-1

Let's please first decide on the greater scheme of projects, teams,
and herds. Starting to change files before we have any plan doesn't
make sense.

If we should decide to keep herds (although I think that is unlikely)
then we should fix the functionality instead of removing it.

Ulrich

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: [gentoo-dev] [PATCH dtd] herds: Remove no-longer usable <maintainingproject/> element

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 1420 bytes --]

Dnia 2015-09-17, o godz. 22:10:53
Ulrich Mueller <ulm@gentoo.org> napisał(a):

> >>>>> On Thu, 17 Sep 2015, Michał Górny wrote:
> 
> > <maintainingproject/> was used to 'copy' herd member lists from project
> > pages. However, it was never properly supported by tools and it is no
> > longer usable since project pages were moved to the Wiki.
> 
> -1
> 
> Let's please first decide on the greater scheme of projects, teams,
> and herds. Starting to change files before we have any plan doesn't
> make sense.

We already decided we move projects to Wiki. I don't think we're going
to decide to move them to GuideXML ever again. Keeping an element
dedicated to that doesn't make any sense because it can never work
again.

> If we should decide to keep herds (although I think that is unlikely)
> then we should fix the functionality instead of removing it.

If we even decide (which is quite likely) to go the braindead route of
having a database than tells you pretty much 'use a completely
different API to obtain members', we still would need to introduce
a new element for that.

Reusing <maintainingproject/> with completely different values is so
ugly I can't even properly express it with words. It's just like Python
projects -- we subtly changed API here, your programs will break
randomly now, have fun!

-- 
Best regards,
Michał Górny
<http://dev.gentoo.org/~mgorny/>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 949 bytes --]

Re: [gentoo-dev] [PATCH dtd] herds: Remove no-longer usable <maintainingproject/> element

[Ulrich Mueller]

[-- Attachment #1: Type: text/plain, Size: 686 bytes --]

>>>>> On Thu, 17 Sep 2015, Michał Górny wrote:

>> Let's please first decide on the greater scheme of projects, teams,
>> and herds. Starting to change files before we have any plan doesn't
>> make sense.

> We already decided we move projects to Wiki. I don't think we're
> going to decide to move them to GuideXML ever again. Keeping an
> element dedicated to that doesn't make any sense because it can
> never work again.

Updating herds.xml implies that we are going to keep the concept of
herds, and there is no decision on that yet.

IIUC keeping an obsolete element in the DTD doesn't actually break
anything, so I don't see the urgency of removing it.

Ulrich

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: [gentoo-dev] [PATCH dtd] herds: Remove no-longer usable <maintainingproject/> element

[Daniel Campbell]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 09/18/2015 12:37 AM, Ulrich Mueller wrote:
>>>>>> On Thu, 17 Sep 2015, Michał Górny wrote:
> 
>>> Let's please first decide on the greater scheme of projects,
>>> teams, and herds. Starting to change files before we have any
>>> plan doesn't make sense.
> 
>> We already decided we move projects to Wiki. I don't think we're 
>> going to decide to move them to GuideXML ever again. Keeping an 
>> element dedicated to that doesn't make any sense because it can 
>> never work again.
> 
> Updating herds.xml implies that we are going to keep the concept
> of herds, and there is no decision on that yet.
> 
> IIUC keeping an obsolete element in the DTD doesn't actually break 
> anything, so I don't see the urgency of removing it.
> 
> Ulrich
> 
I agree that we should wait until a more solid decision emerges, but I
disagree over the obsolete element. If it sits around unused, it just
adds cruft to the file (be it a DTD, ebuild, eclass, etc) and could
serve to confuse people reading the source. At the least, a comment
should be added along the lines of, "This element was obsoleted as of
yyyy-mm-dd," so readers (maybe new devs, even) understand that it's
not meant to be used anymore.

Just my 2¢.

- -- 
Daniel Campbell - Gentoo Developer
OpenPGP Key: 0x1EA055D6 @ hkp://keys.gnupg.net
fpr: AE03 9064 AE00 053C 270C  1DE4 6F7A 9091 1EA0 55D6
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJV/c/8AAoJEAEkDpRQOeFw8BoQAKMY/dm5iRZKzJWsDgFx4xw2
US4jyZ6A7W1RYUtPLL+GLBDYjeR+NhxEg/QlQkuEL4PF7lBE5xGQFS2rvOz1Cd+t
sTGkxrU2sdPdybyr1ACE3i9QuoZnrW7TUNYdb5lwcKEYMW4O7sXVuG30O1B1AVit
jRxQFQMLdnzzfi81PheFXny/vaZqkNn4IuK3QGVygrmbMVaYn/eETJ1R7DcgQDFC
C4kXe+QWve2LlMomYd/Ht8GFC3HXwM/zcuvJjzNW5WDNUrlpCNTsMvgg6TIt/ots
lFRUWDzCUcKNb94o8MDBqMrmHSsCp9/ivd185Sidnprs8q+i9V0tL3H75zqSmKrs
suwDSEC/Bmy8xO+MsebLReVZVElzlGP2eozKRzyLWYrDoC34mpFGuitYaOmEWaDx
b03yMtK0v+Kr3CvqUNE6EK89lsArqcdJzsOx251TTFyeSb+4fdHCMNeYuYcZy5yb
z2ddTVwmwD7zUcpIVOaCfhqffVA9GTPnnQqjFlXIhQgune6vIMtH4/UyOftUgx1M
919mPqAjR40L8NTW5KpV39UA39p78UFk4yUnh3fr6OqFmiiEnxSbuNZ99zymeUQ5
BbupaEb7iIIrxLBGVQNVFgRarVOBU9UC0xq5YtkA2ayQpNcRICOY00inQmC9lJLg
xnd0PXYGV7hWpUNKv5LS
=8um3
-----END PGP SIGNATURE-----