From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 14F5E158086 for ; Sat, 18 Dec 2021 21:38:32 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 859D62BC030; Sat, 18 Dec 2021 21:38:24 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 48CE02BC012 for ; Sat, 18 Dec 2021 21:38:22 +0000 (UTC) From: Sam James Message-Id: <55A4C4C9-1A54-4C76-8803-D3B68FE585DB@gentoo.org> Content-Type: multipart/signed; boundary="Apple-Mail=_BCF2E2FF-D227-4A1F-BE44-965D98CA54A0"; protocol="application/pgp-signature"; micalg=pgp-sha512 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.40.0.1.81\)) Subject: Re: [gentoo-dev] [PATCH] flag-o-matic.eclass: filter-lfs-flags: remove -D_TIME_BITS=64 Date: Sat, 18 Dec 2021 21:38:11 +0000 In-Reply-To: <20211218182752.399762-1-floppym@gentoo.org> Cc: toolchain@gentoo.org, Mike Gilbert To: gentoo-dev@lists.gentoo.org References: <20211218182752.399762-1-floppym@gentoo.org> X-Mailer: Apple Mail (2.3693.40.0.1.81) X-Archives-Salt: a9b9a72e-88b1-4651-9eaf-f4d87b5cb484 X-Archives-Hash: d03bcd87de85600d94aa75be90abcd9a --Apple-Mail=_BCF2E2FF-D227-4A1F-BE44-965D98CA54A0 Content-Type: multipart/alternative; boundary="Apple-Mail=_F4A22CA9-B7B5-4518-87A3-F368388C7F7D" --Apple-Mail=_F4A22CA9-B7B5-4518-87A3-F368388C7F7D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On 18 Dec 2021, at 18:27, Mike Gilbert > wrote: >=20 > glibc only allows _TIME_BITS=3D64 when _FILE_OFFSET_BITS=3D64. >=20 > Signed-off-by: Mike Gilbert > > --- > eclass/flag-o-matic.eclass | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/eclass/flag-o-matic.eclass b/eclass/flag-o-matic.eclass > index d262a60b6bb..32119cb9a52 100644 > --- a/eclass/flag-o-matic.eclass > +++ b/eclass/flag-o-matic.eclass > @@ -193,7 +193,8 @@ filter-lfs-flags() { > # _LARGEFILE_SOURCE: enable support for new LFS funcs = (ftello/etc...) > # _LARGEFILE64_SOURCE: enable support for 64bit variants = (off64_t/fseeko64/etc...) > # _FILE_OFFSET_BITS: default to 64bit variants (off_t is defined = as off64_t) > - filter-flags -D_FILE_OFFSET_BITS=3D64 -D_LARGEFILE_SOURCE = -D_LARGEFILE64_SOURCE > + # _TIME_BITS: default to 64bit time_t (requires = _FILE_OFFSET_BITS=3D64) > + filter-flags -D_FILE_OFFSET_BITS=3D64 -D_LARGEFILE_SOURCE = -D_LARGEFILE64_SOURCE -D_TIME_BITS=3D64 > } >=20 > # @FUNCTION: filter-ldflags > -- > 2.34.1 >=20 >=20 LGTM and please go ahead so we can move forward with our planning for = this (see = https://wiki.gentoo.org/wiki/Project:Toolchain/time64_migration = for = others). Best, sam --Apple-Mail=_F4A22CA9-B7B5-4518-87A3-F368388C7F7D Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii

On 18 Dec 2021, at 18:27, Mike Gilbert <floppym@gentoo.org> = wrote:

glibc only allows _TIME_BITS=3D64 when = _FILE_OFFSET_BITS=3D64.

Signed-off-by: Mike = Gilbert <floppym@gentoo.org>
---
= eclass/flag-o-matic.eclass | 3 ++-
1 file changed, 2 = insertions(+), 1 deletion(-)

diff --git = a/eclass/flag-o-matic.eclass b/eclass/flag-o-matic.eclass
index d262a60b6bb..32119cb9a52 100644
--- = a/eclass/flag-o-matic.eclass
+++ = b/eclass/flag-o-matic.eclass
@@ -193,7 +193,8 @@ = filter-lfs-flags() {
# _LARGEFILE_SOURCE: enable = support for new LFS funcs (ftello/etc...)
# = _LARGEFILE64_SOURCE: enable support for 64bit variants = (off64_t/fseeko64/etc...)
# _FILE_OFFSET_BITS: default to = 64bit variants (off_t is defined as off64_t)
- = filter-flags -D_FILE_OFFSET_BITS=3D64 -D_LARGEFILE_SOURCE = -D_LARGEFILE64_SOURCE
+ # _TIME_BITS: default to 64bit = time_t (requires _FILE_OFFSET_BITS=3D64)
+ = filter-flags -D_FILE_OFFSET_BITS=3D64 -D_LARGEFILE_SOURCE = -D_LARGEFILE64_SOURCE -D_TIME_BITS=3D64
}
# @FUNCTION: filter-ldflags
--
2.34.1



LGTM and please go ahead so we can move = forward with our planning for this (see https://wiki.gentoo.org/wiki/Project:Toolchain/time64_migration=  for others).

Best,
sam
= --Apple-Mail=_F4A22CA9-B7B5-4518-87A3-F368388C7F7D-- --Apple-Mail=_BCF2E2FF-D227-4A1F-BE44-965D98CA54A0 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEEYOpPv/uDUzOcqtTy9JIoEO6gSDsFAmG+VMRfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDYw RUE0RkJGRkI4MzUzMzM5Q0FBRDRGMkY0OTIyODEwRUVBMDQ4M0IACgkQ9JIoEO6g SDtynQgAqpLxdkeZxKvoH4eL7Hr/6+h5DRgsZEieqi0kXmQWylLrHjWL0Ulp8O1J ngBxv/+EI06ZFoJNOeDkzxcFI9sSTUK5hGRTvXXkH+MbrXXXhiwSn68tw44Ymysh 1o9oRe1xjJ3zc1S8GyRcsXAK1eVYuCw8YwxQ63ASFD0Zqz/1s84sQiRnv4HtNNdW 1JTqQuWlWIa/Nbjf0FylSWPwwCJ8ApK/yzDUQsMLaVabyv2K+C04yWAcqvmUZiHP 6iOdIDbQLvZHrh/UBJ+tIOdzcu89DIJlvJCsg1zqdJI5eFYWLLUPJlxKysDx5+Du 3TbElUvsbHTe59cZQ/vw+5K/LpgLTw== =O9mc -----END PGP SIGNATURE----- --Apple-Mail=_BCF2E2FF-D227-4A1F-BE44-965D98CA54A0--