From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id E65EA13877A for ; Tue, 19 Aug 2014 06:58:31 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id CFC49E0962; Tue, 19 Aug 2014 06:58:25 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id DC2E5E0954 for ; Tue, 19 Aug 2014 06:58:24 +0000 (UTC) Received: from [91.220.220.251] (pinkbyte.micronet-rostov.ru [91.220.220.251]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: pinkbyte) by smtp.gentoo.org (Postfix) with ESMTPSA id BF4FE3401E6 for ; Tue, 19 Aug 2014 06:58:23 +0000 (UTC) Message-ID: <53F2F58C.3070004@gentoo.org> Date: Tue, 19 Aug 2014 10:58:20 +0400 From: Sergey Popov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] rfc: calling all eclass phase functions by default References: <20140816215428.GA6773@linux1> <53F1BF3C.9060902@gentoo.org> <53F1EBE7.6090700@gentoo.org> <53F1EF49.9030503@gentoo.org> <53F1F1EB.6030601@gentoo.org> <53F1F467.80508@gentoo.org> <53F1F7E5.4000309@gentoo.org> In-Reply-To: <53F1F7E5.4000309@gentoo.org> X-Enigmail-Version: 1.6 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="caxCKFOtPinE0SdgcDRqW73dU7n6oSmLH" X-Archives-Salt: 31373302-abe5-4f98-91b9-36f484b6c8cb X-Archives-Hash: 7baf40fbb5f2276c448824e803639914 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --caxCKFOtPinE0SdgcDRqW73dU7n6oSmLH Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable 18.08.2014 16:56, hasufell =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > hasufell: >> >> Even more interesting... you can work around this by inheriting >> base.eclass explicitly before e.g. unpacker.eclass, something like >> >> inherit base unpacker games >> >> =3D> unpacker_src_unpack() is carried out by default (and the ebuild >> breaks if someone thinks the base.eclass is useless and removes it) >> >> inherit unpacker games >> >> =3D> unpacker_src_unpack is not carried out by default although >> games.eclass does not directly overwrite it >> >> If you think any of this is sensible... >> >=20 > Almost forgot, of course this does not work if you expect > unpacker_src_unpacker() to run: > inherit unpacker games base >=20 > as well as > inherit unpacker base games >=20 > however > inherit games unpacker base >=20 > will work. >=20 > And now... guess why the games herd made it a policy to always inherit > games.eclass last. Because of the unpredictability of eclasses and that= > they may randomly add exported phase functions. It's a bit paranoid, bu= t > understandable, since we don't have any real rules here. >=20 > So in the end 3 eclasses all tell you "inherit me last! really!". Good > luck with figuring out how to make a gnome game with python and multili= b > support work together. I can predict the days such a review would take > in #gentoo-sunrise. Not less than 3. >=20 As i said early - always override necessary functions if you want non-default behaviour. Proposed solution with variable just add syntax sugar, doing the same thing. As for you as sunrise reviewer. I am member of proxy maintainers, i am also reviewing ebuilds from users. And they usually understands inherit logic very well, even in non-trivial cases. So, your expirience just differs with mine, not more, not less. --=20 Best regards, Sergey Popov Gentoo developer Gentoo Desktop Effects project lead Gentoo Proxy maintainers project lead --caxCKFOtPinE0SdgcDRqW73dU7n6oSmLH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJT8vWMAAoJECo/aRed9267AHgH/Rgh/w39l0bRcWalwuGiepJN laLymGJjmu7ePqyuE3y3zSTg6ahG7Lnjv2quFWI7yhwGbPQ+606twZ/Jqnt5fHVE j3uN5Dzdh1ojT3cwcuNsFjaM+xkZBO1A8/5hWQjTj58QTzd5TZrNidqC0vOJ3H4I 9TOUXycRD4FHpIaN4+V2QnJe+Dhij8pv/ymOgJ5faWLcglvmzjKx45PiHnnZket8 nqrvZJLHrAO4MpOxvpdsuiQPk/7NDxPQ5sjpM88Fi5OO8XHaVVEBjeOMb+rVwmsK 6HojSMvyolp9InrprzHBOzycjqe/QdqkW819yec4YbST8TUxYLZOh7H3c6tl8Sw= =on+C -----END PGP SIGNATURE----- --caxCKFOtPinE0SdgcDRqW73dU7n6oSmLH--