* Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/x265: x265-1.0.ebuild ChangeLog x265-1.2.ebuild x265-0.8.ebuild
2014-07-29 0:15 ` Denis Dupeyron
@ 2014-07-29 0:49 ` Alex Xu
2014-07-29 13:33 ` Denis Dupeyron
2014-07-29 2:41 ` Duncan
2014-07-29 17:32 ` Samuli Suominen
2 siblings, 1 reply; 18+ messages in thread
From: Alex Xu @ 2014-07-29 0:49 UTC (permalink / raw
To: gentoo-dev
[-- Attachment #1: Type: text/plain, Size: 522 bytes --]
On 28/07/14 08:15 PM, Denis Dupeyron wrote:
> On Mon, Jul 28, 2014 at 12:41 AM, Samuli Suominen <ssuominen@gentoo.org> wrote:
>> x265-1.2.ebuild: KEYWORDS="~amd64 ~arm ~x86"
>> x265-1.3.ebuild: KEYWORDS="~amd64 ~x86"
>> x265-9999.ebuild: KEYWORDS="~amd64 ~x86"
>>
>> As in... You forgot to add ~arm to -9999.ebuild
>
> Wait, what? Live ebuilds are keyworded now?
>
> Denis.
>
http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/media-libs/x265/x265-9999.ebuild?revision=1.9&view=markup#l9
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/x265: x265-1.0.ebuild ChangeLog x265-1.2.ebuild x265-0.8.ebuild
2014-07-29 0:15 ` Denis Dupeyron
2014-07-29 0:49 ` Alex Xu
@ 2014-07-29 2:41 ` Duncan
2014-07-29 13:58 ` Denis Dupeyron
2014-07-29 17:32 ` Samuli Suominen
2 siblings, 1 reply; 18+ messages in thread
From: Duncan @ 2014-07-29 2:41 UTC (permalink / raw
To: gentoo-dev
Denis Dupeyron posted on Mon, 28 Jul 2014 18:15:20 -0600 as excerpted:
> On Mon, Jul 28, 2014 at 12:41 AM, Samuli Suominen <ssuominen@gentoo.org>
> wrote:
>> x265-1.2.ebuild: KEYWORDS="~amd64 ~arm ~x86"
>> x265-1.3.ebuild: KEYWORDS="~amd64 ~x86"
>> x265-9999.ebuild: KEYWORDS="~amd64 ~x86"
>>
>> As in... You forgot to add ~arm to -9999.ebuild
>
> Wait, what? Live ebuilds are keyworded now?
AFAIK, gentoo policy is that live ebuilds should always be masked so as
never to be automatically pulled in without a deliberate unmasking of the
live ebuild, but whether that's masked due to lack of keywords (ebuild),
or due to hard-mask (package.mask) is I believe up to the maintainer.
For packages like this one where normal version-bumps start with the live
ebuild (which after all should have been updated as development
proceeded, upstream), simply copying it to the appropriate version-number
ebuild, keeping it ~arch-keyworded on all archs where the non-live
version is at least ~arch-keyworded, and using package.mask to force the
masking, makes the most sense since then a version bump can literally
amount to no more than an ebuild copy and manifest (tho obviously the
maintainer will test it too, but ideally won't have to actually touch the
content of the file).
--
Duncan - List replies preferred. No HTML msgs.
"Every nonfree program has a lord, a master --
and if you use the program, he is your master." Richard Stallman
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/x265: x265-1.0.ebuild ChangeLog x265-1.2.ebuild x265-0.8.ebuild
2014-07-29 2:41 ` Duncan
@ 2014-07-29 13:58 ` Denis Dupeyron
2014-07-30 9:38 ` Duncan
0 siblings, 1 reply; 18+ messages in thread
From: Denis Dupeyron @ 2014-07-29 13:58 UTC (permalink / raw
To: gentoo-dev
On Mon, Jul 28, 2014 at 8:41 PM, Duncan <1i5t5.duncan@cox.net> wrote:
> AFAIK, gentoo policy is that live ebuilds should always be masked so as
> never to be automatically pulled in without a deliberate unmasking of the
> live ebuild, but whether that's masked due to lack of keywords (ebuild),
> or due to hard-mask (package.mask) is I believe up to the maintainer.
The policy apparently disappeared in the shuffling of documentation
which occurred over the years. But here is what I was instructed to
teach recruits back when I became a recruiter in 2006 or 2007, and
what competent developers have been doing since even before I was a
developer:
The package.mask file is only for temporary masking, even if more or
less long term. Anything that should be permanently masked has no
place in the tree. Live ebuilds should not be keyworded, reflecting
the fact that the code they're pulling has not be tested for any
architecture due to it being live. Moreover, live ebuilds should not
be masked as this results in unnecessary cruft in the package.mask
file.
Denis.
^ permalink raw reply [flat|nested] 18+ messages in thread
* [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/x265: x265-1.0.ebuild ChangeLog x265-1.2.ebuild x265-0.8.ebuild
2014-07-29 13:58 ` Denis Dupeyron
@ 2014-07-30 9:38 ` Duncan
2014-07-30 11:48 ` Luis Ressel
0 siblings, 1 reply; 18+ messages in thread
From: Duncan @ 2014-07-30 9:38 UTC (permalink / raw
To: gentoo-dev
Denis Dupeyron posted on Tue, 29 Jul 2014 07:58:26 -0600 as excerpted:
> [H]ere is what I was instructed to teach recruits back when I became a
> recruiter in 2006 or 2007, and what competent developers have been doing
> since even before I was a developer:
>
> The package.mask file is only for temporary masking, even if more or
> less long term. Anything that should be permanently masked has no place
> in the tree. Live ebuilds should not be keyworded, reflecting the fact
> that the code they're pulling has not be tested for any architecture due
> to it being live. Moreover, live ebuilds should not be masked as this
> results in unnecessary cruft in the package.mask file.
Thanks. That makes sense, tho it does conflict with "content-touchless"
bumps from the live ebuild.
In the context of that policy and a content-touchless-bump goal, I
suppose I'd script the bump, pulling keywords from the highest previous
version, prepending the ~ as necessary and inserting them in the keywords
line after copying the file from the live-ebuild . That wouldn't be
content-touchless, but the touch would be automated so as to avoid
mistakes and unnecessary work.
--
Duncan - List replies preferred. No HTML msgs.
"Every nonfree program has a lord, a master --
and if you use the program, he is your master." Richard Stallman
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/x265: x265-1.0.ebuild ChangeLog x265-1.2.ebuild x265-0.8.ebuild
2014-07-30 9:38 ` Duncan
@ 2014-07-30 11:48 ` Luis Ressel
2014-07-30 12:33 ` Samuli Suominen
2014-08-13 7:04 ` Tom Wijsman
0 siblings, 2 replies; 18+ messages in thread
From: Luis Ressel @ 2014-07-30 11:48 UTC (permalink / raw
To: gentoo-dev
[-- Attachment #1: Type: text/plain, Size: 763 bytes --]
On Wed, 30 Jul 2014 09:38:16 +0000 (UTC)
Duncan <1i5t5.duncan@cox.net> wrote:
> In the context of that policy and a content-touchless-bump goal, I
> suppose I'd script the bump, pulling keywords from the highest
> previous version, prepending the ~ as necessary and inserting them in
> the keywords line after copying the file from the live-ebuild . That
> wouldn't be content-touchless, but the touch would be automated so as
> to avoid mistakes and unnecessary work.
That proposed script reminds me of http://xkcd.com/1319/. ;)
I think I'd rather go with the original workflow. Okay, perhaps
package.masking -9999 is a bit uncommon and clutters package.mask, but
it's not all *that* bad and it eases the workflow.
Regards,
Luis Ressel
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 949 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/x265: x265-1.0.ebuild ChangeLog x265-1.2.ebuild x265-0.8.ebuild
2014-07-30 11:48 ` Luis Ressel
@ 2014-07-30 12:33 ` Samuli Suominen
2014-07-30 15:14 ` Luis Ressel
2014-07-30 17:29 ` Michael Haubenwallner
2014-08-13 7:04 ` Tom Wijsman
1 sibling, 2 replies; 18+ messages in thread
From: Samuli Suominen @ 2014-07-30 12:33 UTC (permalink / raw
To: gentoo-dev
On 30/07/14 14:48, Luis Ressel wrote:
> On Wed, 30 Jul 2014 09:38:16 +0000 (UTC)
> Duncan <1i5t5.duncan@cox.net> wrote:
>
>> In the context of that policy and a content-touchless-bump goal, I
>> suppose I'd script the bump, pulling keywords from the highest
>> previous version, prepending the ~ as necessary and inserting them in
>> the keywords line after copying the file from the live-ebuild . That
>> wouldn't be content-touchless, but the touch would be automated so as
>> to avoid mistakes and unnecessary work.
> That proposed script reminds me of http://xkcd.com/1319/. ;)
>
> I think I'd rather go with the original workflow. Okay, perhaps
> package.masking -9999 is a bit uncommon and clutters package.mask, but
> it's not all *that* bad and it eases the workflow.
>
>
> Regards,
> Luis Ressel
There is no need to package.mask if proper if -logic is used, like, for
example,
if [[ ${PV} == 9999* ]]; then
inherit git-r3
KEYWORDS=""
else
KEYWORDS="~amd64 ~arm ~arm64 ~x86"
fi
Then you can just `cp foo-9999.ebuild foo-1.2.3.ebuild` and it'll have
the KEYWORDS
ready, and 1.2.3 and 9999 ebuilds can be identical
That's what this thread was originally about... That's how x265's ebuild
work, just like eg.
media-libs/xine-lib or sys-fs/udev ebuilds does
(It just seemed this was unclear to some replying in this thread.)
- Samuli
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/x265: x265-1.0.ebuild ChangeLog x265-1.2.ebuild x265-0.8.ebuild
2014-07-30 12:33 ` Samuli Suominen
@ 2014-07-30 15:14 ` Luis Ressel
2014-07-30 17:29 ` Michael Haubenwallner
1 sibling, 0 replies; 18+ messages in thread
From: Luis Ressel @ 2014-07-30 15:14 UTC (permalink / raw
To: gentoo-dev
[-- Attachment #1: Type: text/plain, Size: 793 bytes --]
On Wed, 30 Jul 2014 15:33:19 +0300
Samuli Suominen <ssuominen@gentoo.org> wrote:
> There is no need to package.mask if proper if -logic is used, like,
> for example,
>
> if [[ ${PV} == 9999* ]]; then
> inherit git-r3
> KEYWORDS=""
> else
> KEYWORDS="~amd64 ~arm ~arm64 ~x86"
> fi
>
> Then you can just `cp foo-9999.ebuild foo-1.2.3.ebuild` and it'll have
> the KEYWORDS
> ready, and 1.2.3 and 9999 ebuilds can be identical
>
> That's what this thread was originally about... That's how x265's
> ebuild work, just like eg.
> media-libs/xine-lib or sys-fs/udev ebuilds does
>
> (It just seemed this was unclear to some replying in this thread.)
>
> - Samuli
>
>
Thanks for the clarification. This approach seems to be the optimum.
Regards,
Luis Ressel
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 949 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/x265: x265-1.0.ebuild ChangeLog x265-1.2.ebuild x265-0.8.ebuild
2014-07-30 12:33 ` Samuli Suominen
2014-07-30 15:14 ` Luis Ressel
@ 2014-07-30 17:29 ` Michael Haubenwallner
2014-07-30 17:33 ` Samuli Suominen
2014-07-30 20:15 ` William Hubbs
1 sibling, 2 replies; 18+ messages in thread
From: Michael Haubenwallner @ 2014-07-30 17:29 UTC (permalink / raw
To: gentoo-dev
Am 2014-07-30 14:33, schrieb Samuli Suominen:
>
> There is no need to package.mask if proper if -logic is used, like, for
> example,
>
> if [[ ${PV} == 9999* ]]; then
> inherit git-r3
> KEYWORDS=""
> else
> KEYWORDS="~amd64 ~arm ~arm64 ~x86"
> fi
>
> Then you can just `cp foo-9999.ebuild foo-1.2.3.ebuild` and it'll have
> the KEYWORDS
> ready, and 1.2.3 and 9999 ebuilds can be identical
Which instance of the KEYWORDS line is touched by the ekeyword tool these days?
To have ekeyword touch the else-part in the release ebuild, what about this:
if [[ ${PV} == 9999* ]]; then
inherit vcs...
:; KEYWORDS=""
else
KEYWORDS="..."
fi
/haubi/
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/x265: x265-1.0.ebuild ChangeLog x265-1.2.ebuild x265-0.8.ebuild
2014-07-30 17:29 ` Michael Haubenwallner
@ 2014-07-30 17:33 ` Samuli Suominen
2014-07-31 7:19 ` Michael Haubenwallner
2014-07-30 20:15 ` William Hubbs
1 sibling, 1 reply; 18+ messages in thread
From: Samuli Suominen @ 2014-07-30 17:33 UTC (permalink / raw
To: gentoo-dev
On 30/07/14 20:29, Michael Haubenwallner wrote:
> Am 2014-07-30 14:33, schrieb Samuli Suominen:
>> There is no need to package.mask if proper if -logic is used, like, for
>> example,
>>
>> if [[ ${PV} == 9999* ]]; then
>> inherit git-r3
>> KEYWORDS=""
>> else
>> KEYWORDS="~amd64 ~arm ~arm64 ~x86"
>> fi
>>
>> Then you can just `cp foo-9999.ebuild foo-1.2.3.ebuild` and it'll have
>> the KEYWORDS
>> ready, and 1.2.3 and 9999 ebuilds can be identical
> Which instance of the KEYWORDS line is touched by the ekeyword tool these days?
>
> To have ekeyword touch the else-part in the release ebuild, what about this:
>
> if [[ ${PV} == 9999* ]]; then
> inherit vcs...
> :; KEYWORDS=""
> else
> KEYWORDS="..."
> fi
>
> /haubi/
>
You are propably looking for this,
http://bugs.gentoo.org/show_bug.cgi?id=321475
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/x265: x265-1.0.ebuild ChangeLog x265-1.2.ebuild x265-0.8.ebuild
2014-07-30 17:33 ` Samuli Suominen
@ 2014-07-31 7:19 ` Michael Haubenwallner
0 siblings, 0 replies; 18+ messages in thread
From: Michael Haubenwallner @ 2014-07-31 7:19 UTC (permalink / raw
To: gentoo-dev
Am 2014-07-30 19:33, schrieb Samuli Suominen:
>
> On 30/07/14 20:29, Michael Haubenwallner wrote:
>> Am 2014-07-30 14:33, schrieb Samuli Suominen:
>>> There is no need to package.mask if proper if -logic is used, like, for
>>> example,
>>>
>>> if [[ ${PV} == 9999* ]]; then
>>> inherit git-r3
>>> KEYWORDS=""
>>> else
>>> KEYWORDS="~amd64 ~arm ~arm64 ~x86"
>>> fi
>>>
>>> Then you can just `cp foo-9999.ebuild foo-1.2.3.ebuild` and it'll have
>>> the KEYWORDS
>>> ready, and 1.2.3 and 9999 ebuilds can be identical
>> Which instance of the KEYWORDS line is touched by the ekeyword tool these days?
>>
>> To have ekeyword touch the else-part in the release ebuild, what about this:
>>
>> if [[ ${PV} == 9999* ]]; then
>> inherit vcs...
>> :; KEYWORDS=""
>> else
>> KEYWORDS="..."
>> fi
>>
>> /haubi/
>>
>
> You are propably looking for this,
> http://bugs.gentoo.org/show_bug.cgi?id=321475
>
Indeed, thanks!
/haubi/
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/x265: x265-1.0.ebuild ChangeLog x265-1.2.ebuild x265-0.8.ebuild
2014-07-30 17:29 ` Michael Haubenwallner
2014-07-30 17:33 ` Samuli Suominen
@ 2014-07-30 20:15 ` William Hubbs
1 sibling, 0 replies; 18+ messages in thread
From: William Hubbs @ 2014-07-30 20:15 UTC (permalink / raw
To: gentoo-dev
[-- Attachment #1: Type: text/plain, Size: 964 bytes --]
On Wed, Jul 30, 2014 at 07:29:22PM +0200, Michael Haubenwallner wrote:
>
> Am 2014-07-30 14:33, schrieb Samuli Suominen:
> >
> > There is no need to package.mask if proper if -logic is used, like, for
> > example,
> >
> > if [[ ${PV} == 9999* ]]; then
> > inherit git-r3
> > KEYWORDS=""
> > else
> > KEYWORDS="~amd64 ~arm ~arm64 ~x86"
> > fi
> >
> > Then you can just `cp foo-9999.ebuild foo-1.2.3.ebuild` and it'll have
> > the KEYWORDS
> > ready, and 1.2.3 and 9999 ebuilds can be identical
>
> Which instance of the KEYWORDS line is touched by the ekeyword tool these days?
>
> To have ekeyword touch the else-part in the release ebuild, what about this:
>
> if [[ ${PV} == 9999* ]]; then
> inherit vcs...
> :; KEYWORDS=""
> else
> KEYWORDS="..."
> fi
Actually you can even go further since KEYWORDS is an optional variable:
if [[ ${PV} == 9999* ]]; then
inherit vcs...
else
KEYWORDS="..."
fi
William
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/x265: x265-1.0.ebuild ChangeLog x265-1.2.ebuild x265-0.8.ebuild
2014-07-30 11:48 ` Luis Ressel
2014-07-30 12:33 ` Samuli Suominen
@ 2014-08-13 7:04 ` Tom Wijsman
1 sibling, 0 replies; 18+ messages in thread
From: Tom Wijsman @ 2014-08-13 7:04 UTC (permalink / raw
To: gentoo-dev; +Cc: aranea
[-- Attachment #1: Type: text/plain, Size: 766 bytes --]
On Wed, 30 Jul 2014 13:48:37 +0200
Luis Ressel <aranea@aixah.de> wrote:
> I think I'd rather go with the original workflow. Okay, perhaps
> package.masking -9999 is a bit uncommon and clutters package.mask, but
> it's not all *that* bad and it eases the workflow.
Depends on whose workflow you are referring to; it doesn't affect the
maintainer, but the clutter can be a pain if you attempt to keep the
p.mask size low. Having package.mask as a directory would be a solution
to this; however, there's not much other need for it to be a directory.
--
With kind regards,
Tom Wijsman (TomWij)
Gentoo Developer
E-mail address : TomWij@gentoo.org
GPG Public Key : 6D34E57D
GPG Fingerprint : C165 AF18 AB4C 400B C3D2 ABF0 95B2 1FCD 6D34 E57D
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/x265: x265-1.0.ebuild ChangeLog x265-1.2.ebuild x265-0.8.ebuild
2014-07-29 0:15 ` Denis Dupeyron
2014-07-29 0:49 ` Alex Xu
2014-07-29 2:41 ` Duncan
@ 2014-07-29 17:32 ` Samuli Suominen
2 siblings, 0 replies; 18+ messages in thread
From: Samuli Suominen @ 2014-07-29 17:32 UTC (permalink / raw
To: gentoo-dev
On 29/07/14 03:15, Denis Dupeyron wrote:
> On Mon, Jul 28, 2014 at 12:41 AM, Samuli Suominen <ssuominen@gentoo.org> wrote:
>> x265-1.2.ebuild: KEYWORDS="~amd64 ~arm ~x86"
>> x265-1.3.ebuild: KEYWORDS="~amd64 ~x86"
>> x265-9999.ebuild: KEYWORDS="~amd64 ~x86"
>>
>> As in... You forgot to add ~arm to -9999.ebuild
> Wait, what? Live ebuilds are keyworded now?
>
> Denis.
>
I should have propably only mailed this to maekke, but CC'd the mailing
list because this
has been a trend lately, people outright ignore *9999 ebuilds and the
preparations
done there for the upcoming releases when they commit non-maintainer
bumps like,
well, I don't want to give examples as that'd be "pointing fingers"
Just that some people think it's better to have poorly done version bump
to get latest,
than live with *correct* older version, and thiskind of thinking really
needs to die...
There is nothing wrong with old, long as it works
- Samuli
^ permalink raw reply [flat|nested] 18+ messages in thread