From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 45BCF158094 for ; Sun, 9 Oct 2022 21:30:57 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id AF611E08FC; Sun, 9 Oct 2022 21:30:54 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 72FA2E0839 for ; Sun, 9 Oct 2022 21:30:54 +0000 (UTC) Content-Type: multipart/signed; boundary="Apple-Mail=_C8EF0418-037E-475A-876E-5F9500602498"; protocol="application/pgp-signature"; micalg=pgp-sha512 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: [gentoo-dev] [PATCH 0/3] toolchain-funcs.eclass: support for querying C++ stdlib and compiler runtime From: Sam James In-Reply-To: <20221008094329.316318-1-mgorny@gentoo.org> Date: Sun, 9 Oct 2022 22:30:49 +0100 Cc: =?utf-8?B?TWljaGHFgiBHw7Nybnk=?= , Gentoo Toolchain Message-Id: <53ACFD03-1B49-4E5E-81E3-D65CA84AE705@gentoo.org> References: <20221008094329.316318-1-mgorny@gentoo.org> To: gentoo-dev@lists.gentoo.org X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Archives-Salt: 89dc31c0-28ab-439e-979f-50033198997d X-Archives-Hash: c9c1d494bec8b3a5a4e03d35639d8bb4 --Apple-Mail=_C8EF0418-037E-475A-876E-5F9500602498 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 8 Oct 2022, at 10:43, Micha=C5=82 G=C3=B3rny = wrote: >=20 > Hi, >=20 > Here's a patchset adding two new functions along with tests: >=20 > - tc-get-cxx-stdlib() that determines C++ stdlib used (libc++ vs > libstdc++) > - tc-get-c-rtlib() that determines C compiler runtime used (libgcc vs > compiler-rt) >=20 > I've also included a fix for tests failing if ld.gold is not = installed. >=20 All LGTM, although you forgot to CC toolchain@ ;) >=20 > Micha=C5=82 G=C3=B3rny (3): > toolchain-funcs.eclass: Add tc-get-cxx-stdlib() to get C++ stdlib > toolchain-funcs.eclass: Add tc-get-c-rtlib() to get CC runtime > eclass/tests/toolchain-funcs.sh: Handle missing ld.gold gracefully Best, sam --Apple-Mail=_C8EF0418-037E-475A-876E-5F9500602498 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iNUEARYKAH0WIQQlpruI3Zt2TGtVQcJzhAn1IN+RkAUCY0M9iV8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0MjVB NkJCODhERDlCNzY0QzZCNTU0MUMyNzM4NDA5RjUyMERGOTE5MAAKCRBzhAn1IN+R kA/YAP9Y8UfU5ozwdBF/y5/BwsA4oD/dpJiVM/e9JC2hGKtngQD/W548C2h1tuVE 0szViSEPUPRax4ASNYXvZ3+euvsUEA4= =96Z6 -----END PGP SIGNATURE----- --Apple-Mail=_C8EF0418-037E-475A-876E-5F9500602498--