From: Sam James <sam@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: "Michał Górny" <mgorny@gentoo.org>,
"Gentoo Toolchain" <toolchain@gentoo.org>
Subject: Re: [gentoo-dev] [PATCH 0/3] toolchain-funcs.eclass: support for querying C++ stdlib and compiler runtime
Date: Sun, 9 Oct 2022 22:30:49 +0100 [thread overview]
Message-ID: <53ACFD03-1B49-4E5E-81E3-D65CA84AE705@gentoo.org> (raw)
In-Reply-To: <20221008094329.316318-1-mgorny@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 719 bytes --]
> On 8 Oct 2022, at 10:43, Michał Górny <mgorny@gentoo.org> wrote:
>
> Hi,
>
> Here's a patchset adding two new functions along with tests:
>
> - tc-get-cxx-stdlib() that determines C++ stdlib used (libc++ vs
> libstdc++)
> - tc-get-c-rtlib() that determines C compiler runtime used (libgcc vs
> compiler-rt)
>
> I've also included a fix for tests failing if ld.gold is not installed.
>
All LGTM, although you forgot to CC toolchain@ ;)
>
> Michał Górny (3):
> toolchain-funcs.eclass: Add tc-get-cxx-stdlib() to get C++ stdlib
> toolchain-funcs.eclass: Add tc-get-c-rtlib() to get CC runtime
> eclass/tests/toolchain-funcs.sh: Handle missing ld.gold gracefully
Best,
sam
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 358 bytes --]
prev parent reply other threads:[~2022-10-09 21:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-08 9:43 [gentoo-dev] [PATCH 0/3] toolchain-funcs.eclass: support for querying C++ stdlib and compiler runtime Michał Górny
2022-10-08 9:43 ` [gentoo-dev] [PATCH 1/3] toolchain-funcs.eclass: Add tc-get-cxx-stdlib() to get C++ stdlib Michał Górny
2022-10-08 9:43 ` [gentoo-dev] [PATCH 2/3] toolchain-funcs.eclass: Add tc-get-c-rtlib() to get CC runtime Michał Górny
2022-10-08 9:43 ` [gentoo-dev] [PATCH 3/3] eclass/tests/toolchain-funcs.sh: Handle missing ld.gold gracefully Michał Górny
2022-10-09 21:30 ` Sam James [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53ACFD03-1B49-4E5E-81E3-D65CA84AE705@gentoo.org \
--to=sam@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=mgorny@gentoo.org \
--cc=toolchain@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox