From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 4F7EF13877A for ; Sun, 22 Jun 2014 17:12:34 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 38163E09DA; Sun, 22 Jun 2014 17:12:29 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 4F971E09CE for ; Sun, 22 Jun 2014 17:12:28 +0000 (UTC) Received: from [192.168.1.100] (mobile-internet-bcee10-70.dhcp.inet.fi [188.238.16.70]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: ssuominen) by smtp.gentoo.org (Postfix) with ESMTPSA id AE6C133FC9C; Sun, 22 Jun 2014 17:12:25 +0000 (UTC) Message-ID: <53A70D99.1040503@gentoo.org> Date: Sun, 22 Jun 2014 20:08:41 +0300 From: Samuli Suominen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org, voyageur@gentoo.org Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in x11-plugins/wmfishtime/files: wmfishtime-1.24-gtk.patch References: <20140622162511.10F352004F@flycatcher.gentoo.org> In-Reply-To: <20140622162511.10F352004F@flycatcher.gentoo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Archives-Salt: a8470ac8-4449-4636-9bec-ff56af8d3940 X-Archives-Hash: 3e42b8c28e405f336e4cd9b6a5b93888 On 22/06/14 19:25, Bernard Cafarelli (voyageur) wrote: > voyageur 14/06/22 16:25:10 > > Modified: wmfishtime-1.24-gtk.patch > Log: > Link with libm, spotted by patrick in bug #513908 > > (Portage version: 2.2.10/cvs/Linux x86_64, signed Manifest commit with key C74525F2) > > Revision Changes Path > 1.3 x11-plugins/wmfishtime/files/wmfishtime-1.24-gtk.patch > > file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/x11-plugins/wmfishtime/files/wmfishtime-1.24-gtk.patch?rev=1.3&view=markup > plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/x11-plugins/wmfishtime/files/wmfishtime-1.24-gtk.patch?rev=1.3&content-type=text/plain > diff : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/x11-plugins/wmfishtime/files/wmfishtime-1.24-gtk.patch?r1=1.2&r2=1.3 > > Index: wmfishtime-1.24-gtk.patch > =================================================================== > RCS file: /var/cvsroot/gentoo-x86/x11-plugins/wmfishtime/files/wmfishtime-1.24-gtk.patch,v > retrieving revision 1.2 > retrieving revision 1.3 > diff -u -r1.2 -r1.3 > --- wmfishtime-1.24-gtk.patch 6 Jun 2011 20:04:49 -0000 1.2 > +++ wmfishtime-1.24-gtk.patch 22 Jun 2014 16:25:10 -0000 1.3 > @@ -48,7 +48,7 @@ > SHELL = sh > OBJS = fishmon.o > -LIBS = `gtk-config --libs | sed "s/-lgtk//g"` > -+LIBS = `pkg-config gtk+-2.0 --libs` -lX11 > ++LIBS = `pkg-config gtk+-2.0 --libs` -lm -lX11 > INSTALL = -m 755 > > all: wmfishtime > > > > > gtk+-2.0 --libs` -lm -lX11 This is wrong, it should be: PKG_CONFIG ?= pkg-config LIBS = `$(PKG_CONFIG) gtk+-2.0 --libs` -lm -X11 And ebuild should have `export PKG_CONFIG="$(tc-getPKG_CONFIG)"` As in, PKG_CONFIG needs to be respected from the environment, it's almost never O.K. to hardcode pkg-config I realize you didn't touch that part of the patch right now, but imho, these should get fixed whereever spotted. Thanks, Samuli