[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-db/mysql: mysql-5.1.73-r1.ebuild ChangeLog mysql-5.1.73.ebuild

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-db/mysql: mysql-5.1.73-r1.ebuild ChangeLog mysql-5.1.73.ebuild

[Justin (jlec)]

[-- Attachment #1: Type: text/plain, Size: 848 bytes --]

On 14/05/14 03:47, Brian Evans (grknight) wrote:

Hi Brian,

> EAPI="4"

please always try to bump to latest EAPI when ever you add a new
revision or version to the tree,


> # Most of these are in the eclass
> DEPEND="|| ( >=sys-devel/gcc-3.4.6 >=sys-devel/gcc-apple-4.0 )
> 		>=sys-devel/libtool-2.2.10"

As you wrote correctly in your quizzes, depending is not enough. You
also need to test to those compilers.

> src_prepare() {
> 	sed -i \
> 		-e '/^noinst_PROGRAMS/s/basic-t//g' \
> 		"${S}"/unittest/mytap/t/Makefile.am

missing die for external tools.

> 	emake check || die "make check failed"

no die needed for emake in higher EAPIs.

> 		cd "${S}"

same here

> 		# create directories because mysqladmin might make out of order
> 		mkdir -p "${S}"/mysql-test/var-{ps,ns}{,/log}

here



Justin


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 1031 bytes --]

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-db/mysql: mysql-5.1.73-r1.ebuild ChangeLog mysql-5.1.73.ebuild

[Justin (jlec)]

[-- Attachment #1: Type: text/plain, Size: 1033 bytes --]

On 14/05/14 08:56, Justin (jlec) wrote:
> On 14/05/14 03:47, Brian Evans (grknight) wrote:
> 
> Hi Brian,
> 
>> EAPI="4"
> 
> please always try to bump to latest EAPI when ever you add a new
> revision or version to the tree,
> 
> 
>> # Most of these are in the eclass
>> DEPEND="|| ( >=sys-devel/gcc-3.4.6 >=sys-devel/gcc-apple-4.0 )
>> 		>=sys-devel/libtool-2.2.10"
> 
> As you wrote correctly in your quizzes, depending is not enough. You
> also need to test to those compilers.
> 
>> src_prepare() {
>> 	sed -i \
>> 		-e '/^noinst_PROGRAMS/s/basic-t//g' \
>> 		"${S}"/unittest/mytap/t/Makefile.am
> 
> missing die for external tools.
> 
>> 	emake check || die "make check failed"
> 
> no die needed for emake in higher EAPIs.
> 
>> 		cd "${S}"
> 
> same here
> 
>> 		# create directories because mysqladmin might make out of order
>> 		mkdir -p "${S}"/mysql-test/var-{ps,ns}{,/log}
> 
> here
> 
> 
> 
> Justin
> 

Please everyone forget this. This wasn't meant for public.

Justin


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 1031 bytes --]