[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/libsdl2/files: libsdl2-2.0.3-static-libs.patch

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/libsdl2/files: libsdl2-2.0.3-static-libs.patch

[Samuli Suominen]

On 12/05/14 18:56, Julian Ospald (hasufell) wrote:
> hasufell    14/05/12 15:56:05
>
>   Added:                libsdl2-2.0.3-static-libs.patch
>   Log:
>   version bump
>   
>   (Portage version: 2.2.10/cvs/Linux x86_64, signed Manifest commit with key BDEED020)
>
> Revision  Changes    Path
> 1.1                  media-libs/libsdl2/files/libsdl2-2.0.3-static-libs.patch
>
> file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-libs/libsdl2/files/libsdl2-2.0.3-static-libs.patch?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-libs/libsdl2/files/libsdl2-2.0.3-static-libs.patch?rev=1.1&content-type=text/plain
>
> Index: libsdl2-2.0.3-static-libs.patch
> ===================================================================
> --- SDL2-2.0.2.orig/Makefile.in
> +++ SDL2-2.0.2/Makefile.in
> @@ -33,10 +33,10 @@
>  OBJECTS = @OBJECTS@
>  VERSION_OBJECTS = @VERSION_OBJECTS@
>  
> -SDLMAIN_TARGET = libSDL2main.a
> +SDLMAIN_TARGET = libSDL2main.la
>  SDLMAIN_OBJECTS = @SDLMAIN_OBJECTS@
>  
> -SDLTEST_TARGET = libSDL2_test.a
> +SDLTEST_TARGET = libSDL2_test.la
>  SDLTEST_OBJECTS = @SDLTEST_OBJECTS@
>  
>  SRC_DIST = *.txt acinclude Android.mk autogen.sh android-project build-scripts cmake configure configure.in debian include Makefile.* sdl2-config.in sdl2.m4 sdl2.pc.in SDL2.spec.in src test VisualC.html VisualC Xcode Xcode-iOS
> @@ -123,15 +123,13 @@
>  .PHONY: all update-revision install install-bin install-hdrs install-lib install-data uninstall uninstall-bin uninstall-hdrs uninstall-lib uninstall-data clean distclean dist $(OBJECTS:.lo=.d)
>  
>  $(objects)/$(TARGET): $(OBJECTS) $(VERSION_OBJECTS)
> -	$(LIBTOOL) --mode=link $(CC) -o $@ $(OBJECTS) $(VERSION_OBJECTS) $(LDFLAGS) $(EXTRA_LDFLAGS) $(LT_LDFLAGS)
> +	$(LIBTOOL) --mode=link $(CC) $(CFLAGS) -o $@ $^ $(LDFLAGS) $(EXTRA_LDFLAGS) $(LT_LDFLAGS)

You know that adding $(LDFLAGS) so late in the linker line makes whole
-Wl,--as-needed get ignored? Should almost certainly be $(CC) $(LDFLAGS)
$(CFLAGS) ...

- Samuli

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/libsdl2/files: libsdl2-2.0.3-static-libs.patch

[Tom Wijsman]

[-- Attachment #1: Type: text/plain, Size: 1211 bytes --]

On Mon, 12 May 2014 18:59:33 +0300
Samuli Suominen <ssuominen@gentoo.org> wrote:

> > -	$(LIBTOOL) --mode=link $(CC) -o $@ $(OBJECTS)
> > $(VERSION_OBJECTS) $(LDFLAGS) $(EXTRA_LDFLAGS) $(LT_LDFLAGS)
> > +	$(LIBTOOL) --mode=link $(CC) $(CFLAGS) -o $@ $^ $(LDFLAGS)
> > $(EXTRA_LDFLAGS) $(LT_LDFLAGS)
> 
> You know that adding $(LDFLAGS) so late in the linker line makes whole
> -Wl,--as-needed get ignored? Should almost certainly be $(CC)
> $(LDFLAGS) $(CFLAGS) ...

If someone wants an detailed explanation, see for reference:

    https://wiki.gentoo.org/wiki/Project:Quality_Assurance/As-needed#Importance_of_linking_order

If someone wants emerge to bail out when it is wrong, see for reference:

    https://wiki.gentoo.org/wiki/Project:Quality_Assurance/As-needed#Forced_--as-needed

    IMPORTANT: There is a particular bug with these instructions:

        https://bugs.gentoo.org/show_bug.cgi?id=509966 

    A temporary solution is to remove the last GCC_SPECS="" line.

-- 
With kind regards,

Tom Wijsman (TomWij)
Gentoo Developer

E-mail address  : TomWij@gentoo.org
GPG Public Key  : 6D34E57D
GPG Fingerprint : C165 AF18 AB4C 400B C3D2  ABF0 95B2 1FCD 6D34 E57D

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/libsdl2/files: libsdl2-2.0.3-static-libs.patch

[hasufell]

Samuli Suominen:
> You know that adding $(LDFLAGS) so late in the linker line makes whole
> -Wl,--as-needed get ignored?
> 

Yes I know and the patch is correct as is.