From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (unknown [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 9B40D1381FA for ; Mon, 12 May 2014 16:00:46 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 70EB1E0B2B; Mon, 12 May 2014 16:00:42 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 729C7E0ACE for ; Mon, 12 May 2014 16:00:41 +0000 (UTC) Received: from [10.174.127.233] (unknown [85.76.55.58]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: ssuominen) by smtp.gentoo.org (Postfix) with ESMTPSA id A21EA33ECA5; Mon, 12 May 2014 16:00:38 +0000 (UTC) Message-ID: <5370EFE5.5030901@gentoo.org> Date: Mon, 12 May 2014 18:59:33 +0300 From: Samuli Suominen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org, hasufell@gentoo.org Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/libsdl2/files: libsdl2-2.0.3-static-libs.patch References: <20140512155605.8FFBB2004C@flycatcher.gentoo.org> In-Reply-To: <20140512155605.8FFBB2004C@flycatcher.gentoo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Archives-Salt: 07aef067-c6e4-4bac-aff3-5b07a9ebb4c6 X-Archives-Hash: 8e1a31b8c14b4c63bd9c3f6c6915cb8d On 12/05/14 18:56, Julian Ospald (hasufell) wrote: > hasufell 14/05/12 15:56:05 > > Added: libsdl2-2.0.3-static-libs.patch > Log: > version bump > > (Portage version: 2.2.10/cvs/Linux x86_64, signed Manifest commit with key BDEED020) > > Revision Changes Path > 1.1 media-libs/libsdl2/files/libsdl2-2.0.3-static-libs.patch > > file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-libs/libsdl2/files/libsdl2-2.0.3-static-libs.patch?rev=1.1&view=markup > plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-libs/libsdl2/files/libsdl2-2.0.3-static-libs.patch?rev=1.1&content-type=text/plain > > Index: libsdl2-2.0.3-static-libs.patch > =================================================================== > --- SDL2-2.0.2.orig/Makefile.in > +++ SDL2-2.0.2/Makefile.in > @@ -33,10 +33,10 @@ > OBJECTS = @OBJECTS@ > VERSION_OBJECTS = @VERSION_OBJECTS@ > > -SDLMAIN_TARGET = libSDL2main.a > +SDLMAIN_TARGET = libSDL2main.la > SDLMAIN_OBJECTS = @SDLMAIN_OBJECTS@ > > -SDLTEST_TARGET = libSDL2_test.a > +SDLTEST_TARGET = libSDL2_test.la > SDLTEST_OBJECTS = @SDLTEST_OBJECTS@ > > SRC_DIST = *.txt acinclude Android.mk autogen.sh android-project build-scripts cmake configure configure.in debian include Makefile.* sdl2-config.in sdl2.m4 sdl2.pc.in SDL2.spec.in src test VisualC.html VisualC Xcode Xcode-iOS > @@ -123,15 +123,13 @@ > .PHONY: all update-revision install install-bin install-hdrs install-lib install-data uninstall uninstall-bin uninstall-hdrs uninstall-lib uninstall-data clean distclean dist $(OBJECTS:.lo=.d) > > $(objects)/$(TARGET): $(OBJECTS) $(VERSION_OBJECTS) > - $(LIBTOOL) --mode=link $(CC) -o $@ $(OBJECTS) $(VERSION_OBJECTS) $(LDFLAGS) $(EXTRA_LDFLAGS) $(LT_LDFLAGS) > + $(LIBTOOL) --mode=link $(CC) $(CFLAGS) -o $@ $^ $(LDFLAGS) $(EXTRA_LDFLAGS) $(LT_LDFLAGS) You know that adding $(LDFLAGS) so late in the linker line makes whole -Wl,--as-needed get ignored? Should almost certainly be $(CC) $(LDFLAGS) $(CFLAGS) ... - Samuli