public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-dev] [PATCH] waf-utils.eclass: respect CFLAGS in linking command
@ 2014-04-06 15:45 hasufell
  2014-04-06 23:12 ` [gentoo-dev] " Ryan Hill
  0 siblings, 1 reply; 2+ messages in thread
From: hasufell @ 2014-04-06 15:45 UTC (permalink / raw
  To: gentoo-dev; +Cc: gnome

respect CFLAGS in linking command
https://bugs.gentoo.org/show_bug.cgi?id=506956

--- eclass/waf-utils.eclass
+++ eclass/waf-utils.eclass
@@ -56,18 +56,18 @@
 	[[ -z ${NO_WAF_LIBDIR} ]] && libdir="--libdir=${EPREFIX}/usr/$(get_libdir)"
 
 	tc-export AR CC CPP CXX RANLIB
-	echo "CCFLAGS=\"${CFLAGS}\" LINKFLAGS=\"${LDFLAGS}\" \"${WAF_BINARY}\" --prefix=${EPREFIX}/usr ${libdir} $@ configure"
+	echo "CCFLAGS=\"${CFLAGS}\" LINKFLAGS=\"${CFLAGS} ${LDFLAGS}\" \"${WAF_BINARY}\" --prefix=${EPREFIX}/usr ${libdir} $@ configure"
 
 	# This condition is required because waf takes even whitespace as function
 	# calls, awesome isn't it?
 	if [[ -z ${NO_WAF_LIBDIR} ]]; then
-		CCFLAGS="${CFLAGS}" LINKFLAGS="${LDFLAGS}" "${WAF_BINARY}" \
+		CCFLAGS="${CFLAGS}" LINKFLAGS="${CFLAGS} ${LDFLAGS}" "${WAF_BINARY}" \
 			"--prefix=${EPREFIX}/usr" \
 			"${libdir}" \
 			"$@" \
 			configure || die "configure failed"
 	else
-		CCFLAGS="${CFLAGS}" LINKFLAGS="${LDFLAGS}" "${WAF_BINARY}" \
+		CCFLAGS="${CFLAGS}" LINKFLAGS="${CFLAGS} ${LDFLAGS}" "${WAF_BINARY}" \
 			"--prefix=${EPREFIX}/usr" \
 			"$@" \
 			configure || die "configure failed"


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [gentoo-dev] Re: [PATCH] waf-utils.eclass: respect CFLAGS in linking command
  2014-04-06 15:45 [gentoo-dev] [PATCH] waf-utils.eclass: respect CFLAGS in linking command hasufell
@ 2014-04-06 23:12 ` Ryan Hill
  0 siblings, 0 replies; 2+ messages in thread
From: Ryan Hill @ 2014-04-06 23:12 UTC (permalink / raw
  To: gentoo-dev

[-- Attachment #1: Type: text/plain, Size: 1457 bytes --]

On Sun, 06 Apr 2014 15:45:34 +0000
hasufell <hasufell@gentoo.org> wrote:

> respect CFLAGS in linking command
> https://bugs.gentoo.org/show_bug.cgi?id=506956
> 
> --- eclass/waf-utils.eclass
> +++ eclass/waf-utils.eclass
> @@ -56,18 +56,18 @@
>  	[[ -z ${NO_WAF_LIBDIR} ]] &&
> libdir="--libdir=${EPREFIX}/usr/$(get_libdir)" 
>  	tc-export AR CC CPP CXX RANLIB
> -	echo "CCFLAGS=\"${CFLAGS}\" LINKFLAGS=\"${LDFLAGS}\"
> \"${WAF_BINARY}\" --prefix=${EPREFIX}/usr ${libdir} $@ configure"
> +	echo "CCFLAGS=\"${CFLAGS}\" LINKFLAGS=\"${CFLAGS} ${LDFLAGS}\"
> \"${WAF_BINARY}\" --prefix=${EPREFIX}/usr ${libdir} $@ configure" 
>  	# This condition is required because waf takes even whitespace as
> function # calls, awesome isn't it?
>  	if [[ -z ${NO_WAF_LIBDIR} ]]; then
> -		CCFLAGS="${CFLAGS}" LINKFLAGS="${LDFLAGS}" "${WAF_BINARY}" \
> +		CCFLAGS="${CFLAGS}" LINKFLAGS="${CFLAGS} ${LDFLAGS}"
> "${WAF_BINARY}" \ "--prefix=${EPREFIX}/usr" \
>  			"${libdir}" \
>  			"$@" \
>  			configure || die "configure failed"
>  	else
> -		CCFLAGS="${CFLAGS}" LINKFLAGS="${LDFLAGS}" "${WAF_BINARY}" \
> +		CCFLAGS="${CFLAGS}" LINKFLAGS="${CFLAGS} ${LDFLAGS}"
> "${WAF_BINARY}" \ "--prefix=${EPREFIX}/usr" \
>  			"$@" \
>  			configure || die "configure failed"

Good.


-- 
Ryan Hill                        psn: dirtyepic_sk
   gcc-porting/toolchain/wxwidgets @ gentoo.org

47C3 6D62 4864 0E49 8E9E  7F92 ED38 BD49 957A 8463

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-04-06 23:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-06 15:45 [gentoo-dev] [PATCH] waf-utils.eclass: respect CFLAGS in linking command hasufell
2014-04-06 23:12 ` [gentoo-dev] " Ryan Hill

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox