public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH] .github: Add pull request template
Date: Wed, 01 May 2024 16:59:21 +0200	[thread overview]
Message-ID: <52fbe839f3a5d03aa2583ed1021c97604dcb6b8b.camel@gentoo.org> (raw)
In-Reply-To: <1b6164f5-a64f-4ce9-a48c-47bf7168d209@gentoo.org>

[-- Attachment #1: Type: text/plain, Size: 939 bytes --]

On Wed, 2024-05-01 at 16:27 +0200, Maciej Barć wrote:
> Maybe we could consider also adding something along the lines (4 
> additional positions):
> 
> 1. I have emerged the package(s) on a Gentoo-based system (be it 
> "native" or virtualized by means of hardware-based virtualization or 
> system layer virtualization).
> 2. I have tested that the package(s) merge inside both the user and net 
> sandbox without violations on a Gentoo-based system.
> 3. I can assure that the packages would be able to be merged on the 
> currently default Gentoo profile (with or without modifications to USE 
> flags).
> 4. If manual intervention (beyond "emerge PKG") is required ro complete 
> the install/update of the package(s) I have explained the steps needed 
> to be taken in the PR and/or package ebuild(s) and/or Gentoo Wiki.
> 

Asking people to check 8 checkboxes is a bit much.

-- 
Best regards,
Michał Górny


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 512 bytes --]

  parent reply	other threads:[~2024-05-01 14:59 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-01 13:32 [gentoo-dev] [PATCH] .github: Add pull request template Michał Górny
2024-05-01 14:27 ` Maciej Barć
2024-05-01 14:47   ` Eli Schwartz
2024-05-01 15:02     ` Maciej Barć
2024-05-01 15:15       ` Eli Schwartz
2024-05-01 15:18         ` Maciej Barć
2024-05-01 14:59   ` Michał Górny [this message]
2024-05-01 15:14     ` Maciej Barć
2024-05-01 14:28 ` Ionen Wolkens
2024-05-01 14:38   ` Maciej Barć
2024-05-01 14:54     ` Eli Schwartz
2024-05-01 15:01     ` Ulrich Mueller
2024-05-01 15:05       ` Maciej Barć
2024-05-01 15:52         ` Ulrich Mueller
2024-05-01 16:00           ` Maciej Barć
2024-05-01 15:00   ` Michał Górny
2024-05-03  4:41   ` Sam James
2024-05-03  4:41 ` Sam James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52fbe839f3a5d03aa2583ed1021c97604dcb6b8b.camel@gentoo.org \
    --to=mgorny@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox