[gentoo-dev] [PATCH] mysql-cmake.eclass respect flags wrt #497532

[gentoo-dev] [PATCH] mysql-cmake.eclass respect flags wrt #497532

[hasufell]

[-- Attachment #1: Type: text/plain, Size: 649 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

https://bugs.gentoo.org/show_bug.cgi?id=497532
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJS/in3AAoJEFpvPKfnPDWzEMIH/2SKfnSBDkl5k5ReodLf4iGF
tx7kGjKgmgAbpkJLxsbL+4oZrwo7mbbU8tb0tghuk6JJDzuMqUD19ynSw2fB6WyU
QBRkht3v7knN6M0AB447B9ca5skgV6Ylr8yJvS1EDJluwr76WzlO7mxHFy1APcGC
ZMcVJfn0/DyiNIW8NtgMU7VLvxoIG2uZoJ7fHJPAImyLajNdfIwsKsN9qt4WpMmX
WR16Xw3WpVryPwIQsXRUw5yLo80rxOuTB09s9ZFk5f/tBU2H5eU5HLRuKWmkS32B
R6+UH3ooc/pJkA5yg6KCgrUODHvFVdAuw29QHIZzBXqWMylb4EVPgSK5II77M9o=
=qoS7
-----END PGP SIGNATURE-----

[-- Attachment #2: mysql-cmake.eclass.patch --]
[-- Type: text/x-patch, Size: 386 bytes --]

--- eclass/mysql-cmake.eclass
+++ eclass/mysql-cmake.eclass
@@ -239,6 +239,8 @@
 	CMAKE_BUILD_TYPE="RelWithDebInfo"
 
 	mycmakeargs=(
+		-DCMAKE_C_FLAGS_RELWITHDEBINFO="$(usex debug "" "-DNDEBUG")"
+		-DCMAKE_CXX_FLAGS_RELWITHDEBINFO="$(usex debug "" "-DNDEBUG")"
 		-DCMAKE_INSTALL_PREFIX=${EPREFIX}/usr
 		-DMYSQL_DATADIR=${EPREFIX}/var/lib/mysql
 		-DSYSCONFDIR=${EPREFIX}/etc/mysql

[gentoo-dev] Re: [PATCH] mysql-cmake.eclass respect flags wrt #497532

[Michael Palimaka]

On 02/15/2014 01:36 AM, hasufell wrote:
> https://bugs.gentoo.org/show_bug.cgi?id=497532
> 

Is there a good reason to set CMAKE_BUILD_TYPE="RelWithDebInfo" at all?
Changing the build type is not generally recommended, and may cause
other flags to be set automatically.

If you are using the default build type, adding "debug" to IUSE will
cause cmake-utils to automagically handle it.

Re: [gentoo-dev] Re: [PATCH] mysql-cmake.eclass respect flags wrt #497532

[hasufell]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 02/14/2014 04:06 PM, Michael Palimaka wrote:
> On 02/15/2014 01:36 AM, hasufell wrote:
>> https://bugs.gentoo.org/show_bug.cgi?id=497532
>> 
> 
> Is there a good reason to set CMAKE_BUILD_TYPE="RelWithDebInfo" at
> all? Changing the build type is not generally recommended, and may
> cause other flags to be set automatically.
> 

I have no idea. File a bug for the eclass if you like, I am not the
author.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJS/jQhAAoJEFpvPKfnPDWzHq8H/0Wp9Gz8b6rAB5MUdYuG8wB2
JjQaqrnWCvUSl002jBZZEtGd0JcGaAfuoq3UxmFDjx4xHbESZL0PPiR3VLa8z/sX
Z/2tgG/IyWsxA8Go0A7pJ0qKX7XG5TAJYh10JU7uc35hv9jHaou6Grd1zaFu0To+
J5hkFQyJF+vnR3SAAPyDvM269sHENZu7dSBPo5rTYxdTxR5wnjLfVPu0rADR9k0S
KkLeePwsPbSN7pZg8vW46NUMsPJ+oUWfKDPp/TYxIxOx3AT15Q/AcdmUlyRGkwXE
QCBo/gsU0NJzXSJbpzRNVZYpSjL+jZUuDaT36lOh87zqCCHMBi6kLnRGQx7KR+c=
=QIUy
-----END PGP SIGNATURE-----