From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id D5EE3138727 for ; Sat, 25 Jan 2014 10:13:21 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 743C1E09B8; Sat, 25 Jan 2014 10:13:13 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 82C2BE08FC for ; Sat, 25 Jan 2014 10:13:12 +0000 (UTC) Received: from [192.168.1.2] (unknown [2.221.35.40]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: hwoarang) by smtp.gentoo.org (Postfix) with ESMTPSA id 779E533E94D for ; Sat, 25 Jan 2014 10:13:11 +0000 (UTC) Message-ID: <52E38E0A.70107@gentoo.org> Date: Sat, 25 Jan 2014 10:12:26 +0000 From: Markos Chandras User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH] eutils.eclass: add optfeature() function References: <52E14249.8000502@gentoo.org> <20140123172828.217c261d@pomiot.lan> <52E144F6.7010308@gentoo.org> <20140123174824.5036e5c8@pomiot.lan> In-Reply-To: <20140123174824.5036e5c8@pomiot.lan> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Archives-Salt: d13656e4-46f6-43c1-a717-619da33ade84 X-Archives-Hash: 910d26f6736a1d4d2bf3521cbffa72df On 01/23/2014 04:48 PM, Michał Górny wrote: > Dnia 2014-01-23, o godz. 11:36:06 > Chris Reffett napisał(a): > >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> On 01/23/2014 11:28 AM, Michał Górny wrote: >>> Dnia 2014-01-23, o godz. 11:24:41 Chris Reffett >>> napisał(a): >>> >>>> After some discussion on good ways to communicate optional >>>> dependencies to users, I was shown the optfeature() function in >>>> net-misc/netctl. Gentoo contributor Andrew Hamilton and I came up >>>> with a cleaned up and expanded version of it, and I would like to >>>> add it to eutils.eclass to provide a standard way of notifying >>>> users of optional dependencies. The patch to eutils.eclass is >>>> attached. >>> >>> This was discussed already: >>> >>> http://thread.gmane.org/gmane.linux.gentoo.devel/72162 >>> >> First of all, this is a short patch for a function, not a full eclass. > > Ah, sorry, this changes *a lot*. Let's start the bikeshed again then, > whatever. > I haven't looked at the implementation, but I wonder if we need a function for such trivial stuff. Most maintainers deal with this problem using pkg_postinst() einfo/elog messages. Why do we need a dedicated function for that? Just for consistency reasons...? -- Regards, Markos Chandras