From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id B5F431381F3 for ; Thu, 18 Jul 2013 22:11:14 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id DC157E0B89; Thu, 18 Jul 2013 22:11:03 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 1769EE0ADC for ; Thu, 18 Jul 2013 22:11:03 +0000 (UTC) Received: from [192.168.26.5] (ip98-164-195-43.oc.oc.cox.net [98.164.195.43]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: zmedico) by smtp.gentoo.org (Postfix) with ESMTPSA id CFBE333E5FC; Thu, 18 Jul 2013 22:11:01 +0000 (UTC) Message-ID: <51E867F4.9090109@gentoo.org> Date: Thu, 18 Jul 2013 15:11:00 -0700 From: Zac Medico User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org CC: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= , zerochaos@gentoo.org Subject: Re: [gentoo-dev] cmake-utils.eclass and bug 475502 References: <51E7051C.1070401@gentoo.org> <51E709F5.8020802@gentoo.org> <51E70C8B.9050808@gentoo.org> <51E70DEC.3060506@gentoo.org> <51E70FC8.90704@gentoo.org> <20130718090641.2956d27c@gentoo.org> In-Reply-To: <20130718090641.2956d27c@gentoo.org> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Archives-Salt: 9d983ebb-203f-4f15-9d13-4024450e1399 X-Archives-Hash: c684cbb9482305e658ff0e040c621d48 On 07/18/2013 12:06 AM, Michał Górny wrote: > Dnia 2013-07-17, o godz. 17:42:32 > "Rick \"Zero_Chaos\" Farina" napisał(a): > >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 > >> On 07/17/2013 05:34 PM, hasufell wrote: >>> On 07/17/2013 11:28 PM, Rick "Zero_Chaos" Farina wrote: >>>> ...and that is why it isn't permitted to directly use an eclass >>>> that you don't inherit. While I agree testing could (should) have >>>> been better, the fact that people ignore the rules for writing >>>> ebuilds shouldn't entirely fall on the KDE team. >>> >>> >>> It doesn't matter in the slightest whos fault it is or who should be >>> blamed. >>> >>> It is about maintaining stability for the user. Especially when it >>> comes to stable ebuilds. >>> >>> That means the methods for eclass changes must be more thoroughly. > >> I completely agree with you, the changes should have been tested better. >> The ebuilds with these errors popping up ALSO should have been tested >> better. Considering this is a QA violation, perhaps it is possible to >> add a check in repoman for using something from an eclass which you >> didn't inherit. I doubt the slowdown would be horrible and clearly it >> would catch a huge number of QA violations. > > Repoman has such check already. It pops up for specific functions > listed in repoman source code. This allows us to catch the common > mistakes while avoiding false positives. > > Maybe it should always pop up for phase functions. I don't immediately > see a reason why an ebuild would use a phase function of an eclass it > doesn't inherit directly. That check is only enabled in portage-2.2, because I really want it to parse the relevant info directly from the eclasses. That way, we won't have to update repoman for eclass changes. -- Thanks, Zac