Re: [gentoo-dev] Re: RFC: fortran-2.eclass - Support for bin package system without compiler

[Justin <jlec@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 2840 bytes --]

On 18/07/13 10:25, Duncan wrote:
> Justin posted on Thu, 18 Jul 2013 09:28:49 +0200 as excerpted:
> 
>> + case ${EAPI:-0} in
>> +     0|1|2|3)
>> +         eqawarn "The fortran-2.eclass is going to deprecate support
> 
>                                           ^^^^^^^^^^^
> 
> That reads strange to me.  Deprecated doesn't mean it no longer works; it 
> means it's declared obsolete and recommended against but it still works 
> for now, thus giving users a time to migrate.[1]
> 
> So "is going to deprecate" seems strange.  It should be "has deprecated", 
> or rewording a bit more "support is deprecated for" or the like.  Because 
> by the time someone's actually reading that output, the warning is 
> already there; the deprecation has already happened.
> 
> Alternatively, keep the future tense and say "will be removed" or some 
> such, or use a hybrid, "support is deprecated and will be removed".
> 
> ---
> 
> [1] deprecate/deprecation online references:
> http://en.wiktionary.org/wiki/deprecate
> https://en.wikipedia.org/wiki/Deprecation
> http://www.thefreedictionary.com/deprecate
> http://www.google.com/search?q=define:deprecate
> 
As long as there are only wording problems...



Index: fortran-2.eclass
===================================================================
RCS file: /var/cvsroot/gentoo-x86/eclass/fortran-2.eclass,v
retrieving revision 1.18
diff -u -B -b -u -p -r1.18 fortran-2.eclass
--- fortran-2.eclass  18 Jul 2013 07:03:33 -0000  1.18
+++ fortran-2.eclass  18 Jul 2013 08:42:56 -0000
@@ -203,11 +203,11 @@ _fortran_test_function() {
   fi
 }

-# @FUNCTION: fortran-2_pkg_setup
+# @FUNCTION: _fortran-2_pkg_setup
+# @INTERNAL
 # @DESCRIPTION:
-# Setup functionallity,
-# checks for a valid fortran compiler and optionally for its openmp
support.
-fortran-2_pkg_setup() {
+# _The_ fortran-2_pkg_setup()
+_fortran-2_pkg_setup() {
   for _f_use in ${FORTRAN_NEEDED}; do
       case ${_f_use} in
           always)
@@ -229,6 +229,27 @@ fortran-2_pkg_setup() {
   done
 }

+
+# @FUNCTION: fortran-2_pkg_setup
+# @DESCRIPTION:
+# Setup functionallity,
+# checks for a valid fortran compiler and optionally for its openmp
support.
+fortran-2_pkg_setup() {
+ case ${EAPI:-0} in
+     0|1|2|3)
+         eqawarn "Support for EAPI < 4 will be removed from the"
+         eqawarn "fortran-2.eclass in near future."
+         eqawarn "Please migrate your package to a higher EAPI"
+         eqawarn "or file a bug at https://bugs.gentoo.org"
+         _fortran-2_pkg_setup ;;
+     4|5)
+         if [[ ${MERGE_TYPE} != binary ]]; then
+             _fortran-2_pkg_setup
+         fi
+         ;;
+ esac
+}
+
 case ${EAPI:-0} in
   0|1|2|3|4|5) EXPORT_FUNCTIONS pkg_setup ;;
   *) die "EAPI=${EAPI} is not supported" ;;



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]