From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 1D55B1381F3 for ; Wed, 17 Jul 2013 21:47:58 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 2F76DE0963; Wed, 17 Jul 2013 21:47:50 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 6124EE085B for ; Wed, 17 Jul 2013 21:47:49 +0000 (UTC) Received: from [192.168.4.5] (blfd-5d8233c4.pool.mediaWays.net [93.130.51.196]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: hasufell) by smtp.gentoo.org (Postfix) with ESMTPSA id EA66633DAD3 for ; Wed, 17 Jul 2013 21:47:47 +0000 (UTC) Message-ID: <51E71102.6040103@gentoo.org> Date: Wed, 17 Jul 2013 23:47:46 +0200 From: hasufell User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130630 Thunderbird/17.0.7 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] cmake-utils.eclass and bug 475502 References: <51E7051C.1070401@gentoo.org> <51E709F5.8020802@gentoo.org> <51E70C8B.9050808@gentoo.org> <51E70DEC.3060506@gentoo.org> <51E70FC8.90704@gentoo.org> In-Reply-To: <51E70FC8.90704@gentoo.org> X-Enigmail-Version: 1.6a1pre Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Archives-Salt: 8f14054e-0d8f-4973-8c27-4925da10ab34 X-Archives-Hash: 18bc9dbe8836241b30ca23a65cab3136 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 07/17/2013 11:42 PM, Rick "Zero_Chaos" Farina wrote: > On 07/17/2013 05:34 PM, hasufell wrote: >> On 07/17/2013 11:28 PM, Rick "Zero_Chaos" Farina wrote: >>> On 07/17/2013 05:17 PM, Chris Reffett wrote: >>>> On 07/17/2013 04:57 PM, hasufell wrote: >>>>> I know there was an announcement about the upcoming change >>>>> to cmake-utils.eclass, however... it is not enough to give >>>>> a deadline without caring if people actually fixed it by >>>>> then. > >>>>> By doing that you risk breaking stable packages which is >>>>> not trivial. > >>>>> You _must_ do a tinderbox run, test that stuff in an >>>>> overlay or whatever. You are responsible for ALL reverse >>>>> deps. > >>>>> The way it was done... was not appropriate. Please be more >>>>> careful next time. There are still incoming bugs about >>>>> broken base_src_* calls. (see the tracker) > > >>>> I discussed this with hasufell on IRC, but I'll lay out the >>>> response on the list too. Yes, this was my fault. We (KDE >>>> team) tested in our overlay, but none of the packages there >>>> use the base_src_* calls, which is why it didn't come up in >>>> testing, and I did not realize that there were packages that >>>> did rely on the implicit base inherit to call base_src_* >>>> directly. > >>> ...and that is why it isn't permitted to directly use an >>> eclass that you don't inherit. While I agree testing could >>> (should) have been better, the fact that people ignore the >>> rules for writing ebuilds shouldn't entirely fall on the KDE >>> team. > > > Considering this is a QA violation, perhaps it is possible to add a > check in repoman for using something from an eclass which you > didn't inherit. I doubt the slowdown would be horrible and clearly > it would catch a huge number of QA violations. > That will yield false positives. Some eclases are explicitly designed in a way that you do NOT need to directly inherit it's helpers such as python-r1 and python-utils-r1. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJR5xECAAoJEFpvPKfnPDWzzRQH/RbkJCvLvpvdLHnb6grJWf3K hiKYl2ee5ziqPgx2rLY6HY6L2QN2XuKJ2nmUluvi8s7OIqnKvcH7l3HSJzK5d+2C 48FNmacLvOJPVpN3cw5h1uH3Jcff0lFXtcYaPBDNlMoYdbY+b3ad+AbXpTHR9rBX UkM7W8ung1cH30oed8HZreK4a+6G+8MsqJbZlHJhnAstyWWklIUrpgvKo2kiorfl fPvtWhz05hxRUji/Nv3rf4gln9o2MPj0/pa9KZNTKqvBZtX/3SRWVCWvMH6xqXDw zQa4pYwkYdbiFS3WW6p08D9I3vMQ/gJ0ZY51OVTVLAVYBrWqd5WA4r4CT7x9QTI= =2B+w -----END PGP SIGNATURE-----