Re: [gentoo-dev] cmake-utils.eclass and bug 475502

[hasufell <hasufell@gentoo.org>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/17/2013 11:42 PM, Rick "Zero_Chaos" Farina wrote:
> On 07/17/2013 05:34 PM, hasufell wrote:
>> On 07/17/2013 11:28 PM, Rick "Zero_Chaos" Farina wrote:
>>> On 07/17/2013 05:17 PM, Chris Reffett wrote:
>>>> On 07/17/2013 04:57 PM, hasufell wrote:
>>>>> I know there was an announcement about the upcoming change
>>>>> to cmake-utils.eclass, however... it is not enough to give
>>>>> a deadline without caring if people actually fixed it by
>>>>> then.
> 
>>>>> By doing that you risk breaking stable packages which is
>>>>> not trivial.
> 
>>>>> You _must_ do a tinderbox run, test that stuff in an
>>>>> overlay or whatever. You are responsible for ALL reverse
>>>>> deps.
> 
>>>>> The way it was done... was not appropriate. Please be more 
>>>>> careful next time. There are still incoming bugs about
>>>>> broken base_src_* calls. (see the tracker)
> 
> 
>>>> I discussed this with hasufell on IRC, but I'll lay out the 
>>>> response on the list too. Yes, this was my fault. We (KDE
>>>> team) tested in our overlay, but none of the packages there
>>>> use the base_src_* calls, which is why it didn't come up in
>>>> testing, and I did not realize that there were packages that
>>>> did rely on the implicit base inherit to call base_src_*
>>>> directly.
> 
>>> ...and that is why it isn't permitted to directly use an
>>> eclass that you don't inherit.  While I agree testing could
>>> (should) have been better, the fact that people ignore the
>>> rules for writing ebuilds shouldn't entirely fall on the KDE
>>> team.
> 
> 
> Considering this is a QA violation, perhaps it is possible to add a
> check in repoman for using something from an eclass which you 
> didn't inherit.  I doubt the slowdown would be horrible and clearly
> it would catch a huge number of QA violations.
> 

That will yield false positives. Some eclases are explicitly designed
in a way that you do NOT need to directly inherit it's helpers such as
python-r1 and python-utils-r1.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJR5xECAAoJEFpvPKfnPDWzzRQH/RbkJCvLvpvdLHnb6grJWf3K
hiKYl2ee5ziqPgx2rLY6HY6L2QN2XuKJ2nmUluvi8s7OIqnKvcH7l3HSJzK5d+2C
48FNmacLvOJPVpN3cw5h1uH3Jcff0lFXtcYaPBDNlMoYdbY+b3ad+AbXpTHR9rBX
UkM7W8ung1cH30oed8HZreK4a+6G+8MsqJbZlHJhnAstyWWklIUrpgvKo2kiorfl
fPvtWhz05hxRUji/Nv3rf4gln9o2MPj0/pa9KZNTKqvBZtX/3SRWVCWvMH6xqXDw
zQa4pYwkYdbiFS3WW6p08D9I3vMQ/gJ0ZY51OVTVLAVYBrWqd5WA4r4CT7x9QTI=
=2B+w
-----END PGP SIGNATURE-----