Re: [gentoo-dev] cmake-utils.eclass and bug 475502

[hasufell <hasufell@gentoo.org>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/17/2013 11:28 PM, Rick "Zero_Chaos" Farina wrote:
> On 07/17/2013 05:17 PM, Chris Reffett wrote:
>> On 07/17/2013 04:57 PM, hasufell wrote:
>>> I know there was an announcement about the upcoming change to 
>>> cmake-utils.eclass, however... it is not enough to give a
>>> deadline without caring if people actually fixed it by then.
> 
>>> By doing that you risk breaking stable packages which is not 
>>> trivial.
> 
>>> You _must_ do a tinderbox run, test that stuff in an overlay or
>>>  whatever. You are responsible for ALL reverse deps.
> 
>>> The way it was done... was not appropriate. Please be more
>>> careful next time. There are still incoming bugs about broken
>>> base_src_* calls. (see the tracker)
> 
> 
>> I discussed this with hasufell on IRC, but I'll lay out the
>> response on the list too. Yes, this was my fault. We (KDE team)
>> tested in our overlay, but none of the packages there use the
>> base_src_* calls, which is why it didn't come up in testing, and
>> I did not realize that there were packages that did rely on the
>> implicit base inherit to call base_src_* directly.
> 
> ...and that is why it isn't permitted to directly use an eclass
> that you don't inherit.  While I agree testing could (should) have
> been better, the fact that people ignore the rules for writing
> ebuilds shouldn't entirely fall on the KDE team.
> 

It doesn't matter in the slightest whos fault it is or who should be
blamed.

It is about maintaining stability for the user. Especially when it
comes to stable ebuilds.

That means the methods for eclass changes must be more thoroughly.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJR5w3sAAoJEFpvPKfnPDWzPLEH/jXlCgVFOFT2lj3OPxjE8E7o
6IFEPMFUwlEvWHGnCXG2Go8f9UEUxinvzfE6x0K8IT2NrffBbTjDvM1n/aJmNMkf
89pLjCqsra6iM4WJhIGxoXq/lIJcoJ3dJkxMS6kz7U0VWeH2wTAY0pQ/qIlJ3e30
XHcXhQZP9LzD1GEA43v0bO9FRYuh/zjJpzNVGHsj3jUmijQsglYyMSN8YGS4vBbe
y5gCHZcsjMOWkRlzUsCd0qn3EF6WgUzs9Ty7MreRDoI4pfvxcVu0PrhcrciLOCzx
2OHylKFU6btOJpUrjYJbUss+53jfPWLvo8AThz/I6ClItJxGjNsrDukpdtXXH6A=
=Tc2N
-----END PGP SIGNATURE-----