public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Chris Reffett <creffett@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] cmake-utils.eclass and bug 475502
Date: Wed, 17 Jul 2013 17:17:41 -0400	[thread overview]
Message-ID: <51E709F5.8020802@gentoo.org> (raw)
In-Reply-To: <51E7051C.1070401@gentoo.org>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/17/2013 04:57 PM, hasufell wrote:
> I know there was an announcement about the upcoming change to 
> cmake-utils.eclass, however... it is not enough to give a deadline 
> without caring if people actually fixed it by then.
> 
> By doing that you risk breaking stable packages which is not
> trivial.
> 
> You _must_ do a tinderbox run, test that stuff in an overlay or 
> whatever. You are responsible for ALL reverse deps.
> 
> The way it was done... was not appropriate. Please be more careful 
> next time. There are still incoming bugs about broken base_src_* 
> calls. (see the tracker)
> 

I discussed this with hasufell on IRC, but I'll lay out the response
on the list too. Yes, this was my fault. We (KDE team) tested in our
overlay, but none of the packages there use the base_src_* calls,
which is why it didn't come up in testing, and I did not realize that
there were packages that did rely on the implicit base inherit to call
base_src_* directly.

Chris Reffett
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iKYEARECAGYFAlHnCfVfFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl
bnBncC5maWZ0aGhvcnNlbWFuLm5ldEM2NzU5RjUyMDczREJDQkVDQTBDRkE1NERC
Nzk1QThBNDI2MTgzNTQACgkQ23laikJhg1T6ZACcC5cDNBCODxrnzlPCTm+L4EgS
wCkAniqjyBFXhIXeXyb0Wbvufkbw68yS
=QM3o
-----END PGP SIGNATURE-----


  reply	other threads:[~2013-07-17 21:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-17 20:57 [gentoo-dev] cmake-utils.eclass and bug 475502 hasufell
2013-07-17 21:17 ` Chris Reffett [this message]
2013-07-17 21:28   ` Rick "Zero_Chaos" Farina
2013-07-17 21:34     ` hasufell
2013-07-17 21:42       ` Rick "Zero_Chaos" Farina
2013-07-17 21:47         ` hasufell
2013-07-17 21:55           ` Rick "Zero_Chaos" Farina
2013-07-17 22:15             ` hasufell
2013-07-18  7:06         ` Michał Górny
2013-07-18 22:11           ` Zac Medico
2013-07-17 23:09       ` Tom Wijsman
2013-07-18 16:40   ` Alexis Ballier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51E709F5.8020802@gentoo.org \
    --to=creffett@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox