From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 0B68F158020 for ; Wed, 12 Oct 2022 00:20:21 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 57A9BE096C; Wed, 12 Oct 2022 00:20:16 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 195F8E0938 for ; Wed, 12 Oct 2022 00:20:16 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Sam James Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply Mime-Version: 1.0 (1.0) Subject: [gentoo-dev] Re: [PATCH 8/8] kernel-build.eclass: use pbzip2/lbzip2 for parallel compression if available Date: Wed, 12 Oct 2022 01:20:01 +0100 Message-Id: <518FAC7E-1A5E-410F-B554-BDA7012EB811@gentoo.org> References: <20221011225444.56032-8-sam@gentoo.org> Cc: dist-kernel@gentoo.org, kernel@gentoo.org In-Reply-To: <20221011225444.56032-8-sam@gentoo.org> To: gentoo-dev@lists.gentoo.org X-Mailer: iPhone Mail (20A392) X-Archives-Salt: 612974cc-a072-4e41-9f15-f7f6945d315b X-Archives-Hash: e95c083e88b9e75d54b9bd4217c50b66 > On 11 Oct 2022, at 23:55, Sam James wrote: >=20 > =EF=BB=BFNote that this will only take effect if compressing > modules with bzip2 (COMPRESS_MODULE_BZIP2 is set) or > compressing the kernel with bzip2 (CONFIG_KERNEL_BZIP2 is set). >=20 > Signed-off-by: Sam James > --- > eclass/kernel-build.eclass | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) >=20 > diff --git a/eclass/kernel-build.eclass b/eclass/kernel-build.eclass > index faf36d763d08..cc99298811bc 100644 > --- a/eclass/kernel-build.eclass > +++ b/eclass/kernel-build.eclass > @@ -98,13 +98,19 @@ kernel-build_src_configure() { > export ZSTD_NBTHREADS=3D"$(makeopts_jobs)" > fi >=20 > - # pigz needs to take an argument, not an env var, > - # for its options, which won't work because of how the kernel build s= ystem > + # pigz/pbzip2/lbzip2 all need to take an argument, not an env var, > + # for their options, which won't work because of how the kernel build= system > # uses the variables (e.g. passes directly to tar as an executable). > if type -P pigz ; then > MAKEARGS+=3D( KGZIP=3D"pigz" ) > fi >=20 > + if type -P pbzip2 ; then Oh, all of these need a redirection to silence them, which I'll fix locally.=