[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/id3lib: metadata.xml ChangeLog id3lib-3.8.3-r9.ebuild

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/id3lib: metadata.xml ChangeLog id3lib-3.8.3-r9.ebuild

[Samuli Suominen]

On 03/05/13 20:33, Justin Lecher (jlec) wrote:
> jlec        13/05/03 17:33:56
>
>    Modified:             metadata.xml ChangeLog
>    Added:                id3lib-3.8.3-r9.ebuild
>    Log:
>    media-libs/id3lib: Fix obsolete macros to work with automake-1.13, #467704; bumped to EAPI=5 and autotools-utils.eclass
>
>    (Portage version: 2.2.0_alpha173/cvs/Linux x86_64, signed Manifest commit with key 8009D6F070EB7916)
>
> Revision  Changes    Path
> 1.3                  media-libs/id3lib/metadata.xml
>
> file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-libs/id3lib/metadata.xml?rev=1.3&view=markup
> plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-libs/id3lib/metadata.xml?rev=1.3&content-type=text/plain
> diff : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-libs/id3lib/metadata.xml?r1=1.2&r2=1.3
>
> Index: metadata.xml
> ===================================================================
> RCS file: /var/cvsroot/gentoo-x86/media-libs/id3lib/metadata.xml,v
> retrieving revision 1.2
> retrieving revision 1.3
> diff -u -r1.2 -r1.3
> --- metadata.xml	16 Jul 2009 19:18:11 -0000	1.2
> +++ metadata.xml	3 May 2013 17:33:56 -0000	1.3
> @@ -1,5 +1,5 @@
>   <?xml version="1.0" encoding="UTF-8"?>
>   <!DOCTYPE pkgmetadata SYSTEM "http://www.gentoo.org/dtd/metadata.dtd">
>   <pkgmetadata>
> -	<herd>sound</herd>
> +  <herd>sound</herd>
>   </pkgmetadata>

What's the point of kludging unrelated commits like this one...?

>
>
>
> 1.81                 media-libs/id3lib/ChangeLog
>
> file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-libs/id3lib/ChangeLog?rev=1.81&view=markup
> plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-libs/id3lib/ChangeLog?rev=1.81&content-type=text/plain
> diff : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-libs/id3lib/ChangeLog?r1=1.80&r2=1.81
>
> Index: ChangeLog
> ===================================================================
> RCS file: /var/cvsroot/gentoo-x86/media-libs/id3lib/ChangeLog,v
> retrieving revision 1.80
> retrieving revision 1.81
> diff -u -r1.80 -r1.81
> --- ChangeLog	22 Mar 2012 12:33:36 -0000	1.80
> +++ ChangeLog	3 May 2013 17:33:56 -0000	1.81
> @@ -1,6 +1,13 @@
>   # ChangeLog for media-libs/id3lib
> -# Copyright 1999-2012 Gentoo Foundation; Distributed under the GPL v2
> -# $Header: /var/cvsroot/gentoo-x86/media-libs/id3lib/ChangeLog,v 1.80 2012/03/22 12:33:36 ssuominen Exp $
> +# Copyright 1999-2013 Gentoo Foundation; Distributed under the GPL v2
> +# $Header: /var/cvsroot/gentoo-x86/media-libs/id3lib/ChangeLog,v 1.81 2013/05/03 17:33:56 jlec Exp $
> +
> +*id3lib-3.8.3-r9 (03 May 2013)
> +
> +  03 May 2013; Justin Lecher <jlec@gentoo.org> +id3lib-3.8.3-r9.ebuild,
> +  metadata.xml:
> +  Fix obsolete macros to work with automake-1.13, #467704; bumped to EAPI=5 and
> +  autotools-utils.eclass

There was no reason to use autotools-utils.eclass in the ebuild.
Please don't spread the problem in media libraries, you are not even in 
the sound team.

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/id3lib: metadata.xml ChangeLog id3lib-3.8.3-r9.ebuild

[Samuli Suominen]

On 03/05/13 20:56, Samuli Suominen wrote:
> On 03/05/13 20:33, Justin Lecher (jlec) wrote:
>> jlec        13/05/03 17:33:56
>>
>>    Modified:             metadata.xml ChangeLog
>>    Added:                id3lib-3.8.3-r9.ebuild
>>    Log:
>>    media-libs/id3lib: Fix obsolete macros to work with automake-1.13,
>> #467704; bumped to EAPI=5 and autotools-utils.eclass
>>
>>    (Portage version: 2.2.0_alpha173/cvs/Linux x86_64, signed Manifest
>> commit with key 8009D6F070EB7916)
>>
>> Revision  Changes    Path
>> 1.3                  media-libs/id3lib/metadata.xml
>>
>> file :
>> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-libs/id3lib/metadata.xml?rev=1.3&view=markup
>>
>> plain:
>> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-libs/id3lib/metadata.xml?rev=1.3&content-type=text/plain
>>
>> diff :
>> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-libs/id3lib/metadata.xml?r1=1.2&r2=1.3
>>
>>
>> Index: metadata.xml
>> ===================================================================
>> RCS file: /var/cvsroot/gentoo-x86/media-libs/id3lib/metadata.xml,v
>> retrieving revision 1.2
>> retrieving revision 1.3
>> diff -u -r1.2 -r1.3
>> --- metadata.xml    16 Jul 2009 19:18:11 -0000    1.2
>> +++ metadata.xml    3 May 2013 17:33:56 -0000    1.3
>> @@ -1,5 +1,5 @@
>>   <?xml version="1.0" encoding="UTF-8"?>
>>   <!DOCTYPE pkgmetadata SYSTEM "http://www.gentoo.org/dtd/metadata.dtd">
>>   <pkgmetadata>
>> -    <herd>sound</herd>
>> +  <herd>sound</herd>
>>   </pkgmetadata>
>
> What's the point of kludging unrelated commits like this one...?
>
>>
>>
>>
>> 1.81                 media-libs/id3lib/ChangeLog
>>
>> file :
>> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-libs/id3lib/ChangeLog?rev=1.81&view=markup
>>
>> plain:
>> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-libs/id3lib/ChangeLog?rev=1.81&content-type=text/plain
>>
>> diff :
>> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-libs/id3lib/ChangeLog?r1=1.80&r2=1.81
>>
>>
>> Index: ChangeLog
>> ===================================================================
>> RCS file: /var/cvsroot/gentoo-x86/media-libs/id3lib/ChangeLog,v
>> retrieving revision 1.80
>> retrieving revision 1.81
>> diff -u -r1.80 -r1.81
>> --- ChangeLog    22 Mar 2012 12:33:36 -0000    1.80
>> +++ ChangeLog    3 May 2013 17:33:56 -0000    1.81
>> @@ -1,6 +1,13 @@
>>   # ChangeLog for media-libs/id3lib
>> -# Copyright 1999-2012 Gentoo Foundation; Distributed under the GPL v2
>> -# $Header: /var/cvsroot/gentoo-x86/media-libs/id3lib/ChangeLog,v 1.80
>> 2012/03/22 12:33:36 ssuominen Exp $
>> +# Copyright 1999-2013 Gentoo Foundation; Distributed under the GPL v2
>> +# $Header: /var/cvsroot/gentoo-x86/media-libs/id3lib/ChangeLog,v 1.81
>> 2013/05/03 17:33:56 jlec Exp $
>> +
>> +*id3lib-3.8.3-r9 (03 May 2013)
>> +
>> +  03 May 2013; Justin Lecher <jlec@gentoo.org> +id3lib-3.8.3-r9.ebuild,
>> +  metadata.xml:
>> +  Fix obsolete macros to work with automake-1.13, #467704; bumped to
>> EAPI=5 and
>> +  autotools-utils.eclass
>
> There was no reason to use autotools-utils.eclass in the ebuild.
> Please don't spread the problem in media libraries, you are not even in
> the sound team.
>

Heck, with AUTOTOOLS_IN_SOURCE_BUILD=1 it's completely useless.

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/id3lib: metadata.xml ChangeLog id3lib-3.8.3-r9.ebuild

[Justin]

[-- Attachment #1: Type: text/plain, Size: 3339 bytes --]

On 03/05/13 19:56, Samuli Suominen wrote:
> On 03/05/13 20:33, Justin Lecher (jlec) wrote:
>> jlec        13/05/03 17:33:56
>>
>>    Modified:             metadata.xml ChangeLog
>>    Added:                id3lib-3.8.3-r9.ebuild
>>    Log:
>>    media-libs/id3lib: Fix obsolete macros to work with automake-1.13,
>> #467704; bumped to EAPI=5 and autotools-utils.eclass
>>
>>    (Portage version: 2.2.0_alpha173/cvs/Linux x86_64, signed Manifest
>> commit with key 8009D6F070EB7916)
>>
>> Revision  Changes    Path
>> 1.3                  media-libs/id3lib/metadata.xml
>>
>> file :
>> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-libs/id3lib/metadata.xml?rev=1.3&view=markup
>>
>> plain:
>> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-libs/id3lib/metadata.xml?rev=1.3&content-type=text/plain
>>
>> diff :
>> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-libs/id3lib/metadata.xml?r1=1.2&r2=1.3
>>
>>
>> Index: metadata.xml
>> ===================================================================
>> RCS file: /var/cvsroot/gentoo-x86/media-libs/id3lib/metadata.xml,v
>> retrieving revision 1.2
>> retrieving revision 1.3
>> diff -u -r1.2 -r1.3
>> --- metadata.xml    16 Jul 2009 19:18:11 -0000    1.2
>> +++ metadata.xml    3 May 2013 17:33:56 -0000    1.3
>> @@ -1,5 +1,5 @@
>>   <?xml version="1.0" encoding="UTF-8"?>
>>   <!DOCTYPE pkgmetadata SYSTEM "http://www.gentoo.org/dtd/metadata.dtd">
>>   <pkgmetadata>
>> -    <herd>sound</herd>
>> +  <herd>sound</herd>
>>   </pkgmetadata>
> 
> What's the point of kludging unrelated commits like this one...?

You personally told me, that you want to have metadata.xml indented with
two spaces. Did you change your own style?

> 
>>
>>
>>
>> 1.81                 media-libs/id3lib/ChangeLog
>>
>> file :
>> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-libs/id3lib/ChangeLog?rev=1.81&view=markup
>>
>> plain:
>> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-libs/id3lib/ChangeLog?rev=1.81&content-type=text/plain
>>
>> diff :
>> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-libs/id3lib/ChangeLog?r1=1.80&r2=1.81
>>
>>
>> Index: ChangeLog
>> ===================================================================
>> RCS file: /var/cvsroot/gentoo-x86/media-libs/id3lib/ChangeLog,v
>> retrieving revision 1.80
>> retrieving revision 1.81
>> diff -u -r1.80 -r1.81
>> --- ChangeLog    22 Mar 2012 12:33:36 -0000    1.80
>> +++ ChangeLog    3 May 2013 17:33:56 -0000    1.81
>> @@ -1,6 +1,13 @@
>>   # ChangeLog for media-libs/id3lib
>> -# Copyright 1999-2012 Gentoo Foundation; Distributed under the GPL v2
>> -# $Header: /var/cvsroot/gentoo-x86/media-libs/id3lib/ChangeLog,v 1.80
>> 2012/03/22 12:33:36 ssuominen Exp $
>> +# Copyright 1999-2013 Gentoo Foundation; Distributed under the GPL v2
>> +# $Header: /var/cvsroot/gentoo-x86/media-libs/id3lib/ChangeLog,v 1.81
>> 2013/05/03 17:33:56 jlec Exp $
>> +
>> +*id3lib-3.8.3-r9 (03 May 2013)
>> +
>> +  03 May 2013; Justin Lecher <jlec@gentoo.org> +id3lib-3.8.3-r9.ebuild,
>> +  metadata.xml:
>> +  Fix obsolete macros to work with automake-1.13, #467704; bumped to
>> EAPI=5 and
>> +  autotools-utils.eclass
> 
> There was no reason to use autotools-utils.eclass in the ebuild.

Any reason to not using it?


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/id3lib: metadata.xml ChangeLog id3lib-3.8.3-r9.ebuild

[Jeroen Roovers]

On Fri, 03 May 2013 20:18:42 +0200
Justin <jlec@gentoo.org> wrote:

> >> +  03 May 2013; Justin Lecher <jlec@gentoo.org>
> >> +id3lib-3.8.3-r9.ebuild,
> >> +  metadata.xml:
> >> +  Fix obsolete macros to work with automake-1.13, #467704; bumped
> >> to EAPI=5 and
> >> +  autotools-utils.eclass
> > 
> > There was no reason to use autotools-utils.eclass in the ebuild.
> 
> Any reason to not using it?

I think he answered that already in his reply to self. It adds useless
cruft and then doesn't use it. (Also, why do a revision bump and leave
the stable revision unfixed?)


     jer

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/id3lib: metadata.xml ChangeLog id3lib-3.8.3-r9.ebuild

[vivo75]

Il 04/05/2013 19:42, Jeroen Roovers ha scritto:
> On Fri, 03 May 2013 20:18:42 +0200
> Justin <jlec@gentoo.org> wrote:
>
>>>> +  03 May 2013; Justin Lecher <jlec@gentoo.org>
>>>> +id3lib-3.8.3-r9.ebuild,
>>>> +  metadata.xml:
>>>> +  Fix obsolete macros to work with automake-1.13, #467704; bumped
>>>> to EAPI=5 and
>>>> +  autotools-utils.eclass
>>> There was no reason to use autotools-utils.eclass in the ebuild.
>> Any reason to not using it?
> I think he answered that already in his reply to self. It adds useless
> cruft and then doesn't use it. 
could not comment to this
> (Also, why do a revision bump and leave
> the stable revision unfixed?)
>
but this:
because automake-1.13 is _not_ stable an because there are enough
changes to risk to break it?
revision bump has been a good idea

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/id3lib: metadata.xml ChangeLog id3lib-3.8.3-r9.ebuild

[Jeroen Roovers]

On Sat, 04 May 2013 19:49:03 +0200
"vivo75@gmail.com" <vivo75@gmail.com> wrote:

> > (Also, why do a revision bump and leave
> > the stable revision unfixed?)
> >
> but this:
> because automake-1.13 is _not_ stable an because there are enough
> changes to risk to break it?

The fix changes a single line in a source file in a predictable way.


     jer

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/id3lib: metadata.xml ChangeLog id3lib-3.8.3-r9.ebuild

["Paweł Hajdan, Jr."]

[-- Attachment #1: Type: text/plain, Size: 1181 bytes --]

On 5/5/13 6:20 AM, Jeroen Roovers wrote:
> On Sat, 04 May 2013 19:49:03 +0200
> "vivo75@gmail.com" <vivo75@gmail.com> wrote:
> 
>>> (Also, why do a revision bump and leave
>>> the stable revision unfixed?)
>>>
>> but this:
>> because automake-1.13 is _not_ stable an because there are enough
>> changes to risk to break it?
> 
> The fix changes a single line in a source file in a predictable way.

I trust maintainer's judgement.

We have Gentoo developers who are strongly opposed to making _any_
changes to stable ebuilds. I'm in fact leaning towards that group.

And we also have developers who see no reasons not to change stable
ebuilds in "trivial" ways (the question remains what is trivial and what
is not, and how trivial changes can still break things).

The way I see to resolve this - which I think is accurate description of
what's happening - is to let maintainers handle the fixes in the way
they think is best (after all, they are most knowledgeable about the
package in question).

Anyone else is free to file a stabilization request and do his own
testing - in fact, I also support stable not being too far behind ~arch.

Paweł


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 203 bytes --]