From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id E21241381F3 for ; Thu, 2 May 2013 13:54:44 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 70868E0A9C; Thu, 2 May 2013 13:54:41 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 862CEE09E0 for ; Thu, 2 May 2013 13:54:40 +0000 (UTC) Received: from [192.168.4.5] (blfd-5d823462.pool.mediaWays.net [93.130.52.98]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: hasufell) by smtp.gentoo.org (Postfix) with ESMTPSA id 593F133BE0E for ; Thu, 2 May 2013 13:54:39 +0000 (UTC) Message-ID: <5182701C.8040209@gentoo.org> Date: Thu, 02 May 2013 15:54:36 +0200 From: hasufell User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130412 Thunderbird/17.0.5 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] gnome-games.eclass: Eclass for installing all gnome-games References: <1367491272.21951.8.camel@localhost> <51825D64.2010905@gentoo.org> <1367502051.21951.12.camel@localhost> In-Reply-To: <1367502051.21951.12.camel@localhost> X-Enigmail-Version: 1.6a1pre Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Archives-Salt: e748df6e-328a-4c6e-acac-c4a35cb7f26a X-Archives-Hash: 65b22933a0c5396ff6c991a7a4f8d8f8 On 05/02/2013 03:40 PM, Pacho Ramos wrote: > El jue, 02-05-2013 a las 14:34 +0200, hasufell escribió: >> On 05/02/2013 12:41 PM, Pacho Ramos wrote: >>> gnome-games was splitted in separate packages per game and, then, we >>> need an eclass to also set proper settings inherited from gnome2 and >>> games eclasses. This should also solve: >>> https://bugs.gentoo.org/show_bug.cgi?id=432848 >>> >>> eclass and ebuild (games-puzzle/five-or-more) to try attached >>> >> >> This does not honour GAMES_DATADIR afais. > > They cannot honor it since installing all stuff under /usr/share/games > will lead to them even failing to start (I tried it before). > Why? It's a common problem that people hardcode data dir destination in their source files, assuming that people only want to install into /usr/share. That is simply a bug and needs to be fixed in the package (it also means it will probably fail for /usr/local and many other usecases, so this is not even a gentoo specific bug). You cannot fix that on eclass level and it is not a reason to drop supporting GAMES_DATADIR variable. That is inconsistent and does not make sense. You would even get mixed permissions unless you fix that up too. >> >> "prepgamesdirs" is missing completely too. >> >> So those games will not be compliant with the games.eclass standard. >> > > In games.eclass I see you have prepgamesdirs but don't call it on any > exported phase from games.eclass :-/, how are other games calling it? > > You call it explicitly.