From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 822E31381F3 for ; Sat, 13 Apr 2013 01:05:02 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 892FDE08C2; Sat, 13 Apr 2013 01:04:57 +0000 (UTC) Received: from spot.xmw.de (spot.xmw.de [176.9.87.236]) by pigeon.gentoo.org (Postfix) with ESMTP id 96DA3E0866 for ; Sat, 13 Apr 2013 01:04:56 +0000 (UTC) Received: from [IPv6:2001:6f8:1cd1:0:21d:72ff:fe88:9ac1] (x.l.xmw.de [IPv6:2001:6f8:1cd1:0:21d:72ff:fe88:9ac1]) by spot.xmw.de (Postfix) with ESMTPSA id 45A3F1410B10D for ; Sat, 13 Apr 2013 03:04:55 +0200 (CEST) Message-ID: <5168AF33.2020707@gentoo.org> Date: Sat, 13 Apr 2013 03:04:51 +0200 From: Michael Weber User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130408 Thunderbird/17.0.5 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Pass "${@}" in phase functions Re: [gentoo-dev] [PATCH] Introduce cmake-multilib wrapper for cmake-utils. References: <20130206105605.32b55a8d@pomiocik.lan> <1360144960-1327-1-git-send-email-mgorny@gentoo.org> In-Reply-To: <1360144960-1327-1-git-send-email-mgorny@gentoo.org> X-Enigmail-Version: 1.6a1pre Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Archives-Salt: 6dcc141c-5b80-4ca6-8091-f2f5f72db897 X-Archives-Hash: 1e826d6c44ffe823545ed1278b45673a Hi, I'm not sure if it's a sane way to push make -j1 via src_compile() { cmake-multilib_src_compile -j1 } but I detected a lack of functionality in the current cmake-multilib.eclass. Both cmake-utils.eclass and multilib-build.eclass have it, so it might be sound to continue with this behavior. Comments, pls. Michael Index: cmake-multilib.eclass =================================================================== RCS file: /var/cvsroot/gentoo-x86/eclass/cmake-multilib.eclass,v retrieving revision 1.1 diff -u -B -r1.1 cmake-multilib.eclass --- cmake-multilib.eclass 10 Feb 2013 11:44:55 -0000 1.1 +++ cmake-multilib.eclass 13 Apr 2013 00:58:17 -0000 @@ -33,24 +33,24 @@ EXPORT_FUNCTIONS src_configure src_compile src_test src_install cmake-multilib_src_configure() { - multilib_parallel_foreach_abi cmake-utils_src_configure + multilib_parallel_foreach_abi cmake-utils_src_configure "${@}" } cmake-multilib_src_compile() { - multilib_foreach_abi cmake-utils_src_compile + multilib_foreach_abi cmake-utils_src_compile "${@}" } cmake-multilib_src_test() { - multilib_foreach_abi cmake-utils_src_test + multilib_foreach_abi cmake-utils_src_test "${@}" } cmake-multilib_src_install() { cmake-multilib_secure_install() { - cmake-utils_src_install + cmake-utils_src_install "${@}" # Make sure all headers are the same for each ABI. multilib_check_headers } - multilib_foreach_abi cmake-multilib_secure_install + multilib_foreach_abi cmake-multilib_secure_install "${@}" } -- Michael Weber Gentoo Developer web: https://xmw.de/ mailto: Michael Weber