From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 733D6138010 for ; Wed, 3 Apr 2013 09:40:48 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id A1674E0D54; Wed, 3 Apr 2013 09:40:44 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id B2263E0D4F for ; Wed, 3 Apr 2013 09:40:43 +0000 (UTC) Received: from [192.168.178.20] (pD9E9FAD9.dip.t-dialin.net [217.233.250.217]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: tommy) by smtp.gentoo.org (Postfix) with ESMTPSA id 7FA7833DC93 for ; Wed, 3 Apr 2013 09:40:42 +0000 (UTC) Message-ID: <515BF90F.40107@gentoo.org> Date: Wed, 03 Apr 2013 11:40:31 +0200 From: Thomas Sachau User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20100101 Firefox/19.0 SeaMonkey/2.16.2 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCHES] multilib-build: use MULTILIB_ABI for eclass-specific ABI value References: <20130402234242.5c97d709@pomiocik.lan> In-Reply-To: <20130402234242.5c97d709@pomiocik.lan> X-Enigmail-Version: 1.6a1pre OpenPGP: id=211CA2D4 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="----enig2HUMFASUXVSDKQSIBXXGT" X-Archives-Salt: 7e2cef22-00f0-4793-b0a5-888d40155096 X-Archives-Hash: 0a106ab58064a15e9726ad5216f89ef7 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2HUMFASUXVSDKQSIBXXGT Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Micha=C5=82 G=C3=B3rny schrieb: > Hello, >=20 > Currently, the multilib-build eclass uses abi_* constants only for USE > flags and only ${ABI} is exported to the function. This is bad since it= > basically requires a reverse mapping of ABI->abi_* values, often > inlined as ${ABI} checks. >=20 > The patches which I will send in reply to this thread aim to fix it. >=20 > The first patch changes the eclass logic. The abi_* values, with 'abi_'= > prefix stripped, are called MULTILIB_ABI now. They are used to run > the 'foreach' functions, and now are set in the called functions along > with ABI. >=20 > As a downside, the switch required the MULTILIB_ABI -> ABI mapping to > occur inside foreach -- as in, another 'for' loop. It shouldn't cause > any noticeable difference. >=20 > Additionally, the 'default' fallback no longer calls > multilib_toolchain_setup. This should improve compatibility with > multilib-portage and *maybe* cross-compiling. You know, that multilib-portage does use MULTILIB_ABI as USE-expanded variable? Using exactly the same in the eclass will call for collision issues. --=20 Thomas Sachau Gentoo Linux Developer ------enig2HUMFASUXVSDKQSIBXXGT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with SeaMonkey - http://www.enigmail.net/ iJwEAQECAAYFAlFb+RYACgkQG7kqcTWJkGe/tAQAnWJPUNpafJf5zPvOoc4NBIqu MmaE7RvCTlOdjqmaYXZBctCnvnPBtjVjlwC/psdsFNDRTfdsCrtAOhWLu6Xdcv3M uIvpBWE/Cnx6nF3TOiV15HotIn0EIdI5ukN+p1pj+q3ktZ2krQKp8hjfXzBBDaNC I5mlb974UG6Rqo4LRIk= =I0ch -----END PGP SIGNATURE----- ------enig2HUMFASUXVSDKQSIBXXGT--