From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id C731E138010 for ; Tue, 26 Mar 2013 22:16:11 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B9FC7E08EF; Tue, 26 Mar 2013 22:16:08 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id E7C76E08D5 for ; Tue, 26 Mar 2013 22:16:07 +0000 (UTC) Received: from [192.168.1.2] (pool-173-77-245-118.nycmny.fios.verizon.net [173.77.245.118]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: ryao) by smtp.gentoo.org (Postfix) with ESMTPSA id B3EE633DB98; Tue, 26 Mar 2013 22:16:06 +0000 (UTC) Message-ID: <51521E0A.8000506@gentoo.org> Date: Tue, 26 Mar 2013 18:15:38 -0400 From: Richard Yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130324 Thunderbird/17.0.4 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: hasufell CC: gentoo-dev@lists.gentoo.org, games@gentoo.org, mgorny@gentoo.org Subject: [gentoo-dev] Re: New eclass: games-bin (review/comments) References: <514E1667.8030604@gentoo.org> In-Reply-To: <514E1667.8030604@gentoo.org> X-Enigmail-Version: 1.5 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="----enig2WTILKVIOTFRBBJIGQDND" X-Archives-Salt: 98924846-c3f2-473d-9cf5-8e02063b1881 X-Archives-Hash: 062f5a9b4e2b4b5c8deb7b47d69f1eb5 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2WTILKVIOTFRBBJIGQDND Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/23/2013 04:53 PM, hasufell wrote: > After packaging the complete humble bundle last time I noticed a bit > of code duplication. > Nothing serious, but I still think there could be a small eclass > making things easier. >=20 > Especially the "remove_bundled_libs" function and the is useful IMO > and allows to easily remove those things. > The GAMES_PRESERVE_BUNDLED_LIBS array would allow to preserve libs, > e.g. stuff like "libbass" which is not present in the tree and even > GAMES_PRESERVE_BUNDLED_LIBS_amd64 (in case we have a 32bit only game > and there are no multilib versions for some of those libs). >=20 > It also works well with a "bundled-libs" useflag (see > games-bin_src_prepare), because it can happen that binary games break > while the tree is moving forward with library versions, or that system > libraries create weird blockers for the user or even cause runtime > breakage (which happened with the editor of games-rpg/grimrock wrt > #454934). >=20 > Most bin games use some functions from unpacker.eclass, so it is > inherited and used in games-bin_src_unpack by default. >=20 > I was also thinking about some check-reqs thing, but it's probably > better that is handled explicitly. >=20 >=20 > If you have suggestions or if you think that approach sucks, please > tell me. >=20 If it works, I see no reason not to commit it. It has my okay. ------enig2WTILKVIOTFRBBJIGQDND Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRUh4NAAoJECDuEZm+6Exk9ucP/jl9/WOcQUZHAjRdNaF75+0g rCZRdWxwIjXUnkftORqx688z0Z619+IQKg8rvQMBSyVKjlmhbkXYm3exuQX9ELQD tdOrN7gDt+f8ssR8qGqksgzMthnnN5bDr3/Fg1eBFH9snTNVZ7MuU8k3wp6nCWRi CPIiUR2fYR/eqLIwj6wNwgjUvrAHCKbid4780s9TtvwJQMCl6hjDAeBNBaUOhWfS NlX1+HY9uyUl0wJ/2w2yaDzlv+5owOh9Wukdi6w6g+MnR7Hohl2xR9iN1ZQdW7ZL QUYHCpJ1Xj95bofDEYHYLLR3YcC5efpXe66z8QiMGVAny8UYrkJI5LmkwCQa2J3z CqGwq+G9HwQpAua3A6gATyqKSuBq6NGcC3QzAToI5ebNaM76FOeKs7KxHZv9Wa9e hiGHrpztwAQ+50yfBVJLc5yA0UkkhM+jq5BMrrfH+NmosJu7zVV1eZ9qxjh2Q2Dy +Dmunho1UxV6rXdFd3Twn9MH4doouHmYZtA2SL0ebB3gbW2atcyAOW+wF61TXYLa Jq9pk7mERJXPYemJFXpxK+f/oaNlwbd8ocE+gqDF4D0e+G/7taC8phzmaDPNeaCy 9tyXATW36sNri6laCUO1Cw/DMY68si1QeQ7H/CSnHSeBsyD5SE4ehWKAI26O0D3w jrMIKlz2QaThZ/QM1Hyq =sqMh -----END PGP SIGNATURE----- ------enig2WTILKVIOTFRBBJIGQDND--